[jira] [Commented] (HDFS-6493) Propose to change dfs.namenode.startup.delay.block.deletion to second instead of millisecond
[ https://issues.apache.org/jira/browse/HDFS-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051856#comment-14051856 ] Andrew Wang commented on HDFS-6493: --- +1 LGTM, will commit this shortly. Propose to change dfs.namenode.startup.delay.block.deletion to second instead of millisecond -- Key: HDFS-6493 URL: https://issues.apache.org/jira/browse/HDFS-6493 Project: Hadoop HDFS Issue Type: Bug Reporter: Juan Yu Assignee: Juan Yu Priority: Trivial Attachments: HDFS-6493.001.patch Based on the discussion in https://issues.apache.org/jira/browse/HDFS-6186, the delay will be at least 30 minutes or even hours. it's not very user friendly to use milliseconds when it's likely measured in hours. I suggest to make the following change 1. change the unit of this config to second 2. rename the config key from dfs.namenode.startup.delay.block.deletion.ms to dfs.namenode.startup.delay.block.deletion.sec 3. add the default value to hdfs-default.xml, what's the reasonable value, 30 minutes, one hour? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6493) Propose to change dfs.namenode.startup.delay.block.deletion to second instead of millisecond
[ https://issues.apache.org/jira/browse/HDFS-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026522#comment-14026522 ] Juan Yu commented on HDFS-6493: --- Thanks for the suggestion. Propose to change dfs.namenode.startup.delay.block.deletion to second instead of millisecond -- Key: HDFS-6493 URL: https://issues.apache.org/jira/browse/HDFS-6493 Project: Hadoop HDFS Issue Type: Bug Reporter: Juan Yu Assignee: Juan Yu Priority: Trivial Based on the discussion in https://issues.apache.org/jira/browse/HDFS-6186, the delay will be at least 30 minutes or even hours. it's not very user friendly to use milliseconds when it's likely measured in hours. I suggest to make the following change 1. change the unit of this config to second 2. rename the config key from dfs.namenode.startup.delay.block.deletion.ms to dfs.namenode.startup.delay.block.deletion.sec 3. add the default value to hdfs-default.xml, what's the reasonable value, 30 minutes, one hour? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6493) Propose to change dfs.namenode.startup.delay.block.deletion to second instead of millisecond
[
https://issues.apache.org/jira/browse/HDFS-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026774#comment-14026774
]
Hadoop QA commented on HDFS-6493:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12649593/HDFS-6493.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7073//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7073//console
This message is automatically generated.
Propose to change dfs.namenode.startup.delay.block.deletion to second
instead of millisecond
--
Key: HDFS-6493
URL: https://issues.apache.org/jira/browse/HDFS-6493
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Juan Yu
Assignee: Juan Yu
Priority: Trivial
Attachments: HDFS-6493.001.patch
Based on the discussion in https://issues.apache.org/jira/browse/HDFS-6186,
the delay will be at least 30 minutes or even hours. it's not very user
friendly to use milliseconds when it's likely measured in hours.
I suggest to make the following change
1. change the unit of this config to second
2. rename the config key from dfs.namenode.startup.delay.block.deletion.ms
to dfs.namenode.startup.delay.block.deletion.sec
3. add the default value to hdfs-default.xml, what's the reasonable value, 30
minutes, one hour?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6493) Propose to change dfs.namenode.startup.delay.block.deletion to second instead of millisecond
[ https://issues.apache.org/jira/browse/HDFS-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025504#comment-14025504 ] Andrew Wang commented on HDFS-6493: --- I think we should keep the default value to disabled, but the property and this value should be documented in hdfs-default.xml. It'd also be nice (if not true already) to pretty print this value on NN startup, e.g. 30 minutes rather than 1800 seconds. It'd actually be nice follow-on work to look for similarly unfriendly values in the logs and pretty printing them. There are some time-related function in DFSUtil (e.g. durationToString, datetoIso8601String), but feel free to write your own functions too. Propose to change dfs.namenode.startup.delay.block.deletion to second instead of millisecond -- Key: HDFS-6493 URL: https://issues.apache.org/jira/browse/HDFS-6493 Project: Hadoop HDFS Issue Type: Bug Reporter: Juan Yu Assignee: Juan Yu Priority: Trivial Based on the discussion in https://issues.apache.org/jira/browse/HDFS-6186, the delay will be at least 30 minutes or even hours. it's not very user friendly to use milliseconds when it's likely measured in hours. I suggest to make the following change 1. change the unit of this config to second 2. rename the config key from dfs.namenode.startup.delay.block.deletion.ms to dfs.namenode.startup.delay.block.deletion.sec 3. add the default value to hdfs-default.xml, what's the reasonable value, 30 minutes, one hour? -- This message was sent by Atlassian JIRA (v6.2#6252)
