[jira] [Commented] (HDFS-6558) Missing '\n' in the description of dfsadmin -rollingUpgrade
[
https://issues.apache.org/jira/browse/HDFS-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053765#comment-14053765
]
Chen He commented on HDFS-6558:
---
Previous code is using \n, I just keep them consistent. :). Thank you for the
suggestion, [~sureshms].
> Missing '\n' in the description of dfsadmin -rollingUpgrade
> ---
>
> Key: HDFS-6558
> URL: https://issues.apache.org/jira/browse/HDFS-6558
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Akira AJISAKA
>Assignee: Chen He
>Priority: Trivial
> Labels: newbie
> Fix For: 3.0.0, 2.5.0
>
> Attachments: HDFS-6558.patch
>
>
> In DFSAdmin.java, '\n' should be added at the end of the line
> {code}
> + " prepare: prepare a new rolling upgrade."
> {code}
> to clean up the following help message.
> {code}
> $ hdfs dfsadmin -help rollingUpgrade
> -rollingUpgrade []:
> query: query the current rolling upgrade status.
>prepare: prepare a new rolling upgrade. finalize: finalize the current
> rolling upgrade.
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6558) Missing '\n' in the description of dfsadmin -rollingUpgrade
[
https://issues.apache.org/jira/browse/HDFS-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048964#comment-14048964
]
Suresh Srinivas commented on HDFS-6558:
---
[~airbots], it would be better to use platform independed %n instead of \n.
> Missing '\n' in the description of dfsadmin -rollingUpgrade
> ---
>
> Key: HDFS-6558
> URL: https://issues.apache.org/jira/browse/HDFS-6558
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Akira AJISAKA
>Assignee: Chen He
>Priority: Trivial
> Labels: newbie
> Fix For: 3.0.0, 2.5.0
>
> Attachments: HDFS-6558.patch
>
>
> In DFSAdmin.java, '\n' should be added at the end of the line
> {code}
> + " prepare: prepare a new rolling upgrade."
> {code}
> to clean up the following help message.
> {code}
> $ hdfs dfsadmin -help rollingUpgrade
> -rollingUpgrade []:
> query: query the current rolling upgrade status.
>prepare: prepare a new rolling upgrade. finalize: finalize the current
> rolling upgrade.
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6558) Missing '\n' in the description of dfsadmin -rollingUpgrade
[
https://issues.apache.org/jira/browse/HDFS-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048954#comment-14048954
]
Hudson commented on HDFS-6558:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1818 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1818/])
HDFS-6558. Missing newline in the description of dfsadmin -rollingUpgrade.
Contributed by Chen He. (kihwal:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1606855)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
> Missing '\n' in the description of dfsadmin -rollingUpgrade
> ---
>
> Key: HDFS-6558
> URL: https://issues.apache.org/jira/browse/HDFS-6558
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Akira AJISAKA
>Assignee: Chen He
>Priority: Trivial
> Labels: newbie
> Fix For: 3.0.0, 2.5.0
>
> Attachments: HDFS-6558.patch
>
>
> In DFSAdmin.java, '\n' should be added at the end of the line
> {code}
> + " prepare: prepare a new rolling upgrade."
> {code}
> to clean up the following help message.
> {code}
> $ hdfs dfsadmin -help rollingUpgrade
> -rollingUpgrade []:
> query: query the current rolling upgrade status.
>prepare: prepare a new rolling upgrade. finalize: finalize the current
> rolling upgrade.
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6558) Missing '\n' in the description of dfsadmin -rollingUpgrade
[
https://issues.apache.org/jira/browse/HDFS-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048860#comment-14048860
]
Hudson commented on HDFS-6558:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #1791 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1791/])
HDFS-6558. Missing newline in the description of dfsadmin -rollingUpgrade.
Contributed by Chen He. (kihwal:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1606855)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
> Missing '\n' in the description of dfsadmin -rollingUpgrade
> ---
>
> Key: HDFS-6558
> URL: https://issues.apache.org/jira/browse/HDFS-6558
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Akira AJISAKA
>Assignee: Chen He
>Priority: Trivial
> Labels: newbie
> Fix For: 3.0.0, 2.5.0
>
> Attachments: HDFS-6558.patch
>
>
> In DFSAdmin.java, '\n' should be added at the end of the line
> {code}
> + " prepare: prepare a new rolling upgrade."
> {code}
> to clean up the following help message.
> {code}
> $ hdfs dfsadmin -help rollingUpgrade
> -rollingUpgrade []:
> query: query the current rolling upgrade status.
>prepare: prepare a new rolling upgrade. finalize: finalize the current
> rolling upgrade.
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6558) Missing '\n' in the description of dfsadmin -rollingUpgrade
[
https://issues.apache.org/jira/browse/HDFS-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048768#comment-14048768
]
Hudson commented on HDFS-6558:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #600 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/600/])
HDFS-6558. Missing newline in the description of dfsadmin -rollingUpgrade.
Contributed by Chen He. (kihwal:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1606855)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
> Missing '\n' in the description of dfsadmin -rollingUpgrade
> ---
>
> Key: HDFS-6558
> URL: https://issues.apache.org/jira/browse/HDFS-6558
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Akira AJISAKA
>Assignee: Chen He
>Priority: Trivial
> Labels: newbie
> Fix For: 3.0.0, 2.5.0
>
> Attachments: HDFS-6558.patch
>
>
> In DFSAdmin.java, '\n' should be added at the end of the line
> {code}
> + " prepare: prepare a new rolling upgrade."
> {code}
> to clean up the following help message.
> {code}
> $ hdfs dfsadmin -help rollingUpgrade
> -rollingUpgrade []:
> query: query the current rolling upgrade status.
>prepare: prepare a new rolling upgrade. finalize: finalize the current
> rolling upgrade.
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6558) Missing '\n' in the description of dfsadmin -rollingUpgrade
[
https://issues.apache.org/jira/browse/HDFS-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047941#comment-14047941
]
Hudson commented on HDFS-6558:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #5801 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/5801/])
HDFS-6558. Missing newline in the description of dfsadmin -rollingUpgrade.
Contributed by Chen He. (kihwal:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1606855)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
> Missing '\n' in the description of dfsadmin -rollingUpgrade
> ---
>
> Key: HDFS-6558
> URL: https://issues.apache.org/jira/browse/HDFS-6558
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Akira AJISAKA
>Assignee: Chen He
>Priority: Trivial
> Labels: newbie
> Fix For: 3.0.0, 2.5.0
>
> Attachments: HDFS-6558.patch
>
>
> In DFSAdmin.java, '\n' should be added at the end of the line
> {code}
> + " prepare: prepare a new rolling upgrade."
> {code}
> to clean up the following help message.
> {code}
> $ hdfs dfsadmin -help rollingUpgrade
> -rollingUpgrade []:
> query: query the current rolling upgrade status.
>prepare: prepare a new rolling upgrade. finalize: finalize the current
> rolling upgrade.
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6558) Missing '\n' in the description of dfsadmin -rollingUpgrade
[
https://issues.apache.org/jira/browse/HDFS-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047932#comment-14047932
]
Kihwal Lee commented on HDFS-6558:
--
I've committed this to trunk and branch-2. Thanks for fixing and reviewing
this, gentlemen.
> Missing '\n' in the description of dfsadmin -rollingUpgrade
> ---
>
> Key: HDFS-6558
> URL: https://issues.apache.org/jira/browse/HDFS-6558
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Akira AJISAKA
>Assignee: Chen He
>Priority: Trivial
> Labels: newbie
> Fix For: 3.0.0, 2.5.0
>
> Attachments: HDFS-6558.patch
>
>
> In DFSAdmin.java, '\n' should be added at the end of the line
> {code}
> + " prepare: prepare a new rolling upgrade."
> {code}
> to clean up the following help message.
> {code}
> $ hdfs dfsadmin -help rollingUpgrade
> -rollingUpgrade []:
> query: query the current rolling upgrade status.
>prepare: prepare a new rolling upgrade. finalize: finalize the current
> rolling upgrade.
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6558) Missing '\n' in the description of dfsadmin -rollingUpgrade
[
https://issues.apache.org/jira/browse/HDFS-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047929#comment-14047929
]
Kihwal Lee commented on HDFS-6558:
--
+1 lgtm
> Missing '\n' in the description of dfsadmin -rollingUpgrade
> ---
>
> Key: HDFS-6558
> URL: https://issues.apache.org/jira/browse/HDFS-6558
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Akira AJISAKA
>Assignee: Chen He
>Priority: Trivial
> Labels: newbie
> Attachments: HDFS-6558.patch
>
>
> In DFSAdmin.java, '\n' should be added at the end of the line
> {code}
> + " prepare: prepare a new rolling upgrade."
> {code}
> to clean up the following help message.
> {code}
> $ hdfs dfsadmin -help rollingUpgrade
> -rollingUpgrade []:
> query: query the current rolling upgrade status.
>prepare: prepare a new rolling upgrade. finalize: finalize the current
> rolling upgrade.
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6558) Missing '\n' in the description of dfsadmin -rollingUpgrade
[
https://issues.apache.org/jira/browse/HDFS-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036627#comment-14036627
]
Akira AJISAKA commented on HDFS-6558:
-
The patch is just to fix the formatting, so new tests are not needed.
> Missing '\n' in the description of dfsadmin -rollingUpgrade
> ---
>
> Key: HDFS-6558
> URL: https://issues.apache.org/jira/browse/HDFS-6558
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Akira AJISAKA
>Assignee: Chen He
>Priority: Trivial
> Labels: newbie
> Attachments: HDFS-6558.patch
>
>
> In DFSAdmin.java, '\n' should be added at the end of the line
> {code}
> + " prepare: prepare a new rolling upgrade."
> {code}
> to clean up the following help message.
> {code}
> $ hdfs dfsadmin -help rollingUpgrade
> -rollingUpgrade []:
> query: query the current rolling upgrade status.
>prepare: prepare a new rolling upgrade. finalize: finalize the current
> rolling upgrade.
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6558) Missing '\n' in the description of dfsadmin -rollingUpgrade
[
https://issues.apache.org/jira/browse/HDFS-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036624#comment-14036624
]
Hadoop QA commented on HDFS-6558:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12651231/HDFS-6558.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7165//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7165//console
This message is automatically generated.
> Missing '\n' in the description of dfsadmin -rollingUpgrade
> ---
>
> Key: HDFS-6558
> URL: https://issues.apache.org/jira/browse/HDFS-6558
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Akira AJISAKA
>Assignee: Chen He
>Priority: Trivial
> Labels: newbie
> Attachments: HDFS-6558.patch
>
>
> In DFSAdmin.java, '\n' should be added at the end of the line
> {code}
> + " prepare: prepare a new rolling upgrade."
> {code}
> to clean up the following help message.
> {code}
> $ hdfs dfsadmin -help rollingUpgrade
> -rollingUpgrade []:
> query: query the current rolling upgrade status.
>prepare: prepare a new rolling upgrade. finalize: finalize the current
> rolling upgrade.
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6558) Missing '\n' in the description of dfsadmin -rollingUpgrade
[
https://issues.apache.org/jira/browse/HDFS-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036298#comment-14036298
]
Akira AJISAKA commented on HDFS-6558:
-
+1 (non-binding). Starting Jenkins.
> Missing '\n' in the description of dfsadmin -rollingUpgrade
> ---
>
> Key: HDFS-6558
> URL: https://issues.apache.org/jira/browse/HDFS-6558
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Akira AJISAKA
>Priority: Trivial
> Labels: newbie
> Attachments: HDFS-6558.patch
>
>
> In DFSAdmin.java, '\n' should be added at the end of the line
> {code}
> + " prepare: prepare a new rolling upgrade."
> {code}
> to clean up the following help message.
> {code}
> $ hdfs dfsadmin -help rollingUpgrade
> -rollingUpgrade []:
> query: query the current rolling upgrade status.
>prepare: prepare a new rolling upgrade. finalize: finalize the current
> rolling upgrade.
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
