[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[ https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599591#comment-14599591 ] Hudson commented on HDFS-6564: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2184 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2184/]) HDFS-6564. Use slf4j instead of common-logging in hdfs-client. Contributed by Rakesh R. (wheat9: rev 122cad6aec5839d8d515c5008425ecb34f2fa56b) * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/CachePoolInfo.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java * hadoop-hdfs-project/hadoop-hdfs-client/pom.xml * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/BlockStoragePolicy.java > Use slf4j instead of common-logging in hdfs-client > -- > > Key: HDFS-6564 > URL: https://issues.apache.org/jira/browse/HDFS-6564 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Haohui Mai >Assignee: Rakesh R > Fix For: 2.8.0 > > Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch, > HDFS-6564-03.patch > > > hdfs-client should depends on slf4j instead of common-logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Auto-Re: [jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
您的邮件已收到！谢谢！
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[ https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599553#comment-14599553 ] Hudson commented on HDFS-6564: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #236 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/236/]) HDFS-6564. Use slf4j instead of common-logging in hdfs-client. Contributed by Rakesh R. (wheat9: rev 122cad6aec5839d8d515c5008425ecb34f2fa56b) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/CachePoolInfo.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/BlockStoragePolicy.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java * hadoop-hdfs-project/hadoop-hdfs-client/pom.xml * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java > Use slf4j instead of common-logging in hdfs-client > -- > > Key: HDFS-6564 > URL: https://issues.apache.org/jira/browse/HDFS-6564 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Haohui Mai >Assignee: Rakesh R > Fix For: 2.8.0 > > Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch, > HDFS-6564-03.patch > > > hdfs-client should depends on slf4j instead of common-logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Auto-Re: [jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
您的邮件已收到！谢谢！
Auto-Re: [jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
您的邮件已收到！谢谢！
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[ https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599496#comment-14599496 ] Hudson commented on HDFS-6564: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #2166 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2166/]) HDFS-6564. Use slf4j instead of common-logging in hdfs-client. Contributed by Rakesh R. (wheat9: rev 122cad6aec5839d8d515c5008425ecb34f2fa56b) * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/CachePoolInfo.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/BlockStoragePolicy.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java * hadoop-hdfs-project/hadoop-hdfs-client/pom.xml > Use slf4j instead of common-logging in hdfs-client > -- > > Key: HDFS-6564 > URL: https://issues.apache.org/jira/browse/HDFS-6564 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Haohui Mai >Assignee: Rakesh R > Fix For: 2.8.0 > > Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch, > HDFS-6564-03.patch > > > hdfs-client should depends on slf4j instead of common-logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Auto-Re: [jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
您的邮件已收到！谢谢！
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[ https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599482#comment-14599482 ] Hudson commented on HDFS-6564: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #227 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/227/]) HDFS-6564. Use slf4j instead of common-logging in hdfs-client. Contributed by Rakesh R. (wheat9: rev 122cad6aec5839d8d515c5008425ecb34f2fa56b) * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/BlockStoragePolicy.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/CachePoolInfo.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java * hadoop-hdfs-project/hadoop-hdfs-client/pom.xml > Use slf4j instead of common-logging in hdfs-client > -- > > Key: HDFS-6564 > URL: https://issues.apache.org/jira/browse/HDFS-6564 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Haohui Mai >Assignee: Rakesh R > Fix For: 2.8.0 > > Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch, > HDFS-6564-03.patch > > > hdfs-client should depends on slf4j instead of common-logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Auto-Re: [jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
您的邮件已收到！谢谢！
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[ https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599296#comment-14599296 ] Hudson commented on HDFS-6564: -- SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #238 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/238/]) HDFS-6564. Use slf4j instead of common-logging in hdfs-client. Contributed by Rakesh R. (wheat9: rev 122cad6aec5839d8d515c5008425ecb34f2fa56b) * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/BlockStoragePolicy.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java * hadoop-hdfs-project/hadoop-hdfs-client/pom.xml * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/CachePoolInfo.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java > Use slf4j instead of common-logging in hdfs-client > -- > > Key: HDFS-6564 > URL: https://issues.apache.org/jira/browse/HDFS-6564 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Haohui Mai >Assignee: Rakesh R > Fix For: 2.8.0 > > Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch, > HDFS-6564-03.patch > > > hdfs-client should depends on slf4j instead of common-logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Auto-Re: [jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
您的邮件已收到！谢谢！
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[ https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599290#comment-14599290 ] Hudson commented on HDFS-6564: -- FAILURE: Integrated in Hadoop-Yarn-trunk #968 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/968/]) HDFS-6564. Use slf4j instead of common-logging in hdfs-client. Contributed by Rakesh R. (wheat9: rev 122cad6aec5839d8d515c5008425ecb34f2fa56b) * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java * hadoop-hdfs-project/hadoop-hdfs-client/pom.xml * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/BlockStoragePolicy.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/CachePoolInfo.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java > Use slf4j instead of common-logging in hdfs-client > -- > > Key: HDFS-6564 > URL: https://issues.apache.org/jira/browse/HDFS-6564 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Haohui Mai >Assignee: Rakesh R > Fix For: 2.8.0 > > Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch, > HDFS-6564-03.patch > > > hdfs-client should depends on slf4j instead of common-logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Auto-Re: [jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
您的邮件已收到！谢谢！
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[ https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598770#comment-14598770 ] Rakesh R commented on HDFS-6564: Thanks [~wheat9] for the review and commit. Thanks [~busbey] for the review. > Use slf4j instead of common-logging in hdfs-client > -- > > Key: HDFS-6564 > URL: https://issues.apache.org/jira/browse/HDFS-6564 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Haohui Mai >Assignee: Rakesh R > Fix For: 2.8.0 > > Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch, > HDFS-6564-03.patch > > > hdfs-client should depends on slf4j instead of common-logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Auto-Re: [jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
您的邮件已收到！谢谢！
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[ https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598146#comment-14598146 ] Haohui Mai commented on HDFS-6564: -- +1. I'll commit it shortly. > Use slf4j instead of common-logging in hdfs-client > -- > > Key: HDFS-6564 > URL: https://issues.apache.org/jira/browse/HDFS-6564 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Haohui Mai >Assignee: Rakesh R > Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch, > HDFS-6564-03.patch > > > hdfs-client should depends on slf4j instead of common-logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[
https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597023#comment-14597023
]
Rakesh R commented on HDFS-6564:
Thanks for the reviews. I've updated {{Release note}} section in the jira.
Anything else required for this change.
> Use slf4j instead of common-logging in hdfs-client
> --
>
> Key: HDFS-6564
> URL: https://issues.apache.org/jira/browse/HDFS-6564
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Rakesh R
> Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch,
> HDFS-6564-03.patch
>
>
> hdfs-client should depends on slf4j instead of common-logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[
https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594270#comment-14594270
]
Hadoop QA commented on HDFS-6564:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 16s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 28s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 34s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 21s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 51s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 13s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 0m 16s | Tests passed in
hadoop-hdfs-client. |
| | | 39m 30s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12740553/HDFS-6564-03.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 49f5d20 |
| hadoop-hdfs-client test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11416/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11416/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11416/console |
This message was automatically generated.
> Use slf4j instead of common-logging in hdfs-client
> --
>
> Key: HDFS-6564
> URL: https://issues.apache.org/jira/browse/HDFS-6564
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Rakesh R
> Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch,
> HDFS-6564-03.patch
>
>
> hdfs-client should depends on slf4j instead of common-logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[
https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593017#comment-14593017
]
Rakesh R commented on HDFS-6564:
We have an example mentioned in the previous note, is that fine?
{code}
org.slf4j.Logger LOG =
org.slf4j.LoggerFactory.getLogger(org.apache.hadoop.hdfs.protocol.CachePoolInfo.class);
{code}
I think I can include link of slf4j manual in the note like, {{For more
details: http://www.slf4j.org/manual.html}}. Does this sound good to you ?
{code}
Users may need special attention for this change while upgrading to this
version. Previously hdfs client was using commons-logging as the logging
framework. With this change it uses slf4j framework. For more details:
http://www.slf4j.org/manual.html. Also,
org.apache.hadoop.hdfs.protocol.CachePoolInfo#LOG public static member variable
has been removed as it is not used anywhere. Users need to correct their code
if any one has a reference to this variable. One can retrieve the named logger
via the logging framework of their choice directly like, org.slf4j.Logger LOG =
org.slf4j.LoggerFactory.getLogger((org.apache.hadoop.hdfs.protocol.CachePoolInfo.class);
{code}
> Use slf4j instead of common-logging in hdfs-client
> --
>
> Key: HDFS-6564
> URL: https://issues.apache.org/jira/browse/HDFS-6564
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Rakesh R
> Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch,
> HDFS-6564-03.patch
>
>
> hdfs-client should depends on slf4j instead of common-logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[
https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593015#comment-14593015
]
Rakesh R commented on HDFS-6564:
We have an example mentioned in the previous note.
{code}
org.slf4j.Logger LOG =
org.slf4j.LoggerFactory.getLogger(org.apache.hadoop.hdfs.protocol.CachePoolInfo.class);
{code}
I think I can include link of slf4j manual in the note like below. Does this
sound good to you ?
{code}
Users may need special attention for this change while upgrading to this
version. Previously hdfs client was using commons-logging as the logging
framework. With this change it uses slf4j framework. For more details:
http://www.slf4j.org/manual.html. Also,
org.apache.hadoop.hdfs.protocol.CachePoolInfo#LOG public static member variable
has been removed as it is not used anywhere. Users need to correct their code
if any one has a reference to this variable. One can retrieve the named logger
via the logging framework of their choice directly like,
org.apache.commons.logging.Log LOG =
org.apache.commons.logging.LogFactory.getLogger(org.apache.hadoop.hdfs.protocol.CachePoolInfo.class);
{code}
> Use slf4j instead of common-logging in hdfs-client
> --
>
> Key: HDFS-6564
> URL: https://issues.apache.org/jira/browse/HDFS-6564
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Rakesh R
> Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch,
> HDFS-6564-03.patch
>
>
> hdfs-client should depends on slf4j instead of common-logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[ https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592976#comment-14592976 ] Sean Busbey commented on HDFS-6564: --- Since before removal the LOG was commons.logging, I would like to include how to get the member from that framework. Including how to do it in slf4j as well sounds fine. > Use slf4j instead of common-logging in hdfs-client > -- > > Key: HDFS-6564 > URL: https://issues.apache.org/jira/browse/HDFS-6564 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Haohui Mai >Assignee: Rakesh R > Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch, > HDFS-6564-03.patch > > > hdfs-client should depends on slf4j instead of common-logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[
https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592958#comment-14592958
]
Rakesh R commented on HDFS-6564:
Please ignore the previous, small correction to the logger class.
{code}
Users may need attention for this change while upgrading to this version.
org.apache.hadoop.hdfs.protocol.CachePoolInfo#LOG public static member variable
has been removed as it is not used anywhere. Users need to correct their code
if any one has a reference to this variable. One can retrieve the named logger
via the logging framework of their choice directly like, org.slf4j.Logger LOG =
org.slf4j.LoggerFactory.getLogger(org.apache.hadoop.hdfs.protocol.CachePoolInfo.class);
{code}
> Use slf4j instead of common-logging in hdfs-client
> --
>
> Key: HDFS-6564
> URL: https://issues.apache.org/jira/browse/HDFS-6564
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Rakesh R
> Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch,
> HDFS-6564-03.patch
>
>
> hdfs-client should depends on slf4j instead of common-logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[
https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592955#comment-14592955
]
Rakesh R commented on HDFS-6564:
I've modified the note, kindly review it again.
{code}
Users may need attention for this change while upgrading to this version.
org.apache.hadoop.hdfs.protocol.CachePoolInfo#LOG public static member variable
has been removed as it is not used anywhere. Users need to correct their code
if any one has a reference to this variable. One can retrieve the named logger
via the logging framework of their choice directly like,
org.apache.commons.logging.Log LOG =
org.apache.commons.logging.LogFactory.getLogger(org.apache.hadoop.hdfs.protocol.CachePoolInfo.class);
{code}
> Use slf4j instead of common-logging in hdfs-client
> --
>
> Key: HDFS-6564
> URL: https://issues.apache.org/jira/browse/HDFS-6564
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Rakesh R
> Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch,
> HDFS-6564-03.patch
>
>
> hdfs-client should depends on slf4j instead of common-logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[
https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592927#comment-14592927
]
Sean Busbey commented on HDFS-6564:
---
You should include mention of how to get the same functionality. In this case,
they can retrieve the named logger via the logging framework of their choice
directly. Since the previous member was commons-logging object, that would be
done via {{LogFactory.getLog(CachePoolInfo.class)}} or
{{LogFactory.getLog("org.apache.hadoop.hdfs.protocol.CachePoolInfo")}}.
> Use slf4j instead of common-logging in hdfs-client
> --
>
> Key: HDFS-6564
> URL: https://issues.apache.org/jira/browse/HDFS-6564
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Rakesh R
> Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch,
> HDFS-6564-03.patch
>
>
> hdfs-client should depends on slf4j instead of common-logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[
https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592878#comment-14592878
]
Rakesh R commented on HDFS-6564:
Thanks [~busbey]. Below is the draft release note, any comments. If everyone
agree with this then will update the jira.
{code}
Users may need attention for this change while upgrading to this version.
org.apache.hadoop.hdfs.protocol.CachePoolInfo#LOG static member variable has
been removed as it is not used anywhere. Users need to correct their code if
any one has a reference to this variable.
{code}
> Use slf4j instead of common-logging in hdfs-client
> --
>
> Key: HDFS-6564
> URL: https://issues.apache.org/jira/browse/HDFS-6564
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Rakesh R
> Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch,
> HDFS-6564-03.patch
>
>
> hdfs-client should depends on slf4j instead of common-logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[
https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592880#comment-14592880
]
Rakesh R commented on HDFS-6564:
Thanks [~wheat9] for the advice. Attached another patch by removing the {{LOG}}
variable.
> Use slf4j instead of common-logging in hdfs-client
> --
>
> Key: HDFS-6564
> URL: https://issues.apache.org/jira/browse/HDFS-6564
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Rakesh R
> Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch,
> HDFS-6564-03.patch
>
>
> hdfs-client should depends on slf4j instead of common-logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[ https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592831#comment-14592831 ] Sean Busbey commented on HDFS-6564: --- Whatever you decide to do about the LOG member, if it involves the class changing or it being removed please remember to flag the change and make a release note. That way downstream folks find out about it up front rather than by surprise when they are broken. > Use slf4j instead of common-logging in hdfs-client > -- > > Key: HDFS-6564 > URL: https://issues.apache.org/jira/browse/HDFS-6564 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Haohui Mai >Assignee: Rakesh R > Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch > > > hdfs-client should depends on slf4j instead of common-logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[
https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592828#comment-14592828
]
Haohui Mai commented on HDFS-6564:
--
I think it is okay to get rid of the {{LOG}} member since it is a evolving
interface. According to
http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/InterfaceClassification.html:
{quote}
Evolving
Evolving, but incompatible changes are allowed at minor release (i.e. m .x)
{quote}
> Use slf4j instead of common-logging in hdfs-client
> --
>
> Key: HDFS-6564
> URL: https://issues.apache.org/jira/browse/HDFS-6564
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Rakesh R
> Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch
>
>
> hdfs-client should depends on slf4j instead of common-logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[
https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591126#comment-14591126
]
Rakesh R commented on HDFS-6564:
Thanks [~wheat9] for pointing out this, yes its never used. But I could see
{{CachePoolInfo}} is marked as public interface, do we need to retain the
{{LOG}} considering this?
{code}
@InterfaceAudience.Public
@InterfaceStability.Evolving
public class CachePoolInfo {
{code}
> Use slf4j instead of common-logging in hdfs-client
> --
>
> Key: HDFS-6564
> URL: https://issues.apache.org/jira/browse/HDFS-6564
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Rakesh R
> Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch
>
>
> hdfs-client should depends on slf4j instead of common-logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[
https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590920#comment-14590920
]
Hadoop QA commented on HDFS-6564:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 36s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 32s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 42s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 21s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 52s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 16s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 0m 16s | Tests passed in
hadoop-hdfs-client. |
| | | 40m 14s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12740186/HDFS-6564-02.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 015535d |
| hadoop-hdfs-client test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11394/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11394/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11394/console |
This message was automatically generated.
> Use slf4j instead of common-logging in hdfs-client
> --
>
> Key: HDFS-6564
> URL: https://issues.apache.org/jira/browse/HDFS-6564
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Rakesh R
> Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch
>
>
> hdfs-client should depends on slf4j instead of common-logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[
https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590855#comment-14590855
]
Haohui Mai commented on HDFS-6564:
--
{code}
- public static final Log LOG = LogFactory.getLog(CachePoolInfo.class);
+ public static final Logger LOG = LoggerFactory
+ .getLogger(CachePoolInfo.class);
{code}
The LOG variable is never used. And in terms of compatibility this should be
fine from a practical point of view. There are no changes on the members that
actually hold the data.
> Use slf4j instead of common-logging in hdfs-client
> --
>
> Key: HDFS-6564
> URL: https://issues.apache.org/jira/browse/HDFS-6564
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Rakesh R
> Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch
>
>
> hdfs-client should depends on slf4j instead of common-logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[ https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590511#comment-14590511 ] Sean Busbey commented on HDFS-6564: --- the patch look good. have a draft of the needed release note? > Use slf4j instead of common-logging in hdfs-client > -- > > Key: HDFS-6564 > URL: https://issues.apache.org/jira/browse/HDFS-6564 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Haohui Mai >Assignee: Rakesh R > Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch > > > hdfs-client should depends on slf4j instead of common-logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[ https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590362#comment-14590362 ] Rakesh R commented on HDFS-6564: Attached patch addressing [~busbey] comments. > Use slf4j instead of common-logging in hdfs-client > -- > > Key: HDFS-6564 > URL: https://issues.apache.org/jira/browse/HDFS-6564 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Haohui Mai >Assignee: Rakesh R > Attachments: HDFS-6564-01.patch, HDFS-6564-02.patch > > > hdfs-client should depends on slf4j instead of common-logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[
https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590134#comment-14590134
]
Hadoop QA commented on HDFS-6564:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 21s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 32s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 21s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 0m 21s | The applied patch generated 1
new checkstyle issues (total was 156, now 155). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 51s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 14s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 0m 16s | Tests passed in
hadoop-hdfs-client. |
| | | 39m 42s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12740092/HDFS-6564-01.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 6e3fcff |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/11391/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt
|
| hadoop-hdfs-client test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11391/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11391/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11391/console |
This message was automatically generated.
> Use slf4j instead of common-logging in hdfs-client
> --
>
> Key: HDFS-6564
> URL: https://issues.apache.org/jira/browse/HDFS-6564
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Rakesh R
> Attachments: HDFS-6564-01.patch
>
>
> hdfs-client should depends on slf4j instead of common-logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[ https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590131#comment-14590131 ] Rakesh R commented on HDFS-6564: Thanks [~busbey] for the reviews. bq. nit: it's possible, though unlikely, that this e.toString call is still expensive and worth guarding with isDebugEnabled. Yes, you are right. I will take care this. > Use slf4j instead of common-logging in hdfs-client > -- > > Key: HDFS-6564 > URL: https://issues.apache.org/jira/browse/HDFS-6564 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Haohui Mai >Assignee: Rakesh R > Attachments: HDFS-6564-01.patch > > > hdfs-client should depends on slf4j instead of common-logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[
https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589939#comment-14589939
]
Sean Busbey commented on HDFS-6564:
---
{code}
diff --git
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/CachePoolInfo.java
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/CachePoolInfo.java
index 61bbe38..31850dc 100644
---
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/CachePoolInfo.java
+++
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/CachePoolInfo.java
@@ -24,13 +24,13 @@
import org.apache.commons.lang.builder.EqualsBuilder;
import org.apache.commons.lang.builder.HashCodeBuilder;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.classification.InterfaceAudience;
import org.apache.hadoop.classification.InterfaceStability;
import org.apache.hadoop.fs.InvalidRequestException;
import org.apache.hadoop.fs.permission.FsPermission;
import org.apache.hadoop.hdfs.protocol.CacheDirectiveInfo.Expiration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* CachePoolInfo describes a cache pool.
@@ -41,7 +41,8 @@
@InterfaceAudience.Public
@InterfaceStability.Evolving
public class CachePoolInfo {
- public static final Log LOG = LogFactory.getLog(CachePoolInfo.class);
+ public static final Logger LOG = LoggerFactory
+ .getLogger(CachePoolInfo.class);
{code}
This is a binary and source incompatible change to public API. Please be sure
to flag the jira as such and provide release notes.
{code}
@@ -733,9 +723,7 @@ final T getResponse(HttpURLConnection conn) throws
IOException {
} catch (Exception e) { // catch json parser errors
final IOException ioe =
new IOException("Response decoding failure: "+e.toString(), e);
-if (LOG.isDebugEnabled()) {
- LOG.debug(ioe);
-}
+LOG.debug("Response decoding failure: {}", e.toString(), e);
throw ioe;
{code}
nit: it's possible, though unlikely, that this e.toString call is still
expensive and worth guarding with isDebugEnabled.
> Use slf4j instead of common-logging in hdfs-client
> --
>
> Key: HDFS-6564
> URL: https://issues.apache.org/jira/browse/HDFS-6564
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Rakesh R
> Attachments: HDFS-6564-01.patch
>
>
> hdfs-client should depends on slf4j instead of common-logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6564) Use slf4j instead of common-logging in hdfs-client
[ https://issues.apache.org/jira/browse/HDFS-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589650#comment-14589650 ] Rakesh R commented on HDFS-6564: Hi [~wheat9], its interesting work. I have attached a patch to address the case. Please take a look when you get a chance. Thanks! > Use slf4j instead of common-logging in hdfs-client > -- > > Key: HDFS-6564 > URL: https://issues.apache.org/jira/browse/HDFS-6564 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Haohui Mai > Attachments: HDFS-6564-01.patch > > > hdfs-client should depends on slf4j instead of common-logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
