[jira] [Commented] (HDFS-6643) Refactor INodeFile.HeaderFormat and INodeWithAdditionalFields.PermissionStatusFormat
[ https://issues.apache.org/jira/browse/HDFS-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057208#comment-14057208 ] Hudson commented on HDFS-6643: -- FAILURE: Integrated in Hadoop-trunk-Commit #5855 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5855/]) HDFS-6643. Refactor INodeWithAdditionalFields.PermissionStatusFormat and INodeFile.HeaderFormat. (szetszwo: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1609401) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeAttributes.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFileAttributes.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeWithAdditionalFields.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/LongBitFormat.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java Refactor INodeFile.HeaderFormat and INodeWithAdditionalFields.PermissionStatusFormat Key: HDFS-6643 URL: https://issues.apache.org/jira/browse/HDFS-6643 Project: Hadoop HDFS Issue Type: Improvement Components: namenode Reporter: Tsz Wo Nicholas Sze Assignee: Tsz Wo Nicholas Sze Priority: Minor Fix For: 2.6.0 Attachments: h6643_20140708.patch, h6643_20140708b.patch, h6643_20140709.patch The use of them are very similar. We should change INodeFile.HeaderFormat to enum and refactor them for code reuse. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6643) Refactor INodeFile.HeaderFormat and INodeWithAdditionalFields.PermissionStatusFormat
[ https://issues.apache.org/jira/browse/HDFS-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057356#comment-14057356 ] Hudson commented on HDFS-6643: -- FAILURE: Integrated in Hadoop-Yarn-trunk #609 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/609/]) HDFS-6643. Refactor INodeWithAdditionalFields.PermissionStatusFormat and INodeFile.HeaderFormat. (szetszwo: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1609401) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeAttributes.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFileAttributes.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeWithAdditionalFields.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/LongBitFormat.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java Refactor INodeFile.HeaderFormat and INodeWithAdditionalFields.PermissionStatusFormat Key: HDFS-6643 URL: https://issues.apache.org/jira/browse/HDFS-6643 Project: Hadoop HDFS Issue Type: Improvement Components: namenode Reporter: Tsz Wo Nicholas Sze Assignee: Tsz Wo Nicholas Sze Priority: Minor Fix For: 2.6.0 Attachments: h6643_20140708.patch, h6643_20140708b.patch, h6643_20140709.patch The use of them are very similar. We should change INodeFile.HeaderFormat to enum and refactor them for code reuse. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6643) Refactor INodeFile.HeaderFormat and INodeWithAdditionalFields.PermissionStatusFormat
[ https://issues.apache.org/jira/browse/HDFS-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057474#comment-14057474 ] Hudson commented on HDFS-6643: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1800 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1800/]) HDFS-6643. Refactor INodeWithAdditionalFields.PermissionStatusFormat and INodeFile.HeaderFormat. (szetszwo: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1609401) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeAttributes.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFileAttributes.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeWithAdditionalFields.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/LongBitFormat.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java Refactor INodeFile.HeaderFormat and INodeWithAdditionalFields.PermissionStatusFormat Key: HDFS-6643 URL: https://issues.apache.org/jira/browse/HDFS-6643 Project: Hadoop HDFS Issue Type: Improvement Components: namenode Reporter: Tsz Wo Nicholas Sze Assignee: Tsz Wo Nicholas Sze Priority: Minor Fix For: 2.6.0 Attachments: h6643_20140708.patch, h6643_20140708b.patch, h6643_20140709.patch The use of them are very similar. We should change INodeFile.HeaderFormat to enum and refactor them for code reuse. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6643) Refactor INodeFile.HeaderFormat and INodeWithAdditionalFields.PermissionStatusFormat
[ https://issues.apache.org/jira/browse/HDFS-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057531#comment-14057531 ] Hudson commented on HDFS-6643: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1827 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1827/]) HDFS-6643. Refactor INodeWithAdditionalFields.PermissionStatusFormat and INodeFile.HeaderFormat. (szetszwo: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1609401) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeAttributes.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFileAttributes.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeWithAdditionalFields.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/LongBitFormat.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java Refactor INodeFile.HeaderFormat and INodeWithAdditionalFields.PermissionStatusFormat Key: HDFS-6643 URL: https://issues.apache.org/jira/browse/HDFS-6643 Project: Hadoop HDFS Issue Type: Improvement Components: namenode Reporter: Tsz Wo Nicholas Sze Assignee: Tsz Wo Nicholas Sze Priority: Minor Fix For: 2.6.0 Attachments: h6643_20140708.patch, h6643_20140708b.patch, h6643_20140709.patch The use of them are very similar. We should change INodeFile.HeaderFormat to enum and refactor them for code reuse. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6643) Refactor INodeFile.HeaderFormat and INodeWithAdditionalFields.PermissionStatusFormat
[
https://issues.apache.org/jira/browse/HDFS-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14056821#comment-14056821
]
Hadoop QA commented on HDFS-6643:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12654706/h6643_20140708b.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7310//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7310//console
This message is automatically generated.
Refactor INodeFile.HeaderFormat and
INodeWithAdditionalFields.PermissionStatusFormat
Key: HDFS-6643
URL: https://issues.apache.org/jira/browse/HDFS-6643
Project: Hadoop HDFS
Issue Type: Improvement
Components: namenode
Reporter: Tsz Wo Nicholas Sze
Assignee: Tsz Wo Nicholas Sze
Priority: Minor
Attachments: h6643_20140708.patch, h6643_20140708b.patch
The use of them are very similar. We should change INodeFile.HeaderFormat to
enum and refactor them for code reuse.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6643) Refactor INodeFile.HeaderFormat and INodeWithAdditionalFields.PermissionStatusFormat
[ https://issues.apache.org/jira/browse/HDFS-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14056991#comment-14056991 ] Jing Zhao commented on HDFS-6643: - The patch looks pretty good to me. But it looks like the fields of LongBitFormat do not need to be public (they are only used inside of LongBitFormat)? Refactor INodeFile.HeaderFormat and INodeWithAdditionalFields.PermissionStatusFormat Key: HDFS-6643 URL: https://issues.apache.org/jira/browse/HDFS-6643 Project: Hadoop HDFS Issue Type: Improvement Components: namenode Reporter: Tsz Wo Nicholas Sze Assignee: Tsz Wo Nicholas Sze Priority: Minor Attachments: h6643_20140708.patch, h6643_20140708b.patch The use of them are very similar. We should change INodeFile.HeaderFormat to enum and refactor them for code reuse. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6643) Refactor INodeFile.HeaderFormat and INodeWithAdditionalFields.PermissionStatusFormat
[
https://issues.apache.org/jira/browse/HDFS-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057120#comment-14057120
]
Hadoop QA commented on HDFS-6643:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12654916/h6643_20140709.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7315//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7315//console
This message is automatically generated.
Refactor INodeFile.HeaderFormat and
INodeWithAdditionalFields.PermissionStatusFormat
Key: HDFS-6643
URL: https://issues.apache.org/jira/browse/HDFS-6643
Project: Hadoop HDFS
Issue Type: Improvement
Components: namenode
Reporter: Tsz Wo Nicholas Sze
Assignee: Tsz Wo Nicholas Sze
Priority: Minor
Attachments: h6643_20140708.patch, h6643_20140708b.patch,
h6643_20140709.patch
The use of them are very similar. We should change INodeFile.HeaderFormat to
enum and refactor them for code reuse.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6643) Refactor INodeFile.HeaderFormat and INodeWithAdditionalFields.PermissionStatusFormat
[ https://issues.apache.org/jira/browse/HDFS-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057128#comment-14057128 ] Jing Zhao commented on HDFS-6643: - +1 for the latest patch. Refactor INodeFile.HeaderFormat and INodeWithAdditionalFields.PermissionStatusFormat Key: HDFS-6643 URL: https://issues.apache.org/jira/browse/HDFS-6643 Project: Hadoop HDFS Issue Type: Improvement Components: namenode Reporter: Tsz Wo Nicholas Sze Assignee: Tsz Wo Nicholas Sze Priority: Minor Attachments: h6643_20140708.patch, h6643_20140708b.patch, h6643_20140709.patch The use of them are very similar. We should change INodeFile.HeaderFormat to enum and refactor them for code reuse. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6643) Refactor INodeFile.HeaderFormat and INodeWithAdditionalFields.PermissionStatusFormat
[
https://issues.apache.org/jira/browse/HDFS-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14055526#comment-14055526
]
Hadoop QA commented on HDFS-6643:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12654626/h6643_20140708.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.TestINodeFile
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7291//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/7291//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7291//console
This message is automatically generated.
Refactor INodeFile.HeaderFormat and
INodeWithAdditionalFields.PermissionStatusFormat
Key: HDFS-6643
URL: https://issues.apache.org/jira/browse/HDFS-6643
Project: Hadoop HDFS
Issue Type: Improvement
Components: namenode
Reporter: Tsz Wo Nicholas Sze
Assignee: Tsz Wo Nicholas Sze
Priority: Minor
Attachments: h6643_20140708.patch
The use of them are very similar. We should change INodeFile.HeaderFormat to
enum and refactor them for code reuse.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
