[jira] [Commented] (HDFS-6960) Bugfix in LazyWriter, fix test case and some refactoring
[
https://issues.apache.org/jira/browse/HDFS-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156530#comment-14156530
]
Hudson commented on HDFS-6960:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1914 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1914/])
HDFS-6960. Bugfix in LazyWriter, fix test case and some refactoring. (Arpit
Agarwal) (arp: rev 4cf9afacbe3d0814fb616d238aa9b16b1ae68386)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-6581.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImpl.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyWriteReplicaTracker.java
> Bugfix in LazyWriter, fix test case and some refactoring
>
>
> Key: HDFS-6960
> URL: https://issues.apache.org/jira/browse/HDFS-6960
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, test
>Affects Versions: HDFS-6581
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Fix For: 3.0.0
>
> Attachments: HDFS-6960.01.patch, HDFS-6960.02.patch
>
>
> LazyWriter has a bug. While saving the replica to disk we would save it under
> {{current/lazyPersist/}}. Instead it should be saved under the appropriate
> subdirectory e.g. {{current/lazyPersist/subdir1/subdir0/}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6960) Bugfix in LazyWriter, fix test case and some refactoring
[
https://issues.apache.org/jira/browse/HDFS-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156414#comment-14156414
]
Hudson commented on HDFS-6960:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #1889 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1889/])
HDFS-6960. Bugfix in LazyWriter, fix test case and some refactoring. (Arpit
Agarwal) (arp: rev 4cf9afacbe3d0814fb616d238aa9b16b1ae68386)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-6581.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyWriteReplicaTracker.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImpl.java
> Bugfix in LazyWriter, fix test case and some refactoring
>
>
> Key: HDFS-6960
> URL: https://issues.apache.org/jira/browse/HDFS-6960
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, test
>Affects Versions: HDFS-6581
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Fix For: 3.0.0
>
> Attachments: HDFS-6960.01.patch, HDFS-6960.02.patch
>
>
> LazyWriter has a bug. While saving the replica to disk we would save it under
> {{current/lazyPersist/}}. Instead it should be saved under the appropriate
> subdirectory e.g. {{current/lazyPersist/subdir1/subdir0/}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6960) Bugfix in LazyWriter, fix test case and some refactoring
[
https://issues.apache.org/jira/browse/HDFS-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156336#comment-14156336
]
Hudson commented on HDFS-6960:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #698 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/698/])
HDFS-6960. Bugfix in LazyWriter, fix test case and some refactoring. (Arpit
Agarwal) (arp: rev 4cf9afacbe3d0814fb616d238aa9b16b1ae68386)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-6581.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImpl.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyWriteReplicaTracker.java
> Bugfix in LazyWriter, fix test case and some refactoring
>
>
> Key: HDFS-6960
> URL: https://issues.apache.org/jira/browse/HDFS-6960
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, test
>Affects Versions: HDFS-6581
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Fix For: 3.0.0
>
> Attachments: HDFS-6960.01.patch, HDFS-6960.02.patch
>
>
> LazyWriter has a bug. While saving the replica to disk we would save it under
> {{current/lazyPersist/}}. Instead it should be saved under the appropriate
> subdirectory e.g. {{current/lazyPersist/subdir1/subdir0/}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6960) Bugfix in LazyWriter, fix test case and some refactoring
[
https://issues.apache.org/jira/browse/HDFS-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155039#comment-14155039
]
Hudson commented on HDFS-6960:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6163 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/6163/])
HDFS-6960. Bugfix in LazyWriter, fix test case and some refactoring. (Arpit
Agarwal) (arp: rev 4cf9afacbe3d0814fb616d238aa9b16b1ae68386)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImpl.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-6581.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyWriteReplicaTracker.java
> Bugfix in LazyWriter, fix test case and some refactoring
>
>
> Key: HDFS-6960
> URL: https://issues.apache.org/jira/browse/HDFS-6960
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, test
>Affects Versions: HDFS-6581
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Fix For: HDFS-6581
>
> Attachments: HDFS-6960.01.patch, HDFS-6960.02.patch
>
>
> LazyWriter has a bug. While saving the replica to disk we would save it under
> {{current/lazyPersist/}}. Instead it should be saved under the appropriate
> subdirectory e.g. {{current/lazyPersist/subdir1/subdir0/}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6960) Bugfix in LazyWriter, fix test case and some refactoring
[
https://issues.apache.org/jira/browse/HDFS-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114884#comment-14114884
]
Jitendra Nath Pandey commented on HDFS-6960:
+1
> Bugfix in LazyWriter, fix test case and some refactoring
>
>
> Key: HDFS-6960
> URL: https://issues.apache.org/jira/browse/HDFS-6960
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, test
>Affects Versions: HDFS-6581
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Attachments: HDFS-6960.01.patch, HDFS-6960.02.patch
>
>
> LazyWriter has a bug. While saving the replica to disk we would save it under
> {{current/lazyPersist/}}. Instead it should be saved under the appropriate
> subdirectory e.g. {{current/lazyPersist/subdir1/subdir0/}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6960) Bugfix in LazyWriter, fix test case and some refactoring
[
https://issues.apache.org/jira/browse/HDFS-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114481#comment-14114481
]
Xiaoyu Yao commented on HDFS-6960:
--
+1
> Bugfix in LazyWriter, fix test case and some refactoring
>
>
> Key: HDFS-6960
> URL: https://issues.apache.org/jira/browse/HDFS-6960
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, test
>Affects Versions: HDFS-6581
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Attachments: HDFS-6960.01.patch
>
>
> LazyWriter has a bug. While saving the replica to disk we would save it under
> {{current/lazyPersist/}}. Instead it should be saved under the appropriate
> subdirectory e.g. {{current/lazyPersist/subdir1/subdir0/}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6960) Bugfix in LazyWriter, fix test case and some refactoring
[
https://issues.apache.org/jira/browse/HDFS-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114476#comment-14114476
]
Xiaoyu Yao commented on HDFS-6960:
--
The change of return value from void to boolean for discardReplica() is not
being used in the code. Is this necessary?
> Bugfix in LazyWriter, fix test case and some refactoring
>
>
> Key: HDFS-6960
> URL: https://issues.apache.org/jira/browse/HDFS-6960
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, test
>Affects Versions: HDFS-6581
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Attachments: HDFS-6960.01.patch
>
>
> LazyWriter has a bug. While saving the replica to disk we would save it under
> {{current/lazyPersist/}}. Instead it should be saved under the appropriate
> subdirectory e.g. {{current/lazyPersist/subdir1/subdir0/}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6960) Bugfix in LazyWriter, fix test case and some refactoring
[
https://issues.apache.org/jira/browse/HDFS-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114451#comment-14114451
]
Xiaoyu Yao commented on HDFS-6960:
--
In FsDataSetImpl.java Can you put the following into debug log?
{code}
saveNextReplica()
{...
LOG.info("LazyWriter has no blocks to persist. " +
"Thread going to sleep.");
{code}
> Bugfix in LazyWriter, fix test case and some refactoring
>
>
> Key: HDFS-6960
> URL: https://issues.apache.org/jira/browse/HDFS-6960
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, test
>Affects Versions: HDFS-6581
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Attachments: HDFS-6960.01.patch
>
>
> LazyWriter has a bug. While saving the replica to disk we would save it under
> {{current/lazyPersist/}}. Instead it should be saved under the appropriate
> subdirectory e.g. {{current/lazyPersist/subdir1/subdir0/}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6960) Bugfix in LazyWriter, fix test case and some refactoring
[
https://issues.apache.org/jira/browse/HDFS-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113326#comment-14113326
]
Arpit Agarwal commented on HDFS-6960:
-
Fixed the bug and test case.
Also refactored the LazyWriter to reduce tracked state and simplify the code.
> Bugfix in LazyWriter, fix test case and some refactoring
>
>
> Key: HDFS-6960
> URL: https://issues.apache.org/jira/browse/HDFS-6960
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, test
>Affects Versions: HDFS-6581
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Attachments: HDFS-6960.01.patch
>
>
> LazyWriter has a bug. While saving the replica to disk we would save it under
> {{current/lazyPersist}}. Instead it should be saved under the appropriate
> subdirectory e.g. {{current/lazyPersist/subdir1/subdir0}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
