[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-23 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708464#comment-14708464
 ] 

Allen Wittenauer commented on HDFS-7116:


Could we please stop adding camel case options to command lines?

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch, HDFS-7116-04.patch, HDFS-7116-05.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-23 Thread Tsz Wo Nicholas Sze (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708546#comment-14708546
 ] 

Tsz Wo Nicholas Sze commented on HDFS-7116:
---

Command options are case insensitive.

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch, HDFS-7116-04.patch, HDFS-7116-05.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-23 Thread Akira AJISAKA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708696#comment-14708696
 ] 

Akira AJISAKA commented on HDFS-7116:
-

bq. This seems wrong to show it in metric since it is a mostly constant value. 
Just like that we won't show other conf values in metric.
I understand. Thanks [~szetszwo] for the comment.

bq. Now, your approach is avoiding this problem. I'll start preparing a patch 
if others agree to this approach.
Agree.

bq. Command options are case insensitive.
{code:title=DFSAdmin.java}
try {
  if (-report.equals(cmd)) {
report(argv, i);
  } else if (-safemode.equals(cmd)) {
setSafeMode(argv, i);
  } else if (-allowSnapshot.equalsIgnoreCase(cmd)) {
allowSnapshot(argv);
...
{code}
dfsadmin command options are case sensitive except allowSnapshot and 
disallowSnapshot. I'm thinking we should make them case insensitive in a 
separate jira.

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch, HDFS-7116-04.patch, HDFS-7116-05.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-23 Thread Akira AJISAKA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708762#comment-14708762
 ] 

Akira AJISAKA commented on HDFS-7116:
-

Filed HDFS-8944 for make them case insensitive.

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch, HDFS-7116-04.patch, HDFS-7116-05.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-22 Thread Rakesh R (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707978#comment-14707978
 ] 

Rakesh R commented on HDFS-7116:


bq. How about adding a new dfsadmin command?
Thanks [~szetszwo] for the interest. We have initially discussed to support 
command or expose the value through datanode report. Could you please see the 
attached patch 'HDFS-7116-01.patch' , here I tried an attempt by exposing the 
value through datanode report. Later we've moved to the metric approach due to 
the heartbeat overhead. Please see the 
[discussion|https://issues.apache.org/jira/browse/HDFS-7116?focusedCommentId=14696698page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14696698]
 happened earlier in this jira.

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch, HDFS-7116-04.patch, HDFS-7116-05.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-22 Thread Tsz Wo Nicholas Sze (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707928#comment-14707928
 ] 

Tsz Wo Nicholas Sze commented on HDFS-7116:
---

 Expose metric named BalancerBandwidth in the Datanode metrics to get the 
 bandwidth of balancer.

By bandwidth of balancer, I guess you mean 
dfs.datanode.balance.bandwidthPerSec, which can be changed in runtime by the 
dfsadmin –setBalancerBandwidth command.  This seems wrong to show it in 
metric since it is a mostly constant value.  Just like that we won't show other 
conf values in metric.

How about adding a new dfsadmin command?

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch, HDFS-7116-04.patch, HDFS-7116-05.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-22 Thread Brahma Reddy Battula (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708284#comment-14708284
 ] 

Brahma Reddy Battula commented on HDFS-7116:


[~rakeshr] As I discussed with you offline, dfsadmin -getBalancerBandwidth 
DATANODE_HOST:IPC_PORT can be better way  as nicholas mentioned. 

* No additional overhead and 
* Now User can easily understand get and set method of balancerbandwidth...

[~szetszwo]I feel above one should be ok instead of extending the hdfs 
getconf which is currently getting from the configuration files..

and if everyone agree ,we need to change defect summary also..

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch, HDFS-7116-04.patch, HDFS-7116-05.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-22 Thread Rakesh R (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708091#comment-14708091
 ] 

Rakesh R commented on HDFS-7116:


bq. How about having dfsadmin -getBalancerBandwidth DATANODE_HOST:IPC_PORT, 
which is similar to dfsadmin -getDatanodeInfo?
Its interesting. Initially I've tried reading values via Namenode and this 
makes additional overhead to the datanode heartbeat. Now, your approach is 
avoiding this problem. I'll start preparing a patch if others agree to this 
approach.

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch, HDFS-7116-04.patch, HDFS-7116-05.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-22 Thread Tsz Wo Nicholas Sze (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708057#comment-14708057
 ] 

Tsz Wo Nicholas Sze commented on HDFS-7116:
---

How about having dfsadmin -getBalancerBandwidth DATANODE_HOST:IPC_PORT, 
which is similar to dfsadmin -getDatanodeInfo?

Or how about extending the hdfs getconf command to support getting conf from 
datanode?

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch, HDFS-7116-04.patch, HDFS-7116-05.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-21 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707525#comment-14707525
 ] 

Hadoop QA commented on HDFS-7116:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  23m 35s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 1 new or modified test files. |
| {color:green}+1{color} | javac |   7m 55s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 55s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | site |   2m 59s | Site still builds. |
| {color:red}-1{color} | checkstyle |   2m 29s | The applied patch generated  3 
new checkstyle issues (total was 222, now 224). |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 27s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   4m 30s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests |  22m 41s | Tests passed in 
hadoop-common. |
| {color:green}+1{color} | hdfs tests | 163m  6s | Tests passed in hadoop-hdfs. 
|
| | | 239m 36s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12751690/HDFS-7116-05.patch |
| Optional Tests | site javadoc javac unit findbugs checkstyle |
| git revision | trunk / 22de7c1 |
| checkstyle |  
https://builds.apache.org/job/PreCommit-HDFS-Build/12070/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
 |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HDFS-Build/12070/artifact/patchprocess/testrun_hadoop-common.txt
 |
| hadoop-hdfs test log | 
https://builds.apache.org/job/PreCommit-HDFS-Build/12070/artifact/patchprocess/testrun_hadoop-hdfs.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/12070/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/12070/console |


This message was automatically generated.

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch, HDFS-7116-04.patch, HDFS-7116-05.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-21 Thread Akira AJISAKA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706325#comment-14706325
 ] 

Akira AJISAKA commented on HDFS-7116:
-

Thanks [~rakeshr] for creating the patch.
{code}
  private AtomicLong balancerBandwidth = new AtomicLong(0);
{code}
There is a class {{MutableGaugeLong}}, which is similar to 
{{MutableCounterLong}} and can set arbitrary long value. Would you use the 
class instead of {{AtomicLong}}? The rest of the patch looks good to me.

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-21 Thread Vinayakumar B (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706326#comment-14706326
 ] 

Vinayakumar B commented on HDFS-7116:
-

Thanks [~rakeshr],
Patch looks great for adding the metric. This is the simple way to expose the 
bandwidth value.
+1 for the patch.

Can someone confirm whether adding a new metric is a compatible change? I am 
asking because, a new entry will show up in jmx json.
If incompatible, need to mark this jira as incompatible.



 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-21 Thread Akira AJISAKA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706408#comment-14706408
 ] 

Akira AJISAKA commented on HDFS-7116:
-

Thanks [~rakeshr] for updating the patch. I built a pseudo-distributed cluster 
with your patch and the metric worked well.
One comment: Would you update the description of dfsadmin 
-setBalancerBandwidth in HDFSCommands document?
{code}
NOTE: The new value is not persistent on the DataNode.
{code}
Now the new value is exposed via BalancerBandwidth metric.

I'm +1 if that is addressed.

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-21 Thread Rakesh R (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706461#comment-14706461
 ] 

Rakesh R commented on HDFS-7116:


OK, thank you for the explanation. Attached patch addressing the comments.

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch, HDFS-7116-04.patch, HDFS-7116-05.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-21 Thread Vinayakumar B (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706489#comment-14706489
 ] 

Vinayakumar B commented on HDFS-7116:
-

bq. 1. Would you remove the sentence starts with The new value is not 
persistent ... ? If we add the metric, the new value does persist on the 
DataNodeMetrics.
IMO, exposing via metric is not same as persisting. It just shows out the 
current value. Here not actually meant, new value is only till lifetime of the 
datanode. On restart it will be reset. so i feel still NOTE is valid. May be 
the sentence related to exposing can be added before the note. To make it clear.

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch, HDFS-7116-04.patch, HDFS-7116-05.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-21 Thread Akira AJISAKA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706452#comment-14706452
 ] 

Akira AJISAKA commented on HDFS-7116:
-

Thanks [~rakeshr] for updating the patch.
{code}
 -| `-setBalancerBandwidth` \bandwidth in bytes per second\ | Changes the 
 network bandwidth used by each datanode during HDFS block balancing. 
 \bandwidth\ is the maximum number of bytes per second that will be used by 
 each datanode. This value overrides the dfs.balance.bandwidthPerSec 
 parameter.C2A0NOTE: The new value is not persistent on the DataNode. |
 +| `-setBalancerBandwidth` \bandwidth in bytes per second\ | Changes the 
 network bandwidth used by each datanode during HDFS block balancing. 
 \bandwidth\ is the maximum number of bytes per second that will be used by 
 each datanode. This value overrides the dfs.balance.bandwidthPerSec 
 parameter.C2A0NOTE: The new value is not persistent on the DataNode. The 
 value is exposed via BalancerBandwidth metric. |
{code}

1. Would you remove the sentence starts with The new value is not persistent 
... ? If we add the metric, the new value does persist on the DataNodeMetrics.
2. (minor) Would you replace {{0xC2A0}} (whitespace in UTF-8) before NOTE: 
with whitespace as well?

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch, HDFS-7116-04.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-21 Thread Akira AJISAKA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706329#comment-14706329
 ] 

Akira AJISAKA commented on HDFS-7116:
-

bq. Can someone confirm whether adding a new metric is a compatible change?
Adding a new metric is compatible. 
http://hadoop.apache.org/docs/r2.7.1/hadoop-project-dist/hadoop-common/Compatibility.html#MetricsJMX

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-21 Thread Rakesh R (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706441#comment-14706441
 ] 

Rakesh R commented on HDFS-7116:


Attached another patch for the HDFSCommands doc changes. Thanks again!

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch, HDFS-7116-04.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-21 Thread Vinayakumar B (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706336#comment-14706336
 ] 

Vinayakumar B commented on HDFS-7116:
-

Thanks @Akira for confirming.

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-21 Thread Rakesh R (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706338#comment-14706338
 ] 

Rakesh R commented on HDFS-7116:


Thanks [~ajisakaa], [~vinayrpet] for the comments. Attached another patch 
addressing the comments.

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch, HDFS-7116-03.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7116) Add a metric to expose the bandwidth of balancer

2015-08-20 Thread Rakesh R (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706250#comment-14706250
 ] 

Rakesh R commented on HDFS-7116:


OK, I've updated the jira subject/desc/release_note accordingly. Please review 
the proposed patch when you get a chance, Thanks!

 Add a metric to expose the bandwidth of balancer
 

 Key: HDFS-7116
 URL: https://issues.apache.org/jira/browse/HDFS-7116
 Project: Hadoop HDFS
  Issue Type: New Feature
  Components: balancer  mover
Reporter: Akira AJISAKA
Assignee: Rakesh R
 Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch, 
 HDFS-7116-02.patch


 Now reading logs is the only way to check how the balancer bandwidth is set. 
 It would be useful for administrators if they can get the value of the same. 
 This jira to discuss  implement the way to access the balancer bandwidth 
 value of the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)