[jira] [Commented] (HDFS-7222) Expose DataNode network errors as a metric
[ https://issues.apache.org/jira/browse/HDFS-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182911#comment-14182911 ] Hudson commented on HDFS-7222: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1936 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1936/]) HDFS-7222. Expose DataNode network errors as a metric. (Charles Lamb via wang) (wang: rev 86cad007d7d6366b293bb9a073814889081c8662) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeMetrics.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetrics.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeFaultInjector.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java > Expose DataNode network errors as a metric > -- > > Key: HDFS-7222 > URL: https://issues.apache.org/jira/browse/HDFS-7222 > Project: Hadoop HDFS > Issue Type: New Feature > Components: datanode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb >Priority: Minor > Fix For: 2.7.0 > > Attachments: HDFS-7222.001.patch, HDFS-7222.002.patch, > HDFS-7222.003.patch > > > It would be useful to track datanode network errors and expose them as a > metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7222) Expose DataNode network errors as a metric
[ https://issues.apache.org/jira/browse/HDFS-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182823#comment-14182823 ] Hudson commented on HDFS-7222: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1911 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1911/]) HDFS-7222. Expose DataNode network errors as a metric. (Charles Lamb via wang) (wang: rev 86cad007d7d6366b293bb9a073814889081c8662) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeFaultInjector.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeMetrics.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetrics.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java > Expose DataNode network errors as a metric > -- > > Key: HDFS-7222 > URL: https://issues.apache.org/jira/browse/HDFS-7222 > Project: Hadoop HDFS > Issue Type: New Feature > Components: datanode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb >Priority: Minor > Fix For: 2.7.0 > > Attachments: HDFS-7222.001.patch, HDFS-7222.002.patch, > HDFS-7222.003.patch > > > It would be useful to track datanode network errors and expose them as a > metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7222) Expose DataNode network errors as a metric
[ https://issues.apache.org/jira/browse/HDFS-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182709#comment-14182709 ] Hudson commented on HDFS-7222: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #722 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/722/]) HDFS-7222. Expose DataNode network errors as a metric. (Charles Lamb via wang) (wang: rev 86cad007d7d6366b293bb9a073814889081c8662) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeMetrics.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeFaultInjector.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetrics.java > Expose DataNode network errors as a metric > -- > > Key: HDFS-7222 > URL: https://issues.apache.org/jira/browse/HDFS-7222 > Project: Hadoop HDFS > Issue Type: New Feature > Components: datanode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb >Priority: Minor > Fix For: 2.7.0 > > Attachments: HDFS-7222.001.patch, HDFS-7222.002.patch, > HDFS-7222.003.patch > > > It would be useful to track datanode network errors and expose them as a > metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7222) Expose DataNode network errors as a metric
[ https://issues.apache.org/jira/browse/HDFS-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181856#comment-14181856 ] Hudson commented on HDFS-7222: -- FAILURE: Integrated in Hadoop-trunk-Commit #6323 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6323/]) HDFS-7222. Expose DataNode network errors as a metric. (Charles Lamb via wang) (wang: rev 86cad007d7d6366b293bb9a073814889081c8662) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeMetrics.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeFaultInjector.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetrics.java > Expose DataNode network errors as a metric > -- > > Key: HDFS-7222 > URL: https://issues.apache.org/jira/browse/HDFS-7222 > Project: Hadoop HDFS > Issue Type: New Feature > Components: datanode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb >Priority: Minor > Fix For: 2.7.0 > > Attachments: HDFS-7222.001.patch, HDFS-7222.002.patch, > HDFS-7222.003.patch > > > It would be useful to track datanode network errors and expose them as a > metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7222) Expose DataNode network errors as a metric
[
https://issues.apache.org/jira/browse/HDFS-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179043#comment-14179043
]
Hadoop QA commented on HDFS-7222:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12676148/HDFS-7222.003.patch
against trunk revision 4e134a0.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The test build failed in
hadoop-hdfs-project/hadoop-hdfs
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8471//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8471//console
This message is automatically generated.
> Expose DataNode network errors as a metric
> --
>
> Key: HDFS-7222
> URL: https://issues.apache.org/jira/browse/HDFS-7222
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: datanode
>Affects Versions: 2.7.0
>Reporter: Charles Lamb
>Assignee: Charles Lamb
>Priority: Minor
> Attachments: HDFS-7222.001.patch, HDFS-7222.002.patch,
> HDFS-7222.003.patch
>
>
> It would be useful to track datanode network errors and expose them as a
> metric.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7222) Expose DataNode network errors as a metric
[
https://issues.apache.org/jira/browse/HDFS-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178718#comment-14178718
]
Andrew Wang commented on HDFS-7222:
---
Hi Charles, thanks for working on this, few comments:
* Need a more descriptive name for injectIOException, normally we name these
methods to be where it's used. In this case, {{writeBlockAfterFlush}} would be
appropriate.
* If this is intended to track just network errors, the metric should be named
{{datanodeNetworkErrors}} rather than IOErrors.
+1 pending though, otherwise looks good.
> Expose DataNode network errors as a metric
> --
>
> Key: HDFS-7222
> URL: https://issues.apache.org/jira/browse/HDFS-7222
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: datanode
>Affects Versions: 2.7.0
>Reporter: Charles Lamb
>Assignee: Charles Lamb
>Priority: Minor
> Attachments: HDFS-7222.001.patch, HDFS-7222.002.patch
>
>
> It would be useful to track datanode network errors and expose them as a
> metric.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7222) Expose DataNode network errors as a metric
[ https://issues.apache.org/jira/browse/HDFS-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171211#comment-14171211 ] Charles Lamb commented on HDFS-7222: The two test failures are unrelated. > Expose DataNode network errors as a metric > -- > > Key: HDFS-7222 > URL: https://issues.apache.org/jira/browse/HDFS-7222 > Project: Hadoop HDFS > Issue Type: New Feature > Components: datanode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb >Priority: Minor > Attachments: HDFS-7222.001.patch, HDFS-7222.002.patch > > > It would be useful to track datanode network errors and expose them as a > metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7222) Expose DataNode network errors as a metric
[
https://issues.apache.org/jira/browse/HDFS-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171205#comment-14171205
]
Hadoop QA commented on HDFS-7222:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12674769/HDFS-7222.002.patch
against trunk revision 5faaba0.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8419//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8419//console
This message is automatically generated.
> Expose DataNode network errors as a metric
> --
>
> Key: HDFS-7222
> URL: https://issues.apache.org/jira/browse/HDFS-7222
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: datanode
>Affects Versions: 2.7.0
>Reporter: Charles Lamb
>Assignee: Charles Lamb
>Priority: Minor
> Attachments: HDFS-7222.001.patch, HDFS-7222.002.patch
>
>
> It would be useful to track datanode network errors and expose them as a
> metric.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7222) Expose DataNode network errors as a metric
[
https://issues.apache.org/jira/browse/HDFS-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170093#comment-14170093
]
Hadoop QA commented on HDFS-7222:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12674545/HDFS-7222.001.patch
against trunk revision a56ea01.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing
org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
The following test timeouts occurred in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestRenameWhileOpen
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8406//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8406//console
This message is automatically generated.
> Expose DataNode network errors as a metric
> --
>
> Key: HDFS-7222
> URL: https://issues.apache.org/jira/browse/HDFS-7222
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: datanode
>Affects Versions: 2.7.0
>Reporter: Charles Lamb
>Assignee: Charles Lamb
>Priority: Minor
> Attachments: HDFS-7222.001.patch
>
>
> It would be useful to track datanode network errors and expose them as a
> metric.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
