[jira] [Commented] (HDFS-7513) HDFS inotify: add defaultBlockSize to CreateEvent
[ https://issues.apache.org/jira/browse/HDFS-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248110#comment-14248110 ] Hudson commented on HDFS-7513: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #43 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/43/]) HDFS-7513. HDFS inotify: add defaultBlockSize to CreateEvent (cmccabe) (cmccabe: rev 6e13fc62e1f284f22fd0089f06ce281198bc7c2a) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/InotifyFSEditLogOpTranslator.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java * hadoop-hdfs-project/hadoop-hdfs/src/main/proto/inotify.proto HDFS inotify: add defaultBlockSize to CreateEvent - Key: HDFS-7513 URL: https://issues.apache.org/jira/browse/HDFS-7513 Project: Hadoop HDFS Issue Type: Improvement Components: namenode Affects Versions: 2.6.0 Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: 2.7.0 Attachments: HDFS-7513.001.patch, HDFS-7513.002.patch, HDFS-7513.003.patch HDFS inotify: add defaultBlockSize to CreateEvent -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7513) HDFS inotify: add defaultBlockSize to CreateEvent
[ https://issues.apache.org/jira/browse/HDFS-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248122#comment-14248122 ] Hudson commented on HDFS-7513: -- FAILURE: Integrated in Hadoop-Yarn-trunk #777 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/777/]) HDFS-7513. HDFS inotify: add defaultBlockSize to CreateEvent (cmccabe) (cmccabe: rev 6e13fc62e1f284f22fd0089f06ce281198bc7c2a) * hadoop-hdfs-project/hadoop-hdfs/src/main/proto/inotify.proto * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/InotifyFSEditLogOpTranslator.java HDFS inotify: add defaultBlockSize to CreateEvent - Key: HDFS-7513 URL: https://issues.apache.org/jira/browse/HDFS-7513 Project: Hadoop HDFS Issue Type: Improvement Components: namenode Affects Versions: 2.6.0 Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: 2.7.0 Attachments: HDFS-7513.001.patch, HDFS-7513.002.patch, HDFS-7513.003.patch HDFS inotify: add defaultBlockSize to CreateEvent -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7513) HDFS inotify: add defaultBlockSize to CreateEvent
[ https://issues.apache.org/jira/browse/HDFS-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248257#comment-14248257 ] Hudson commented on HDFS-7513: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1994 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1994/]) HDFS-7513. HDFS inotify: add defaultBlockSize to CreateEvent (cmccabe) (cmccabe: rev 6e13fc62e1f284f22fd0089f06ce281198bc7c2a) * hadoop-hdfs-project/hadoop-hdfs/src/main/proto/inotify.proto * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/InotifyFSEditLogOpTranslator.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt HDFS inotify: add defaultBlockSize to CreateEvent - Key: HDFS-7513 URL: https://issues.apache.org/jira/browse/HDFS-7513 Project: Hadoop HDFS Issue Type: Improvement Components: namenode Affects Versions: 2.6.0 Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: 2.7.0 Attachments: HDFS-7513.001.patch, HDFS-7513.002.patch, HDFS-7513.003.patch HDFS inotify: add defaultBlockSize to CreateEvent -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7513) HDFS inotify: add defaultBlockSize to CreateEvent
[ https://issues.apache.org/jira/browse/HDFS-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248298#comment-14248298 ] Hudson commented on HDFS-7513: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1975 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1975/]) HDFS-7513. HDFS inotify: add defaultBlockSize to CreateEvent (cmccabe) (cmccabe: rev 6e13fc62e1f284f22fd0089f06ce281198bc7c2a) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/InotifyFSEditLogOpTranslator.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java * hadoop-hdfs-project/hadoop-hdfs/src/main/proto/inotify.proto * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java HDFS inotify: add defaultBlockSize to CreateEvent - Key: HDFS-7513 URL: https://issues.apache.org/jira/browse/HDFS-7513 Project: Hadoop HDFS Issue Type: Improvement Components: namenode Affects Versions: 2.6.0 Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: 2.7.0 Attachments: HDFS-7513.001.patch, HDFS-7513.002.patch, HDFS-7513.003.patch HDFS inotify: add defaultBlockSize to CreateEvent -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7513) HDFS inotify: add defaultBlockSize to CreateEvent
[ https://issues.apache.org/jira/browse/HDFS-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248315#comment-14248315 ] Hudson commented on HDFS-7513: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #40 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/40/]) HDFS-7513. HDFS inotify: add defaultBlockSize to CreateEvent (cmccabe) (cmccabe: rev 6e13fc62e1f284f22fd0089f06ce281198bc7c2a) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/InotifyFSEditLogOpTranslator.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/proto/inotify.proto HDFS inotify: add defaultBlockSize to CreateEvent - Key: HDFS-7513 URL: https://issues.apache.org/jira/browse/HDFS-7513 Project: Hadoop HDFS Issue Type: Improvement Components: namenode Affects Versions: 2.6.0 Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: 2.7.0 Attachments: HDFS-7513.001.patch, HDFS-7513.002.patch, HDFS-7513.003.patch HDFS inotify: add defaultBlockSize to CreateEvent -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7513) HDFS inotify: add defaultBlockSize to CreateEvent
[ https://issues.apache.org/jira/browse/HDFS-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248355#comment-14248355 ] Hudson commented on HDFS-7513: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #44 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/44/]) HDFS-7513. HDFS inotify: add defaultBlockSize to CreateEvent (cmccabe) (cmccabe: rev 6e13fc62e1f284f22fd0089f06ce281198bc7c2a) * hadoop-hdfs-project/hadoop-hdfs/src/main/proto/inotify.proto * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/InotifyFSEditLogOpTranslator.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java HDFS inotify: add defaultBlockSize to CreateEvent - Key: HDFS-7513 URL: https://issues.apache.org/jira/browse/HDFS-7513 Project: Hadoop HDFS Issue Type: Improvement Components: namenode Affects Versions: 2.6.0 Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: 2.7.0 Attachments: HDFS-7513.001.patch, HDFS-7513.002.patch, HDFS-7513.003.patch HDFS inotify: add defaultBlockSize to CreateEvent -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7513) HDFS inotify: add defaultBlockSize to CreateEvent
[ https://issues.apache.org/jira/browse/HDFS-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247000#comment-14247000 ] Hudson commented on HDFS-7513: -- SUCCESS: Integrated in Hadoop-trunk-Commit #6718 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6718/]) HDFS-7513. HDFS inotify: add defaultBlockSize to CreateEvent (cmccabe) (cmccabe: rev 6e13fc62e1f284f22fd0089f06ce281198bc7c2a) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/InotifyFSEditLogOpTranslator.java * hadoop-hdfs-project/hadoop-hdfs/src/main/proto/inotify.proto HDFS inotify: add defaultBlockSize to CreateEvent - Key: HDFS-7513 URL: https://issues.apache.org/jira/browse/HDFS-7513 Project: Hadoop HDFS Issue Type: Improvement Components: namenode Affects Versions: 2.6.0 Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: 2.7.0 Attachments: HDFS-7513.001.patch, HDFS-7513.002.patch, HDFS-7513.003.patch HDFS inotify: add defaultBlockSize to CreateEvent -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7513) HDFS inotify: add defaultBlockSize to CreateEvent
[ https://issues.apache.org/jira/browse/HDFS-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245015#comment-14245015 ] Colin Patrick McCabe commented on HDFS-7513: bq. Maybe drop set from setDefaultBlockSize for consistency with other methods? ok will commit pending jenkins, thanks for the review! HDFS inotify: add defaultBlockSize to CreateEvent - Key: HDFS-7513 URL: https://issues.apache.org/jira/browse/HDFS-7513 Project: Hadoop HDFS Issue Type: Improvement Components: namenode Affects Versions: 2.6.0 Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Attachments: HDFS-7513.001.patch, HDFS-7513.002.patch, HDFS-7513.003.patch HDFS inotify: add defaultBlockSize to CreateEvent -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7513) HDFS inotify: add defaultBlockSize to CreateEvent
[
https://issues.apache.org/jira/browse/HDFS-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245141#comment-14245141
]
Hadoop QA commented on HDFS-7513:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12686973/HDFS-7513.003.patch
against trunk revision c78e3a7.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9030//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9030//console
This message is automatically generated.
HDFS inotify: add defaultBlockSize to CreateEvent
-
Key: HDFS-7513
URL: https://issues.apache.org/jira/browse/HDFS-7513
Project: Hadoop HDFS
Issue Type: Improvement
Components: namenode
Affects Versions: 2.6.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Attachments: HDFS-7513.001.patch, HDFS-7513.002.patch,
HDFS-7513.003.patch
HDFS inotify: add defaultBlockSize to CreateEvent
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7513) HDFS inotify: add defaultBlockSize to CreateEvent
[
https://issues.apache.org/jira/browse/HDFS-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245150#comment-14245150
]
Hadoop QA commented on HDFS-7513:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12686973/HDFS-7513.003.patch
against trunk revision c78e3a7.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color}. The applied patch generated 1267 javac
compiler warnings (more than the trunk's current 1227 warnings).
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
40 warning messages.
See
https://builds.apache.org/job/PreCommit-HDFS-Build/9031//artifact/patchprocess/diffJavadocWarnings.txt
for details.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9031//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/9031//artifact/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9031//console
This message is automatically generated.
HDFS inotify: add defaultBlockSize to CreateEvent
-
Key: HDFS-7513
URL: https://issues.apache.org/jira/browse/HDFS-7513
Project: Hadoop HDFS
Issue Type: Improvement
Components: namenode
Affects Versions: 2.6.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Attachments: HDFS-7513.001.patch, HDFS-7513.002.patch,
HDFS-7513.003.patch
HDFS inotify: add defaultBlockSize to CreateEvent
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7513) HDFS inotify: add defaultBlockSize to CreateEvent
[ https://issues.apache.org/jira/browse/HDFS-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243176#comment-14243176 ] Colin Patrick McCabe commented on HDFS-7513: * I moved all the Event types to have builders. Some of them already did, but some didn't... I moved all of them to have them. When we add more stuff in the future, we really don't want to have a lot of overloads. * Add defaultBlockSize to CreateEvent. Old servers will not send this, and this field will show up as 0 for them. HDFS inotify: add defaultBlockSize to CreateEvent - Key: HDFS-7513 URL: https://issues.apache.org/jira/browse/HDFS-7513 Project: Hadoop HDFS Issue Type: Improvement Components: namenode Affects Versions: 2.6.0 Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Attachments: HDFS-7513.001.patch HDFS inotify: add defaultBlockSize to CreateEvent -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7513) HDFS inotify: add defaultBlockSize to CreateEvent
[
https://issues.apache.org/jira/browse/HDFS-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243284#comment-14243284
]
Andrew Wang commented on HDFS-7513:
---
Maybe drop {{set}} from {{setDefaultBlockSize}} for consistency with other
methods? I also agree that 0 seems like a reasonable invalid default value.
Otherwise LGTM +1.
HDFS inotify: add defaultBlockSize to CreateEvent
-
Key: HDFS-7513
URL: https://issues.apache.org/jira/browse/HDFS-7513
Project: Hadoop HDFS
Issue Type: Improvement
Components: namenode
Affects Versions: 2.6.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Attachments: HDFS-7513.001.patch, HDFS-7513.002.patch
HDFS inotify: add defaultBlockSize to CreateEvent
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7513) HDFS inotify: add defaultBlockSize to CreateEvent
[
https://issues.apache.org/jira/browse/HDFS-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243543#comment-14243543
]
Hadoop QA commented on HDFS-7513:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12686684/HDFS-7513.002.patch
against trunk revision 0bcea11.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9011//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/9011//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9011//console
This message is automatically generated.
HDFS inotify: add defaultBlockSize to CreateEvent
-
Key: HDFS-7513
URL: https://issues.apache.org/jira/browse/HDFS-7513
Project: Hadoop HDFS
Issue Type: Improvement
Components: namenode
Affects Versions: 2.6.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Attachments: HDFS-7513.001.patch, HDFS-7513.002.patch
HDFS inotify: add defaultBlockSize to CreateEvent
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
