[jira] [Commented] (HDFS-7516) Fix findbugs warnings in hdfs-nfs project

2014-12-15 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247070#comment-14247070
 ] 

Hadoop QA commented on HDFS-7516:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12687278/HDFS-7516.002.patch
  against trunk revision 6e13fc6.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-nfs.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/9038//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9038//console

This message is automatically generated.

 Fix findbugs warnings in hdfs-nfs project
 -

 Key: HDFS-7516
 URL: https://issues.apache.org/jira/browse/HDFS-7516
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: nfs
Affects Versions: 2.7.0
Reporter: Brandon Li
Assignee: Brandon Li
 Attachments: HDFS-7516.001.patch, HDFS-7516.002.patch, findbugsXml.xml






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-7516) Fix findbugs warnings in hdfs-nfs project

2014-12-12 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245009#comment-14245009
 ] 

Hadoop QA commented on HDFS-7516:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12686969/HDFS-7516.001.patch
  against trunk revision c78e3a7.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-nfs.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/9029//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9029//console

This message is automatically generated.

 Fix findbugs warnings in hdfs-nfs project
 -

 Key: HDFS-7516
 URL: https://issues.apache.org/jira/browse/HDFS-7516
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: nfs
Affects Versions: 2.7.0
Reporter: Brandon Li
Assignee: Brandon Li
 Attachments: HDFS-7516.001.patch, findbugsXml.xml






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-7516) Fix findbugs warnings in hdfs-nfs project

2014-12-12 Thread Haohui Mai (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245231#comment-14245231
 ] 

Haohui Mai commented on HDFS-7516:
--

The patch looks good. A nit:

{code}
-byte[] in = s.getBytes();
+byte[] in = s.getBytes(Charsets.UTF_8);
 for (int i = 0; i  in.length; i++) {
   digest.update(in[i]);
 }
{code}

You can do:

{code}
digest.update(s.getBytes(Charsets.UTF_8));
{code}

+1 after addressing it.

 Fix findbugs warnings in hdfs-nfs project
 -

 Key: HDFS-7516
 URL: https://issues.apache.org/jira/browse/HDFS-7516
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: nfs
Affects Versions: 2.7.0
Reporter: Brandon Li
Assignee: Brandon Li
 Attachments: HDFS-7516.001.patch, findbugsXml.xml






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)