[jira] [Commented] (HDFS-7538) removedDst should be checked against null in the finally block of FSDirRenameOp#unprotectedRenameTo()
[
https://issues.apache.org/jira/browse/HDFS-7538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335972#comment-14335972
]
Binglin Chang commented on HDFS-7538:
-
Hi [~tedyu], the patch is out of date, and I think the bug no longer exists,
should this be resolved?
> removedDst should be checked against null in the finally block of
> FSDirRenameOp#unprotectedRenameTo()
> -
>
> Key: HDFS-7538
> URL: https://issues.apache.org/jira/browse/HDFS-7538
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: hdfs-7538-001.patch
>
>
> {code}
> if (removedDst != null) {
> undoRemoveDst = false;
> ...
> if (undoRemoveDst) {
> // Rename failed - restore dst
> if (dstParent.isDirectory() &&
> dstParent.asDirectory().isWithSnapshot()) {
> dstParent.asDirectory().undoRename4DstParent(removedDst,
> {code}
> If the first if check doesn't pass, removedDst would be null and
> undoRemoveDst may be true.
> This combination would lead to NullPointerException in the finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7538) removedDst should be checked against null in the finally block of FSDirRenameOp#unprotectedRenameTo()
[
https://issues.apache.org/jira/browse/HDFS-7538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252395#comment-14252395
]
Hadoop QA commented on HDFS-7538:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12688080/hdfs-7538-001.patch
against trunk revision 389f881.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestDecommission
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration
org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9076//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9076//console
This message is automatically generated.
> removedDst should be checked against null in the finally block of
> FSDirRenameOp#unprotectedRenameTo()
> -
>
> Key: HDFS-7538
> URL: https://issues.apache.org/jira/browse/HDFS-7538
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: hdfs-7538-001.patch
>
>
> {code}
> if (removedDst != null) {
> undoRemoveDst = false;
> ...
> if (undoRemoveDst) {
> // Rename failed - restore dst
> if (dstParent.isDirectory() &&
> dstParent.asDirectory().isWithSnapshot()) {
> dstParent.asDirectory().undoRename4DstParent(removedDst,
> {code}
> If the first if check doesn't pass, removedDst would be null and
> undoRemoveDst may be true.
> This combination would lead to NullPointerException in the finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
