[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269222#comment-14269222 ] Hudson commented on HDFS-7561: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #67 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/67/]) HDFS-7561. TestFetchImage should write fetched-image-dir under target. Contributed by Liang Xie. (shv: rev e86943fd6429be96913db4b61363faa66e95508c) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFetchImage.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Assignee: Liang Xie Fix For: 2.7.0 Attachments: HDFS-7561-001.txt, HDFS-7561-002.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269249#comment-14269249 ] Hudson commented on HDFS-7561: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #801 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/801/]) HDFS-7561. TestFetchImage should write fetched-image-dir under target. Contributed by Liang Xie. (shv: rev e86943fd6429be96913db4b61363faa66e95508c) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFetchImage.java TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Assignee: Liang Xie Fix For: 2.7.0 Attachments: HDFS-7561-001.txt, HDFS-7561-002.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269358#comment-14269358 ] Hudson commented on HDFS-7561: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1999 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1999/]) HDFS-7561. TestFetchImage should write fetched-image-dir under target. Contributed by Liang Xie. (shv: rev e86943fd6429be96913db4b61363faa66e95508c) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFetchImage.java TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Assignee: Liang Xie Fix For: 2.7.0 Attachments: HDFS-7561-001.txt, HDFS-7561-002.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269431#comment-14269431 ] Hudson commented on HDFS-7561: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2018 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2018/]) HDFS-7561. TestFetchImage should write fetched-image-dir under target. Contributed by Liang Xie. (shv: rev e86943fd6429be96913db4b61363faa66e95508c) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFetchImage.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Assignee: Liang Xie Fix For: 2.7.0 Attachments: HDFS-7561-001.txt, HDFS-7561-002.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269381#comment-14269381 ] Hudson commented on HDFS-7561: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #64 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/64/]) HDFS-7561. TestFetchImage should write fetched-image-dir under target. Contributed by Liang Xie. (shv: rev e86943fd6429be96913db4b61363faa66e95508c) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFetchImage.java TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Assignee: Liang Xie Fix For: 2.7.0 Attachments: HDFS-7561-001.txt, HDFS-7561-002.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269416#comment-14269416 ] Hudson commented on HDFS-7561: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #68 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/68/]) HDFS-7561. TestFetchImage should write fetched-image-dir under target. Contributed by Liang Xie. (shv: rev e86943fd6429be96913db4b61363faa66e95508c) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFetchImage.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Assignee: Liang Xie Fix For: 2.7.0 Attachments: HDFS-7561-001.txt, HDFS-7561-002.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268557#comment-14268557 ] Hudson commented on HDFS-7561: -- FAILURE: Integrated in Hadoop-trunk-Commit #6824 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6824/]) HDFS-7561. TestFetchImage should write fetched-image-dir under target. Contributed by Liang Xie. (shv: rev e86943fd6429be96913db4b61363faa66e95508c) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFetchImage.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Assignee: Liang Xie Fix For: 2.7.0 Attachments: HDFS-7561-001.txt, HDFS-7561-002.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256861#comment-14256861 ] Hadoop QA commented on HDFS-7561: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12688808/HDFS-7561-002.txt against trunk revision 5caebba. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9117//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/9117//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9117//console This message is automatically generated. TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Assignee: Liang Xie Attachments: HDFS-7561-001.txt, HDFS-7561-002.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256949#comment-14256949 ] Akira AJISAKA commented on HDFS-7561: - +1. The findbug warning is not related to the patch. TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Assignee: Liang Xie Attachments: HDFS-7561-001.txt, HDFS-7561-002.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257373#comment-14257373 ] Konstantin Shvachko commented on HDFS-7561: --- +1 lgtm TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Assignee: Liang Xie Attachments: HDFS-7561-001.txt, HDFS-7561-002.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255591#comment-14255591 ] Hadoop QA commented on HDFS-7561: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12688615/HDFS-7561-001.txt against trunk revision ecf1469. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.fs.TestSymlinkHdfsFileContext Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9106//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/9106//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9106//console This message is automatically generated. TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Attachments: HDFS-7561-001.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256056#comment-14256056 ] Konstantin Shvachko commented on HDFS-7561: --- This does fix the problem when you run the test from command line. But if I run it in debugger it still creates fetched-image-dir under hadoop-hdfs. TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Attachments: HDFS-7561-001.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256381#comment-14256381 ] Akira AJISAKA commented on HDFS-7561: - Hi [~shv], how about the below change? {code} - System.getProperty(build.test.dir), fetched-image-dir); + System.getProperty(test.build.dir), target/fetched-image-dir); {code} TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Attachments: HDFS-7561-001.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256472#comment-14256472 ] Konstantin Shvachko commented on HDFS-7561: --- Sounds right. TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Attachments: HDFS-7561-001.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256474#comment-14256474 ] Akira AJISAKA commented on HDFS-7561: - Thanks. Hi [~xieliang007], would you update the patch to include the above fix? I'm +1 if that is addressed. TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Attachments: HDFS-7561-001.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255489#comment-14255489 ] Akira AJISAKA commented on HDFS-7561: - Verified the patch locally. +1 pending Jenkins. By the way, I found two build.test.dir in other places. We should fix them in separate jira. TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Attachments: HDFS-7561-001.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7561) TestFetchImage should write fetched-image-dir under target.
[ https://issues.apache.org/jira/browse/HDFS-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255517#comment-14255517 ] Akira AJISAKA commented on HDFS-7561: - Filed HADOOP-11440 for ClientBaseWithFixes.java . TestFetchImage should write fetched-image-dir under target. --- Key: HDFS-7561 URL: https://issues.apache.org/jira/browse/HDFS-7561 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.6.0 Reporter: Konstantin Shvachko Attachments: HDFS-7561-001.txt {{TestFetchImage}} creates directory {{fetched-image-dir}} under hadoop-hdfs, which is then never cleaned up. The problem is that it uses build.test.dir property, which seems to be invalid. Probably should use {{MiniDFSCluster.getBaseDirectory()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)