[jira] [Commented] (HDFS-7577) Add additional headers that includes need by Windows

2015-01-29 Thread Thanh Do (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297336#comment-14297336
 ] 

Thanh Do commented on HDFS-7577:


Thanks Colin. I'll work on the next patch soon. Best!

> Add additional headers that includes need by Windows
> 
>
> Key: HDFS-7577
> URL: https://issues.apache.org/jira/browse/HDFS-7577
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: hdfs-client
>Reporter: Thanh Do
>Assignee: Thanh Do
> Fix For: HDFS-6994
>
> Attachments: HDFS-7577-branch-HDFS-6994-0.patch, 
> HDFS-7577-branch-HDFS-6994-1.patch, HDFS-7577-branch-HDFS-6994-2.patch
>
>
> This jira involves adding a list of (mostly dummy) headers that available in 
> POSIX systems, but not in Windows. One step towards making libhdfs3 built in 
> Windows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-7577) Add additional headers that includes need by Windows

2015-01-26 Thread Colin Patrick McCabe (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292414#comment-14292414
 ] 

Colin Patrick McCabe commented on HDFS-7577:


cpuid.h: we need an #error when this isn't x86, to explain why compilation is 
failing (due to the unimplemented function)

+1 once that's resolved

> Add additional headers that includes need by Windows
> 
>
> Key: HDFS-7577
> URL: https://issues.apache.org/jira/browse/HDFS-7577
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: hdfs-client
>Reporter: Thanh Do
>Assignee: Thanh Do
> Attachments: HDFS-7577-branch-HDFS-6994-0.patch, 
> HDFS-7577-branch-HDFS-6994-1.patch
>
>
> This jira involves adding a list of (mostly dummy) headers that available in 
> POSIX systems, but not in Windows. One step towards making libhdfs3 built in 
> Windows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-7577) Add additional headers that includes need by Windows

2015-01-26 Thread Thanh Do (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291908#comment-14291908
 ] 

Thanh Do commented on HDFS-7577:


Hi [~cmccabe]. Could please you take a look at the new patch? I really like to 
get this in so that I can start the next patch, which depends on this one. 
Thank you.

> Add additional headers that includes need by Windows
> 
>
> Key: HDFS-7577
> URL: https://issues.apache.org/jira/browse/HDFS-7577
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: hdfs-client
>Reporter: Thanh Do
>Assignee: Thanh Do
> Attachments: HDFS-7577-branch-HDFS-6994-0.patch, 
> HDFS-7577-branch-HDFS-6994-1.patch
>
>
> This jira involves adding a list of (mostly dummy) headers that available in 
> POSIX systems, but not in Windows. One step towards making libhdfs3 built in 
> Windows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-7577) Add additional headers that includes need by Windows

2015-01-20 Thread Colin Patrick McCabe (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285057#comment-14285057
 ] 

Colin Patrick McCabe commented on HDFS-7577:


This looks pretty good.

{{os/windows/cpuid.h}}: this is x86-specific, right?  Can we put this in an x86 
ifdef like the one from HWCrc32c.cc?

Something like this maybe:
{code}
#if ((defined(__X86__) || defined(__i386__) || defined(i386) || 
defined(_M_IX86) || defined(__386__) || defined(__x86_64__) || defined(_M_X64)))
{code}

> Add additional headers that includes need by Windows
> 
>
> Key: HDFS-7577
> URL: https://issues.apache.org/jira/browse/HDFS-7577
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: hdfs-client
>Reporter: Thanh Do
>Assignee: Thanh Do
> Attachments: HDFS-7577-branch-HDFS-6994-0.patch
>
>
> This jira involves adding a list of (mostly dummy) headers that available in 
> POSIX systems, but not in Windows. One step towards making libhdfs3 built in 
> Windows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)