[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280087#comment-14280087
]
Hudson commented on HDFS-7591:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #75 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/75/])
HDFS-7591. hdfs classpath command should support same options as hadoop
classpath. (Contributed by Varun Saxena) (arp: rev
a6efbb21c2561f718f02a788d5fd25c02eff09a0)
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* hadoop-common-project/hadoop-common/src/main/bin/hadoop
* hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Improvement
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Fix For: 3.0.0
Attachments: HDFS-7591.001.patch, HDFS-7591.002.patch,
HDFS-7591.branch-2.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280101#comment-14280101
]
Hudson commented on HDFS-7591:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #809 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/809/])
HDFS-7591. hdfs classpath command should support same options as hadoop
classpath. (Contributed by Varun Saxena) (arp: rev
a6efbb21c2561f718f02a788d5fd25c02eff09a0)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-common-project/hadoop-common/src/main/bin/hadoop
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Improvement
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Fix For: 3.0.0
Attachments: HDFS-7591.001.patch, HDFS-7591.002.patch,
HDFS-7591.branch-2.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280290#comment-14280290
]
Hudson commented on HDFS-7591:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #2007 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2007/])
HDFS-7591. hdfs classpath command should support same options as hadoop
classpath. (Contributed by Varun Saxena) (arp: rev
a6efbb21c2561f718f02a788d5fd25c02eff09a0)
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* hadoop-common-project/hadoop-common/src/main/bin/hadoop
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Improvement
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Fix For: 3.0.0
Attachments: HDFS-7591.001.patch, HDFS-7591.002.patch,
HDFS-7591.branch-2.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280311#comment-14280311
]
Hudson commented on HDFS-7591:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #72 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/72/])
HDFS-7591. hdfs classpath command should support same options as hadoop
classpath. (Contributed by Varun Saxena) (arp: rev
a6efbb21c2561f718f02a788d5fd25c02eff09a0)
* hadoop-common-project/hadoop-common/src/main/bin/hadoop
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
* hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Improvement
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Fix For: 3.0.0
Attachments: HDFS-7591.001.patch, HDFS-7591.002.patch,
HDFS-7591.branch-2.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280356#comment-14280356
]
Hudson commented on HDFS-7591:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #76 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/76/])
HDFS-7591. hdfs classpath command should support same options as hadoop
classpath. (Contributed by Varun Saxena) (arp: rev
a6efbb21c2561f718f02a788d5fd25c02eff09a0)
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
* hadoop-common-project/hadoop-common/src/main/bin/hadoop
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Improvement
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Fix For: 3.0.0
Attachments: HDFS-7591.001.patch, HDFS-7591.002.patch,
HDFS-7591.branch-2.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280417#comment-14280417
]
Hudson commented on HDFS-7591:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2026 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2026/])
HDFS-7591. hdfs classpath command should support same options as hadoop
classpath. (Contributed by Varun Saxena) (arp: rev
a6efbb21c2561f718f02a788d5fd25c02eff09a0)
* hadoop-common-project/hadoop-common/src/main/bin/hadoop
* hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Improvement
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Fix For: 3.0.0
Attachments: HDFS-7591.001.patch, HDFS-7591.002.patch,
HDFS-7591.branch-2.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279041#comment-14279041
]
Arpit Agarwal commented on HDFS-7591:
-
Thanks for the updated patch [~varun_saxena].
# We should also fix the 'yarn classpath' command.
# The patch won't apply to branch-2 since hadoop-functions.sh is not available.
Feel free to attach a separate patch for branch-2 if you want to and I can
commit that one too.
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Bug
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Attachments: HDFS-7591.001.patch, HDFS-7591.002.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279107#comment-14279107
]
Varun Saxena commented on HDFS-7591:
[~arpitagarwal], will make changes for yarn and mapred(i.e. YARN-3015 and
MAPREDUCE-3283) once this is committed.
Will attach a patch for branch-2 shortly
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Improvement
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Attachments: HDFS-7591.001.patch, HDFS-7591.002.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279064#comment-14279064
]
Arpit Agarwal commented on HDFS-7591:
-
Thanks for the clarifications Chris. +1 for the v002 patch, will commit it
today.
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Bug
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Attachments: HDFS-7591.001.patch, HDFS-7591.002.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279057#comment-14279057
]
Chris Nauroth commented on HDFS-7591:
-
Hi Arpit. There are a few different jiras tracking the change in each
sub-project. They're all linked to the original HADOOP-10903 if you're
interested in seeing the others. For the HDFS change here, I specifically
targeted it to 3.0.0, because the hdfs script doesn't have the classpath
sub-command in branch-2. (Of course, we could add it now if you prefer.)
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Bug
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Attachments: HDFS-7591.001.patch, HDFS-7591.002.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279227#comment-14279227
]
Varun Saxena commented on HDFS-7591:
[~arpitagarwal], attached a patch for branch-2
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Improvement
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Fix For: 3.0.0
Attachments: HDFS-7591.001.patch, HDFS-7591.002.patch,
HDFS-7591.branch-2.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279136#comment-14279136
]
Hudson commented on HDFS-7591:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6869 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/6869/])
HDFS-7591. hdfs classpath command should support same options as hadoop
classpath. (Contributed by Varun Saxena) (arp: rev
a6efbb21c2561f718f02a788d5fd25c02eff09a0)
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
* hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
* hadoop-common-project/hadoop-common/src/main/bin/hadoop
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Improvement
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Fix For: 3.0.0
Attachments: HDFS-7591.001.patch, HDFS-7591.002.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279443#comment-14279443
]
Arpit Agarwal commented on HDFS-7591:
-
Hi Varun,
In hadoop:
{code}
if [ $# -gt 1 ]; then
CLASS=org.apache.hadoop.util.Classpath
else
{code}
This should be {{if [[ $# -gt 0 ]]}}. +1 with that fixed.
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Improvement
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Fix For: 3.0.0
Attachments: HDFS-7591.001.patch, HDFS-7591.002.patch,
HDFS-7591.branch-2.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279700#comment-14279700
]
Varun Saxena commented on HDFS-7591:
[~arpitagarwal], in hadoop script in branch-2 we do not have a shift after
storing the first argument in COMMAND variable.
So $# would not change when this condition is hit..
In hdfs script in branch-2 though, there is a shift before the relevant
condition is hit. Hence the difference.
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Improvement
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Fix For: 3.0.0
Attachments: HDFS-7591.001.patch, HDFS-7591.002.patch,
HDFS-7591.branch-2.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278667#comment-14278667
]
Hadoop QA commented on HDFS-7591:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12692496/HDFS-7591.002.patch
against trunk revision ba5116e.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9221//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9221//console
This message is automatically generated.
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Bug
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Attachments: HDFS-7591.001.patch, HDFS-7591.002.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14276142#comment-14276142
]
Chris Nauroth commented on HDFS-7591:
-
[~arpitagarwal], thank you for catching that. Yes, you're right. This
condition works fine in the branch-2 code, but I missed the fact that the trunk
code does an additional {{shift}} call before reaching this point.
[~varun_saxena], thank you for the patch. In the trunk version of the batch
code, we have a much better setup for code reuse. I suggest adding a function
called {{hadoop_do_classpath_subcommand}} to hadoop-functions.sh. That
function would contain the same code that your current patch adds to the hdfs
script, along with the fix suggested by Arpit. After that function is in
place, all of the individual entry points can use one line of code to call it
like this:
{code}
hadoop_do_classpath_subcommand $@
{code}
Feel free to make the change to the hadoop script too within the scope of this
jira.
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Bug
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Attachments: HDFS-7591.001.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14274327#comment-14274327
]
Arpit Agarwal commented on HDFS-7591:
-
Hi Chris,
Should the following check be {{if [[ $# -gt 0 ]]}}?
i.e we echo $CLASSPATH if the number of arguments is zero, else we launch
_Classpath_. I think I missed the same issue when code reviewing HADOOP-10903
(my apologies!) for _hadoop classpath_.
{code}
+if [[ $# -eq 1 ]]; then
+ CLASS=org.apache.hadoop.util.Classpath
+else
+ hadoop_finalize
+ echo ${CLASSPATH}
+ exit 0
{code}
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Bug
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Attachments: HDFS-7591.001.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14273013#comment-14273013
]
Hadoop QA commented on HDFS-7591:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12691554/HDFS-7591.001.patch
against trunk revision ef3c3a8.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9182//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9182//console
This message is automatically generated.
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Bug
Components: scripts
Reporter: Chris Nauroth
Assignee: Varun Saxena
Priority: Minor
Attachments: HDFS-7591.001.patch
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7591) hdfs classpath command should support same options as hadoop classpath.
[
https://issues.apache.org/jira/browse/HDFS-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268629#comment-14268629
]
Chris Nauroth commented on HDFS-7591:
-
Thanks to [~aw] for reporting it to me. This one is targeted to 3.0.0 only,
because there is no {{hdfs classpath}} command in 2.x.
hdfs classpath command should support same options as hadoop classpath.
---
Key: HDFS-7591
URL: https://issues.apache.org/jira/browse/HDFS-7591
Project: Hadoop HDFS
Issue Type: Bug
Components: scripts
Reporter: Chris Nauroth
HADOOP-10903 enhanced the {{hadoop classpath}} command to support optional
expansion of the wildcards and bundling the classpath into a jar file
containing a manifest with the Class-Path attribute. The other classpath
commands should do the same for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
