[jira] [Commented] (HDFS-7598) Remove dependency on old version of Guava in TestDFSClientCache#testEviction
[
https://issues.apache.org/jira/browse/HDFS-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275396#comment-14275396
]
Hudson commented on HDFS-7598:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2023 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2023/])
HDFS-7598. Remove dependency on old version of Guava in
TestDFSClientCache#testEviction (Sangjin Lee via Colin P. McCabe) (cmccabe: rev
b3ddd7ee39c92d2df8661ce5834a2831020cecb2)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java
> Remove dependency on old version of Guava in TestDFSClientCache#testEviction
>
>
> Key: HDFS-7598
> URL: https://issues.apache.org/jira/browse/HDFS-7598
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
>Affects Versions: 2.6.0
>Reporter: Sangjin Lee
>Assignee: Sangjin Lee
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7598.001.patch
>
>
> TestDFSClientCache.testEviction() is not entirely accurate in its usage of
> the guava LoadingCache.
> It sets the max size at 2, but asserts the loading cache will contain only 1
> entry after inserting two entries. Guava's CacheBuilder.maximumSize() makes
> only the following promise:
> {panel}
> Specifies the maximum number of entries the cache may contain. Note that the
> cache may evict an entry before this limit is exceeded.
> {panel}
> Thus, the only invariant is that the loading cache will hold the maximum size
> number of entries or fewer. The DFSClientCache.testEviction asserts it holds
> maximum size - 1 exactly.
> For guava 11.0.2 this happens to be true at maximum size = 2 because of the
> way it sets the maximum segment weight. With later versions of guava, the
> maximum segment weight is set higher, and the eviction is less aggressive.
> The test should be fixed to assert only the true invariant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7598) Remove dependency on old version of Guava in TestDFSClientCache#testEviction
[
https://issues.apache.org/jira/browse/HDFS-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275325#comment-14275325
]
Hudson commented on HDFS-7598:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #73 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/73/])
HDFS-7598. Remove dependency on old version of Guava in
TestDFSClientCache#testEviction (Sangjin Lee via Colin P. McCabe) (cmccabe: rev
b3ddd7ee39c92d2df8661ce5834a2831020cecb2)
*
hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Remove dependency on old version of Guava in TestDFSClientCache#testEviction
>
>
> Key: HDFS-7598
> URL: https://issues.apache.org/jira/browse/HDFS-7598
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
>Affects Versions: 2.6.0
>Reporter: Sangjin Lee
>Assignee: Sangjin Lee
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7598.001.patch
>
>
> TestDFSClientCache.testEviction() is not entirely accurate in its usage of
> the guava LoadingCache.
> It sets the max size at 2, but asserts the loading cache will contain only 1
> entry after inserting two entries. Guava's CacheBuilder.maximumSize() makes
> only the following promise:
> {panel}
> Specifies the maximum number of entries the cache may contain. Note that the
> cache may evict an entry before this limit is exceeded.
> {panel}
> Thus, the only invariant is that the loading cache will hold the maximum size
> number of entries or fewer. The DFSClientCache.testEviction asserts it holds
> maximum size - 1 exactly.
> For guava 11.0.2 this happens to be true at maximum size = 2 because of the
> way it sets the maximum segment weight. With later versions of guava, the
> maximum segment weight is set higher, and the eviction is less aggressive.
> The test should be fixed to assert only the true invariant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7598) Remove dependency on old version of Guava in TestDFSClientCache#testEviction
[
https://issues.apache.org/jira/browse/HDFS-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275268#comment-14275268
]
Hudson commented on HDFS-7598:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #2004 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2004/])
HDFS-7598. Remove dependency on old version of Guava in
TestDFSClientCache#testEviction (Sangjin Lee via Colin P. McCabe) (cmccabe: rev
b3ddd7ee39c92d2df8661ce5834a2831020cecb2)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java
> Remove dependency on old version of Guava in TestDFSClientCache#testEviction
>
>
> Key: HDFS-7598
> URL: https://issues.apache.org/jira/browse/HDFS-7598
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
>Affects Versions: 2.6.0
>Reporter: Sangjin Lee
>Assignee: Sangjin Lee
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7598.001.patch
>
>
> TestDFSClientCache.testEviction() is not entirely accurate in its usage of
> the guava LoadingCache.
> It sets the max size at 2, but asserts the loading cache will contain only 1
> entry after inserting two entries. Guava's CacheBuilder.maximumSize() makes
> only the following promise:
> {panel}
> Specifies the maximum number of entries the cache may contain. Note that the
> cache may evict an entry before this limit is exceeded.
> {panel}
> Thus, the only invariant is that the loading cache will hold the maximum size
> number of entries or fewer. The DFSClientCache.testEviction asserts it holds
> maximum size - 1 exactly.
> For guava 11.0.2 this happens to be true at maximum size = 2 because of the
> way it sets the maximum segment weight. With later versions of guava, the
> maximum segment weight is set higher, and the eviction is less aggressive.
> The test should be fixed to assert only the true invariant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7598) Remove dependency on old version of Guava in TestDFSClientCache#testEviction
[
https://issues.apache.org/jira/browse/HDFS-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275250#comment-14275250
]
Hudson commented on HDFS-7598:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #69 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/69/])
HDFS-7598. Remove dependency on old version of Guava in
TestDFSClientCache#testEviction (Sangjin Lee via Colin P. McCabe) (cmccabe: rev
b3ddd7ee39c92d2df8661ce5834a2831020cecb2)
*
hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Remove dependency on old version of Guava in TestDFSClientCache#testEviction
>
>
> Key: HDFS-7598
> URL: https://issues.apache.org/jira/browse/HDFS-7598
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
>Affects Versions: 2.6.0
>Reporter: Sangjin Lee
>Assignee: Sangjin Lee
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7598.001.patch
>
>
> TestDFSClientCache.testEviction() is not entirely accurate in its usage of
> the guava LoadingCache.
> It sets the max size at 2, but asserts the loading cache will contain only 1
> entry after inserting two entries. Guava's CacheBuilder.maximumSize() makes
> only the following promise:
> {panel}
> Specifies the maximum number of entries the cache may contain. Note that the
> cache may evict an entry before this limit is exceeded.
> {panel}
> Thus, the only invariant is that the loading cache will hold the maximum size
> number of entries or fewer. The DFSClientCache.testEviction asserts it holds
> maximum size - 1 exactly.
> For guava 11.0.2 this happens to be true at maximum size = 2 because of the
> way it sets the maximum segment weight. With later versions of guava, the
> maximum segment weight is set higher, and the eviction is less aggressive.
> The test should be fixed to assert only the true invariant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7598) Remove dependency on old version of Guava in TestDFSClientCache#testEviction
[
https://issues.apache.org/jira/browse/HDFS-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275102#comment-14275102
]
Hudson commented on HDFS-7598:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #806 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/806/])
HDFS-7598. Remove dependency on old version of Guava in
TestDFSClientCache#testEviction (Sangjin Lee via Colin P. McCabe) (cmccabe: rev
b3ddd7ee39c92d2df8661ce5834a2831020cecb2)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java
> Remove dependency on old version of Guava in TestDFSClientCache#testEviction
>
>
> Key: HDFS-7598
> URL: https://issues.apache.org/jira/browse/HDFS-7598
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
>Affects Versions: 2.6.0
>Reporter: Sangjin Lee
>Assignee: Sangjin Lee
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7598.001.patch
>
>
> TestDFSClientCache.testEviction() is not entirely accurate in its usage of
> the guava LoadingCache.
> It sets the max size at 2, but asserts the loading cache will contain only 1
> entry after inserting two entries. Guava's CacheBuilder.maximumSize() makes
> only the following promise:
> {panel}
> Specifies the maximum number of entries the cache may contain. Note that the
> cache may evict an entry before this limit is exceeded.
> {panel}
> Thus, the only invariant is that the loading cache will hold the maximum size
> number of entries or fewer. The DFSClientCache.testEviction asserts it holds
> maximum size - 1 exactly.
> For guava 11.0.2 this happens to be true at maximum size = 2 because of the
> way it sets the maximum segment weight. With later versions of guava, the
> maximum segment weight is set higher, and the eviction is less aggressive.
> The test should be fixed to assert only the true invariant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7598) Remove dependency on old version of Guava in TestDFSClientCache#testEviction
[
https://issues.apache.org/jira/browse/HDFS-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275084#comment-14275084
]
Hudson commented on HDFS-7598:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #72 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/72/])
HDFS-7598. Remove dependency on old version of Guava in
TestDFSClientCache#testEviction (Sangjin Lee via Colin P. McCabe) (cmccabe: rev
b3ddd7ee39c92d2df8661ce5834a2831020cecb2)
*
hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Remove dependency on old version of Guava in TestDFSClientCache#testEviction
>
>
> Key: HDFS-7598
> URL: https://issues.apache.org/jira/browse/HDFS-7598
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
>Affects Versions: 2.6.0
>Reporter: Sangjin Lee
>Assignee: Sangjin Lee
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7598.001.patch
>
>
> TestDFSClientCache.testEviction() is not entirely accurate in its usage of
> the guava LoadingCache.
> It sets the max size at 2, but asserts the loading cache will contain only 1
> entry after inserting two entries. Guava's CacheBuilder.maximumSize() makes
> only the following promise:
> {panel}
> Specifies the maximum number of entries the cache may contain. Note that the
> cache may evict an entry before this limit is exceeded.
> {panel}
> Thus, the only invariant is that the loading cache will hold the maximum size
> number of entries or fewer. The DFSClientCache.testEviction asserts it holds
> maximum size - 1 exactly.
> For guava 11.0.2 this happens to be true at maximum size = 2 because of the
> way it sets the maximum segment weight. With later versions of guava, the
> maximum segment weight is set higher, and the eviction is less aggressive.
> The test should be fixed to assert only the true invariant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7598) Remove dependency on old version of Guava in TestDFSClientCache#testEviction
[
https://issues.apache.org/jira/browse/HDFS-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274563#comment-14274563
]
Sangjin Lee commented on HDFS-7598:
---
Thanks [~cmccabe]!
> Remove dependency on old version of Guava in TestDFSClientCache#testEviction
>
>
> Key: HDFS-7598
> URL: https://issues.apache.org/jira/browse/HDFS-7598
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
>Affects Versions: 2.6.0
>Reporter: Sangjin Lee
>Assignee: Sangjin Lee
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7598.001.patch
>
>
> TestDFSClientCache.testEviction() is not entirely accurate in its usage of
> the guava LoadingCache.
> It sets the max size at 2, but asserts the loading cache will contain only 1
> entry after inserting two entries. Guava's CacheBuilder.maximumSize() makes
> only the following promise:
> {panel}
> Specifies the maximum number of entries the cache may contain. Note that the
> cache may evict an entry before this limit is exceeded.
> {panel}
> Thus, the only invariant is that the loading cache will hold the maximum size
> number of entries or fewer. The DFSClientCache.testEviction asserts it holds
> maximum size - 1 exactly.
> For guava 11.0.2 this happens to be true at maximum size = 2 because of the
> way it sets the maximum segment weight. With later versions of guava, the
> maximum segment weight is set higher, and the eviction is less aggressive.
> The test should be fixed to assert only the true invariant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7598) Remove dependency on old version of Guava in TestDFSClientCache#testEviction
[
https://issues.apache.org/jira/browse/HDFS-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274541#comment-14274541
]
Hudson commented on HDFS-7598:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6847 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/6847/])
HDFS-7598. Remove dependency on old version of Guava in
TestDFSClientCache#testEviction (Sangjin Lee via Colin P. McCabe) (cmccabe: rev
b3ddd7ee39c92d2df8661ce5834a2831020cecb2)
*
hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Remove dependency on old version of Guava in TestDFSClientCache#testEviction
>
>
> Key: HDFS-7598
> URL: https://issues.apache.org/jira/browse/HDFS-7598
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
>Affects Versions: 2.6.0
>Reporter: Sangjin Lee
>Assignee: Sangjin Lee
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7598.001.patch
>
>
> TestDFSClientCache.testEviction() is not entirely accurate in its usage of
> the guava LoadingCache.
> It sets the max size at 2, but asserts the loading cache will contain only 1
> entry after inserting two entries. Guava's CacheBuilder.maximumSize() makes
> only the following promise:
> {panel}
> Specifies the maximum number of entries the cache may contain. Note that the
> cache may evict an entry before this limit is exceeded.
> {panel}
> Thus, the only invariant is that the loading cache will hold the maximum size
> number of entries or fewer. The DFSClientCache.testEviction asserts it holds
> maximum size - 1 exactly.
> For guava 11.0.2 this happens to be true at maximum size = 2 because of the
> way it sets the maximum segment weight. With later versions of guava, the
> maximum segment weight is set higher, and the eviction is less aggressive.
> The test should be fixed to assert only the true invariant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
