[jira] [Commented] (HDFS-7637) Fix the check condition for reserved path
[
https://issues.apache.org/jira/browse/HDFS-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283924#comment-14283924
]
Hudson commented on HDFS-7637:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2030 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2030/])
HDFS-7637. Fix the check condition for reserved path. Contributed by Yi Liu.
(jing9: rev e843a0a8cee5c704a5d28cf14b5a4050094d341b)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
> Fix the check condition for reserved path
> -
>
> Key: HDFS-7637
> URL: https://issues.apache.org/jira/browse/HDFS-7637
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Yi Liu
>Assignee: Yi Liu
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7637.001.patch
>
>
> Currently the {{.reserved}} patch check function is:
> {code}
> public static boolean isReservedName(String src) {
> return src.startsWith(DOT_RESERVED_PATH_PREFIX);
> }
> {code}
> And {{DOT_RESERVED_PATH_PREFIX}} is {{/.reserved}}, it should be
> {{/.reserved/}}, for example: if some other directory prefix with
> _/.reserved_, we say it's _/.reservedpath_, then the check is wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7637) Fix the check condition for reserved path
[
https://issues.apache.org/jira/browse/HDFS-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283901#comment-14283901
]
Hudson commented on HDFS-7637:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #80 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/80/])
HDFS-7637. Fix the check condition for reserved path. Contributed by Yi Liu.
(jing9: rev e843a0a8cee5c704a5d28cf14b5a4050094d341b)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
> Fix the check condition for reserved path
> -
>
> Key: HDFS-7637
> URL: https://issues.apache.org/jira/browse/HDFS-7637
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Yi Liu
>Assignee: Yi Liu
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7637.001.patch
>
>
> Currently the {{.reserved}} patch check function is:
> {code}
> public static boolean isReservedName(String src) {
> return src.startsWith(DOT_RESERVED_PATH_PREFIX);
> }
> {code}
> And {{DOT_RESERVED_PATH_PREFIX}} is {{/.reserved}}, it should be
> {{/.reserved/}}, for example: if some other directory prefix with
> _/.reserved_, we say it's _/.reservedpath_, then the check is wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7637) Fix the check condition for reserved path
[
https://issues.apache.org/jira/browse/HDFS-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283876#comment-14283876
]
Hudson commented on HDFS-7637:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #2011 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2011/])
HDFS-7637. Fix the check condition for reserved path. Contributed by Yi Liu.
(jing9: rev e843a0a8cee5c704a5d28cf14b5a4050094d341b)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Fix the check condition for reserved path
> -
>
> Key: HDFS-7637
> URL: https://issues.apache.org/jira/browse/HDFS-7637
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Yi Liu
>Assignee: Yi Liu
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7637.001.patch
>
>
> Currently the {{.reserved}} patch check function is:
> {code}
> public static boolean isReservedName(String src) {
> return src.startsWith(DOT_RESERVED_PATH_PREFIX);
> }
> {code}
> And {{DOT_RESERVED_PATH_PREFIX}} is {{/.reserved}}, it should be
> {{/.reserved/}}, for example: if some other directory prefix with
> _/.reserved_, we say it's _/.reservedpath_, then the check is wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7637) Fix the check condition for reserved path
[
https://issues.apache.org/jira/browse/HDFS-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283863#comment-14283863
]
Hudson commented on HDFS-7637:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #76 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/76/])
HDFS-7637. Fix the check condition for reserved path. Contributed by Yi Liu.
(jing9: rev e843a0a8cee5c704a5d28cf14b5a4050094d341b)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
> Fix the check condition for reserved path
> -
>
> Key: HDFS-7637
> URL: https://issues.apache.org/jira/browse/HDFS-7637
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Yi Liu
>Assignee: Yi Liu
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7637.001.patch
>
>
> Currently the {{.reserved}} patch check function is:
> {code}
> public static boolean isReservedName(String src) {
> return src.startsWith(DOT_RESERVED_PATH_PREFIX);
> }
> {code}
> And {{DOT_RESERVED_PATH_PREFIX}} is {{/.reserved}}, it should be
> {{/.reserved/}}, for example: if some other directory prefix with
> _/.reserved_, we say it's _/.reservedpath_, then the check is wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7637) Fix the check condition for reserved path
[
https://issues.apache.org/jira/browse/HDFS-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283738#comment-14283738
]
Hudson commented on HDFS-7637:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #813 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/813/])
HDFS-7637. Fix the check condition for reserved path. Contributed by Yi Liu.
(jing9: rev e843a0a8cee5c704a5d28cf14b5a4050094d341b)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Fix the check condition for reserved path
> -
>
> Key: HDFS-7637
> URL: https://issues.apache.org/jira/browse/HDFS-7637
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Yi Liu
>Assignee: Yi Liu
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7637.001.patch
>
>
> Currently the {{.reserved}} patch check function is:
> {code}
> public static boolean isReservedName(String src) {
> return src.startsWith(DOT_RESERVED_PATH_PREFIX);
> }
> {code}
> And {{DOT_RESERVED_PATH_PREFIX}} is {{/.reserved}}, it should be
> {{/.reserved/}}, for example: if some other directory prefix with
> _/.reserved_, we say it's _/.reservedpath_, then the check is wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7637) Fix the check condition for reserved path
[
https://issues.apache.org/jira/browse/HDFS-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283684#comment-14283684
]
Hudson commented on HDFS-7637:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #79 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/79/])
HDFS-7637. Fix the check condition for reserved path. Contributed by Yi Liu.
(jing9: rev e843a0a8cee5c704a5d28cf14b5a4050094d341b)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
> Fix the check condition for reserved path
> -
>
> Key: HDFS-7637
> URL: https://issues.apache.org/jira/browse/HDFS-7637
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Yi Liu
>Assignee: Yi Liu
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7637.001.patch
>
>
> Currently the {{.reserved}} patch check function is:
> {code}
> public static boolean isReservedName(String src) {
> return src.startsWith(DOT_RESERVED_PATH_PREFIX);
> }
> {code}
> And {{DOT_RESERVED_PATH_PREFIX}} is {{/.reserved}}, it should be
> {{/.reserved/}}, for example: if some other directory prefix with
> _/.reserved_, we say it's _/.reservedpath_, then the check is wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7637) Fix the check condition for reserved path
[
https://issues.apache.org/jira/browse/HDFS-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283234#comment-14283234
]
Yi Liu commented on HDFS-7637:
--
Thanks [~jingzhao] and [~clamb] for review and commit.
> Fix the check condition for reserved path
> -
>
> Key: HDFS-7637
> URL: https://issues.apache.org/jira/browse/HDFS-7637
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Yi Liu
>Assignee: Yi Liu
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7637.001.patch
>
>
> Currently the {{.reserved}} patch check function is:
> {code}
> public static boolean isReservedName(String src) {
> return src.startsWith(DOT_RESERVED_PATH_PREFIX);
> }
> {code}
> And {{DOT_RESERVED_PATH_PREFIX}} is {{/.reserved}}, it should be
> {{/.reserved/}}, for example: if some other directory prefix with
> _/.reserved_, we say it's _/.reservedpath_, then the check is wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7637) Fix the check condition for reserved path
[
https://issues.apache.org/jira/browse/HDFS-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282828#comment-14282828
]
Hudson commented on HDFS-7637:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6887 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/6887/])
HDFS-7637. Fix the check condition for reserved path. Contributed by Yi Liu.
(jing9: rev e843a0a8cee5c704a5d28cf14b5a4050094d341b)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Fix the check condition for reserved path
> -
>
> Key: HDFS-7637
> URL: https://issues.apache.org/jira/browse/HDFS-7637
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Yi Liu
>Assignee: Yi Liu
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HDFS-7637.001.patch
>
>
> Currently the {{.reserved}} patch check function is:
> {code}
> public static boolean isReservedName(String src) {
> return src.startsWith(DOT_RESERVED_PATH_PREFIX);
> }
> {code}
> And {{DOT_RESERVED_PATH_PREFIX}} is {{/.reserved}}, it should be
> {{/.reserved/}}, for example: if some other directory prefix with
> _/.reserved_, we say it's _/.reservedpath_, then the check is wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7637) Fix the check condition for reserved path
[
https://issues.apache.org/jira/browse/HDFS-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282816#comment-14282816
]
Jing Zhao commented on HDFS-7637:
-
+1. I will commit it shortly.
> Fix the check condition for reserved path
> -
>
> Key: HDFS-7637
> URL: https://issues.apache.org/jira/browse/HDFS-7637
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Yi Liu
>Assignee: Yi Liu
>Priority: Minor
> Attachments: HDFS-7637.001.patch
>
>
> Currently the {{.reserved}} patch check function is:
> {code}
> public static boolean isReservedName(String src) {
> return src.startsWith(DOT_RESERVED_PATH_PREFIX);
> }
> {code}
> And {{DOT_RESERVED_PATH_PREFIX}} is {{/.reserved}}, it should be
> {{/.reserved/}}, for example: if some other directory prefix with
> _/.reserved_, we say it's _/.reservedpath_, then the check is wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7637) Fix the check condition for reserved path
[
https://issues.apache.org/jira/browse/HDFS-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282453#comment-14282453
]
Charles Lamb commented on HDFS-7637:
LGTM [~hitliuyi].
Charles
> Fix the check condition for reserved path
> -
>
> Key: HDFS-7637
> URL: https://issues.apache.org/jira/browse/HDFS-7637
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Yi Liu
>Assignee: Yi Liu
>Priority: Minor
> Attachments: HDFS-7637.001.patch
>
>
> Currently the {{.reserved}} patch check function is:
> {code}
> public static boolean isReservedName(String src) {
> return src.startsWith(DOT_RESERVED_PATH_PREFIX);
> }
> {code}
> And {{DOT_RESERVED_PATH_PREFIX}} is {{/.reserved}}, it should be
> {{/.reserved/}}, for example: if some other directory prefix with
> _/.reserved_, we say it's _/.reservedpath_, then the check is wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7637) Fix the check condition for reserved path
[
https://issues.apache.org/jira/browse/HDFS-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282423#comment-14282423
]
Hadoop QA commented on HDFS-7637:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12693029/HDFS-7637.001.patch
against trunk revision 19cbce3.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9263//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9263//console
This message is automatically generated.
> Fix the check condition for reserved path
> -
>
> Key: HDFS-7637
> URL: https://issues.apache.org/jira/browse/HDFS-7637
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Yi Liu
>Assignee: Yi Liu
>Priority: Minor
> Attachments: HDFS-7637.001.patch
>
>
> Currently the {{.reserved}} patch check function is:
> {code}
> public static boolean isReservedName(String src) {
> return src.startsWith(DOT_RESERVED_PATH_PREFIX);
> }
> {code}
> And {{DOT_RESERVED_PATH_PREFIX}} is {{/.reserved}}, it should be
> {{/.reserved/}}, for example: if some other directory prefix with
> _/.reserved_, we say it's _/.reservedpath_, then the check is wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
