[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-06-06 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575902#comment-14575902
 ] 

Hadoop QA commented on HDFS-8116:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  18m  7s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | javac |   7m 45s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |  10m  1s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m 23s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   3m 15s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native |   3m 15s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 160m 12s | Tests passed in hadoop-hdfs. 
|
| | | 206m 33s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12738141/HDFS-8116-002.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / b3ffa87 |
| hadoop-hdfs test log | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11253/artifact/patchprocess/testrun_hadoop-hdfs.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11253/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11253/console |


This message was automatically generated.

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Affects Versions: 2.7.0
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
> Attachments: HDFS-8116-002.patch, HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-06-05 Thread Xiaoyu Yao (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575615#comment-14575615
 ] 

Xiaoyu Yao commented on HDFS-8116:
--

+1

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Affects Versions: 2.7.0
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
> Attachments: HDFS-8116-002.patch, HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-06-05 Thread Brahma Reddy Battula (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575614#comment-14575614
 ] 

Brahma Reddy Battula commented on HDFS-8116:


[~xyao] Now I attached the correct one..kindly review..

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Affects Versions: 2.7.0
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
> Attachments: HDFS-8116-002.patch, HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-06-05 Thread Xiaoyu Yao (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575605#comment-14575605
 ] 

Xiaoyu Yao commented on HDFS-8116:
--

You may also remove the unnecessary empty line. The fix I would expect is:

{code}
  TopWindow window = new TopWindow(windowLenMs);
  Set metricNames = metricMap.keySet();
  LOG.debug("iterating in reported metrics, size={} values={}",
  metricNames.size(), metricNames);
{code}

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Affects Versions: 2.7.0
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
> Attachments: HDFS-8116-002.patch, HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-06-05 Thread Xiaoyu Yao (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575602#comment-14575602
 ] 

Xiaoyu Yao commented on HDFS-8116:
--

[~brahmareddy], patch 002 seems to be the same as the original patch. Did you 
attach the right patch?

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Affects Versions: 2.7.0
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
> Attachments: HDFS-8116-002.patch, HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-06-05 Thread Brahma Reddy Battula (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575593#comment-14575593
 ] 

Brahma Reddy Battula commented on HDFS-8116:


[~xyao] kindly review!!

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Affects Versions: 2.7.0
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
> Attachments: HDFS-8116-002.patch, HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-06-05 Thread Xiaoyu Yao (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575587#comment-14575587
 ] 

Xiaoyu Yao commented on HDFS-8116:
--

Can you reduce the 2 extra leading spaces of your change? +1 otherwise pending 
Jenkins.

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Affects Versions: 2.7.0
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
>  Labels: BB2015-05-TBR
> Attachments: HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-06-05 Thread Brahma Reddy Battula (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575558#comment-14575558
 ] 

Brahma Reddy Battula commented on HDFS-8116:


[~xyao] agree with you..Kindly review the patch..thanks

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Affects Versions: 2.7.0
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
>  Labels: BB2015-05-TBR
> Attachments: HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-05-27 Thread Xiaoyu Yao (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560992#comment-14560992
 ] 

Xiaoyu Yao commented on HDFS-8116:
--

Just my 2c: I think we should have cleaned it up when switching to SFL4j. If 
there are many other classes with the same issue, we can open separate JIRAs 
for them. This way, we reduce the long term maintenance overhead and avoid new 
contributors following the unnecessary if (isDebugEnabled()) pattern in new 
code. 

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Affects Versions: 2.7.0
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
>  Labels: BB2015-05-TBR
> Attachments: HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-05-27 Thread Vinayakumar B (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560759#comment-14560759
 ] 

Vinayakumar B commented on HDFS-8116:
-

bq. If RollingWindowManager class uses SLF4j which does not need to wrap logs 
in isDebugEnabled(), we should use this consistently to avoid confusion. Should 
we remove the check from RollingWindowManager#snapshot?
I agree that it looks good to be constistent, but there are so many other 
classes also with this kind of coding.
Do we need to change everywhere to be consistent? or leave as is and take care 
in future coding, as there will not be any benefit in performance after change.

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Affects Versions: 2.7.0
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
>  Labels: BB2015-05-TBR
> Attachments: HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-05-08 Thread Brahma Reddy Battula (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534163#comment-14534163
 ] 

Brahma Reddy Battula commented on HDFS-8116:


I think, Performance test might not require..Just for consistency I removed 
LOG.isDebugEnabled().. If I add LOG.isDebugEnabled() before LOG.Debug() ( as 
per defect summary),Then we need to do performance test before and after the 
patch...Please correct me , If I am wrong.. Need to change defect summary..

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Affects Versions: 2.7.0
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
>  Labels: BB2015-05-TBR
> Attachments: HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-05-08 Thread Tsuyoshi Ozawa (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534141#comment-14534141
 ] 

Tsuyoshi Ozawa commented on HDFS-8116:
--

I think we should performance test before and after this fix as [~andrew.wang] 
mentioned.

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Affects Versions: 2.7.0
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
>  Labels: BB2015-05-TBR
> Attachments: HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-04-25 Thread Brahma Reddy Battula (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512645#comment-14512645
 ] 

Brahma Reddy Battula commented on HDFS-8116:


Testcase failures are unrelated to this patch...

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Affects Versions: 2.7.0
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
> Attachments: HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-04-25 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512376#comment-14512376
 ] 

Hadoop QA commented on HDFS-8116:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 32s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | javac |   7m 28s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 34s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   7m 40s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | install |   1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   3m  3s | The patch does not introduce 
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native |   3m 13s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 164m 49s | Tests failed in hadoop-hdfs. |
| | | 212m 53s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12728137/HDFS-8116.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 78c6b46 |
| hadoop-hdfs test log | 
https://builds.apache.org/job/PreCommit-HDFS-Build/10387/artifact/patchprocess/testrun_hadoop-hdfs.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/10387/testReport/ |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/10387/console |


This message was automatically generated.

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Affects Versions: 2.7.0
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
> Attachments: HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-04-24 Thread Brahma Reddy Battula (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512293#comment-14512293
 ] 

Brahma Reddy Battula commented on HDFS-8116:


Kindly review the attached patch!!!

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Affects Versions: 2.7.0
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
> Attachments: HDFS-8116.patch
>
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8116) RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

2015-04-24 Thread Brahma Reddy Battula (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512171#comment-14512171
 ] 

Brahma Reddy Battula commented on HDFS-8116:


[~andrew.wang] ,it's better to remove {{LOG.isDebugEnabled()}} as [~xyao] 
pointed which makes consistency in {{RollingWindowManager}} ..if you agree, i 
will chage defect summary and give patch..

> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 
> -
>
> Key: HDFS-8116
> URL: https://issues.apache.org/jira/browse/HDFS-8116
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Reporter: Xiaoyu Yao
>Assignee: Brahma Reddy Battula
>Priority: Trivial
>
> RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() 
> before LOG.debug() 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)