[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521713#comment-14521713 ] Hudson commented on HDFS-8214: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2129 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2129/]) HDFS-8214. Secondary NN Web UI shows wrong date for Last Checkpoint. Contributed by Charles Lamb. (wang: rev aa22450442ebe39916a6fd460fe97e347945526d) * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNodeInfoMXBean.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Fix For: 2.8.0 > > Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch, > HDFS-8214.003.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521640#comment-14521640 ] Hudson commented on HDFS-8214: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #180 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/180/]) HDFS-8214. Secondary NN Web UI shows wrong date for Last Checkpoint. Contributed by Charles Lamb. (wang: rev aa22450442ebe39916a6fd460fe97e347945526d) * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNodeInfoMXBean.java * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Fix For: 2.8.0 > > Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch, > HDFS-8214.003.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521455#comment-14521455 ] Hudson commented on HDFS-8214: -- FAILURE: Integrated in Hadoop-Yarn-trunk #913 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/913/]) HDFS-8214. Secondary NN Web UI shows wrong date for Last Checkpoint. Contributed by Charles Lamb. (wang: rev aa22450442ebe39916a6fd460fe97e347945526d) * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNodeInfoMXBean.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Fix For: 2.8.0 > > Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch, > HDFS-8214.003.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521409#comment-14521409 ] Hudson commented on HDFS-8214: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #170 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/170/]) HDFS-8214. Secondary NN Web UI shows wrong date for Last Checkpoint. Contributed by Charles Lamb. (wang: rev aa22450442ebe39916a6fd460fe97e347945526d) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNodeInfoMXBean.java > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Fix For: 2.8.0 > > Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch, > HDFS-8214.003.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521399#comment-14521399 ] Hudson commented on HDFS-8214: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #179 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/179/]) HDFS-8214. Secondary NN Web UI shows wrong date for Last Checkpoint. Contributed by Charles Lamb. (wang: rev aa22450442ebe39916a6fd460fe97e347945526d) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNodeInfoMXBean.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Fix For: 2.8.0 > > Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch, > HDFS-8214.003.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521389#comment-14521389 ] Hudson commented on HDFS-8214: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2111 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2111/]) HDFS-8214. Secondary NN Web UI shows wrong date for Last Checkpoint. Contributed by Charles Lamb. (wang: rev aa22450442ebe39916a6fd460fe97e347945526d) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNodeInfoMXBean.java * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Fix For: 2.8.0 > > Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch, > HDFS-8214.003.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520630#comment-14520630 ] Hudson commented on HDFS-8214: -- FAILURE: Integrated in Hadoop-trunk-Commit #7703 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7703/]) HDFS-8214. Secondary NN Web UI shows wrong date for Last Checkpoint. Contributed by Charles Lamb. (wang: rev aa22450442ebe39916a6fd460fe97e347945526d) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNodeInfoMXBean.java * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Fix For: 2.8.0 > > Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch, > HDFS-8214.003.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520624#comment-14520624 ] Andrew Wang commented on HDFS-8214: --- Ah, I see the JIRA has been created, thanks. I'll review as soon as a patch goes up :) > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Fix For: 2.8.0 > > Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch, > HDFS-8214.003.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520616#comment-14520616 ] Andrew Wang commented on HDFS-8214: --- OK, I'll commit this shortly. Thanks for looking at this Haohui, and Charles for the patch. > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch, > HDFS-8214.003.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520613#comment-14520613 ] Charles Lamb commented on HDFS-8214: I created HDFS-8292 for this. > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch, > HDFS-8214.003.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520603#comment-14520603 ] Charles Lamb commented on HDFS-8214: [~wheat9], I'll make the change in a followup-jira. Thanks for the review. > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch, > HDFS-8214.003.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[
https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520056#comment-14520056
]
Haohui Mai commented on HDFS-8214:
--
{code}
+ if (v < 0) {
+return "unknown";
+ }
{code}
It might make more sense to move it to the template (i.e., {{status.html}}), as
the function might later be superseded by moment.js.
> Secondary NN Web UI shows wrong date for Last Checkpoint
>
>
> Key: HDFS-8214
> URL: https://issues.apache.org/jira/browse/HDFS-8214
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: HDFS, namenode
>Affects Versions: 2.7.0
>Reporter: Charles Lamb
>Assignee: Charles Lamb
> Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch,
> HDFS-8214.003.patch
>
>
> SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in
> the web UI. This causes weird times, generally, just after the epoch, to be
> displayed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519304#comment-14519304 ] Charles Lamb commented on HDFS-8214: The test failure is unrelated. The checkstyle issue has already been discussed above. > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch, > HDFS-8214.003.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[
https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518786#comment-14518786
]
Hadoop QA commented on HDFS-8214:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 37s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | javac | 7m 28s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 7m 26s | The applied patch generated 1
additional checkstyle issues. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 5s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 15s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 164m 49s | Tests failed in hadoop-hdfs. |
| | | 212m 47s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.namenode.TestFileTruncate |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12728499/HDFS-8214.003.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 439614b |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/10446/artifact/patchprocess/checkstyle-result-diff.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10446/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10446/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10446/console |
This message was automatically generated.
> Secondary NN Web UI shows wrong date for Last Checkpoint
>
>
> Key: HDFS-8214
> URL: https://issues.apache.org/jira/browse/HDFS-8214
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: HDFS, namenode
>Affects Versions: 2.7.0
>Reporter: Charles Lamb
>Assignee: Charles Lamb
> Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch,
> HDFS-8214.003.patch
>
>
> SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in
> the web UI. This causes weird times, generally, just after the epoch, to be
> displayed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518528#comment-14518528 ] Andrew Wang commented on HDFS-8214: --- +1 LGTM, thanks Charles. I rekicked Jenkins, should come back clean. > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch, > HDFS-8214.003.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515985#comment-14515985 ] Hadoop QA commented on HDFS-8214: - (!) The patch artifact directory on has been removed! This is a fatal error for test-patch.sh. Aborting. Jenkins (node H8) information at https://builds.apache.org/job/PreCommit-HDFS-Build/10417/ may provide some hints. > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch, > HDFS-8214.003.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514585#comment-14514585 ] Andrew Wang commented on HDFS-8214: --- Hi Charles, this patch looks good, only two comments: * Since we return 0 for the delta when no checkpoint has been done, we can't distinguish this situation from a checkpoint having been just completed. We could also check the wallclock time, but so we can interpret the delta in isolation, how about returning a -1 value in this situation instead? * We get the monotonic time before calling doCheckpoint, and set the member variable after it finishes. Could we do the same with the wallclock time for parity? doCheckpoint takes some time, so as is they won't match up quite right. > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[
https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514367#comment-14514367
]
Charles Lamb commented on HDFS-8214:
The test failure is spurious. I ran the failed test (TestDiskspaceQuotaUpdate)
and it passed on my machine.
The checkstyle warning is
{quote}
{quote}
This is because I added the new getLastCheckpointDeltaMs() method. It is
complaining about "public" being redundant. I could remove it, but keeping it
there is maintain the existing style of other getters.
> Secondary NN Web UI shows wrong date for Last Checkpoint
>
>
> Key: HDFS-8214
> URL: https://issues.apache.org/jira/browse/HDFS-8214
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: HDFS, namenode
>Affects Versions: 2.7.0
>Reporter: Charles Lamb
>Assignee: Charles Lamb
> Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch
>
>
> SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in
> the web UI. This causes weird times, generally, just after the epoch, to be
> displayed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[
https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512207#comment-14512207
]
Hadoop QA commented on HDFS-8214:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 26s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | javac | 7m 23s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 38s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 5m 32s | The applied patch generated 1
additional checkstyle issues. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 5s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 14s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 164m 52s | Tests failed in hadoop-hdfs. |
| | | 210m 41s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12728076/HDFS-8214.002.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 4a3dabd |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/10382/artifact/patchprocess/checkstyle-result-diff.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10382/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10382/testReport/ |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10382/console |
This message was automatically generated.
> Secondary NN Web UI shows wrong date for Last Checkpoint
>
>
> Key: HDFS-8214
> URL: https://issues.apache.org/jira/browse/HDFS-8214
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: HDFS, namenode
>Affects Versions: 2.7.0
>Reporter: Charles Lamb
>Assignee: Charles Lamb
> Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch
>
>
> SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in
> the web UI. This causes weird times, generally, just after the epoch, to be
> displayed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511498#comment-14511498 ] Andrew Wang commented on HDFS-8214: --- Hi Charles, This change basically makes sense. We were too zealous when we changed getLastCheckpointTime(), that needs to still be a wallclock time for compatibility purposes. However, we have the option of displaying both the wallclock and the relative time in the 2NN's toString. On the webUI, if we expose the relative time via a new MXBean method, we can again display both. > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Attachments: HDFS-8214.001.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511161#comment-14511161 ] Charles Lamb commented on HDFS-8214: No test is needed since it's just a change to a display message. > Secondary NN Web UI shows wrong date for Last Checkpoint > > > Key: HDFS-8214 > URL: https://issues.apache.org/jira/browse/HDFS-8214 > Project: Hadoop HDFS > Issue Type: Bug > Components: HDFS, namenode >Affects Versions: 2.7.0 >Reporter: Charles Lamb >Assignee: Charles Lamb > Attachments: HDFS-8214.001.patch > > > SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in > the web UI. This causes weird times, generally, just after the epoch, to be > displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
[
https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510778#comment-14510778
]
Hadoop QA commented on HDFS-8214:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 36s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | javac | 7m 29s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 7m 39s | There were no new checkstyle
issues. |
| {color:green}+1{color} | install | 1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 4s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 13s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 167m 8s | Tests passed in hadoop-hdfs.
|
| | | 215m 20s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12727828/HDFS-8214.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 262c1bc |
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10366/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10366/testReport/ |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10366/console |
This message was automatically generated.
> Secondary NN Web UI shows wrong date for Last Checkpoint
>
>
> Key: HDFS-8214
> URL: https://issues.apache.org/jira/browse/HDFS-8214
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: HDFS, namenode
>Affects Versions: 2.7.0
>Reporter: Charles Lamb
>Assignee: Charles Lamb
> Attachments: HDFS-8214.001.patch
>
>
> SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in
> the web UI. This causes weird times, generally, just after the epoch, to be
> displayed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
