[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in NameNode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728481#comment-14728481
]
Surendra Singh Lilhore commented on HDFS-8388:
--
Created new Jira HDFS-9013 to deprecate {{NameNodeMXBean#getNNStarted}} in
branch2 and remove from trunk
> Time and Date format need to be in sync in NameNode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: Surendra Singh Lilhore
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch,
> HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch,
> HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in NameNode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727687#comment-14727687 ] Surendra Singh Lilhore commented on HDFS-8388: -- Thanks [~vinayrpet] and [~wheat9] for the reviews. Thanks [~ajisakaa] for review and commit .. > Time and Date format need to be in sync in NameNode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch, > HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in NameNode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727199#comment-14727199 ] Hudson commented on HDFS-8388: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #324 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/324/]) HDFS-8388. Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3) * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html > Time and Date format need to be in sync in NameNode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch, > HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in NameNode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727168#comment-14727168 ] Hudson commented on HDFS-8388: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2263 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2263/]) HDFS-8388. Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js * hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js > Time and Date format need to be in sync in NameNode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch, > HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in NameNode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726895#comment-14726895 ] Hudson commented on HDFS-8388: -- FAILURE: Integrated in Hadoop-Yarn-trunk #1068 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1068/]) HDFS-8388. Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3) * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html * hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js > Time and Date format need to be in sync in NameNode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch, > HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in NameNode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726875#comment-14726875 ] Hudson commented on HDFS-8388: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2282 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2282/]) HDFS-8388. Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3) * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js * hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java > Time and Date format need to be in sync in NameNode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch, > HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in NameNode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726854#comment-14726854 ] Hudson commented on HDFS-8388: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #341 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/341/]) HDFS-8388. Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js * hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Time and Date format need to be in sync in NameNode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch, > HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in NameNode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726839#comment-14726839 ] Hudson commented on HDFS-8388: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #333 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/333/]) HDFS-8388. Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3) * hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js > Time and Date format need to be in sync in NameNode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch, > HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in NameNode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726799#comment-14726799 ] Hudson commented on HDFS-8388: -- FAILURE: Integrated in Hadoop-trunk-Commit #8385 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8385/]) HDFS-8388. Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3) * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java * hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java > Time and Date format need to be in sync in NameNode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch, > HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726770#comment-14726770 ] Akira AJISAKA commented on HDFS-8388: - +1, the failed tests are not related to the patch. I ran the tests locally and all of them passed. > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch, > HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726746#comment-14726746
]
Akira AJISAKA commented on HDFS-8388:
-
bq. It’s better to handle this in HADOOP-7088. Is it ok ?
I'm okay to do the followings in separate jiras.
* Deprecate {{NameNodeMXBean#getNNStarted}}
* Remove {{NameNodeMXBean#getNNStarted}} from trunk
* HADOOP-7088
* Deprecate {{NameNodeMXBean#getCompileInfo}}
* Remove {{NameNodeMXBean#getCompileInfo}} from trunk
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: Surendra Singh Lilhore
>Priority: Minor
> Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch,
> HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch,
> HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710602#comment-14710602
]
Surendra Singh Lilhore commented on HDFS-8388:
--
Thanks [~vinayrpet] and [~wheat9] for reviews.
Currently {{CompileInfo}} metric contain three values.
1. Compile time.
2. User
3. Branch
Here we need to create three new metrics. It’s better to handle this in
HADOOP-7088.
Is it ok ?
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: Surendra Singh Lilhore
>Priority: Minor
> Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch,
> HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch,
> HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710084#comment-14710084
]
Hadoop QA commented on HDFS-8388:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 22m 34s | Pre-patch trunk has 1 extant
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 50s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 0s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 24s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | site | 3m 3s | Site still builds. |
| {color:red}-1{color} | checkstyle | 2m 30s | The applied patch generated 1
new checkstyle issues (total was 303, now 303). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 30s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 4m 20s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests | 22m 32s | Tests passed in
hadoop-common. |
| {color:red}-1{color} | hdfs tests | 161m 1s | Tests failed in hadoop-hdfs. |
| | | 236m 20s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.blockmanagement.TestNodeCount |
| | hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup |
| | hadoop.hdfs.TestPread |
| | hadoop.hdfs.TestReplaceDatanodeOnFailure |
| | hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer |
| | hadoop.hdfs.TestDFSClientFailover |
| | hadoop.hdfs.server.blockmanagement.TestAvailableSpaceBlockPlacementPolicy
|
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12751980/HDFS-8388-006.patch |
| Optional Tests | site javadoc javac unit findbugs checkstyle |
| git revision | trunk / feaf034 |
| Pre-patch Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/12089/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/12089/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12089/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12089/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/12089/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/12089/console |
This message was automatically generated.
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: Surendra Singh Lilhore
>Priority: Minor
> Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch,
> HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch,
> HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709614#comment-14709614 ] Haohui Mai commented on HDFS-8388: -- I think if we're going down to the route of adding new JMX to make things cleaner, then it might make sense to change the compile string to return a timestamp as well. And it would be nice to remove all these deprecated metrics in trunk. > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch, > HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708960#comment-14708960 ] Vinayakumar B commented on HDFS-8388: - Thanks for the update [~surendrasingh]. bq. These two checkstyles is applicable for all the API available in NameNodeMXBean interface. Do we need to fix these ?? As for as this Jira is concerned, latest update is fine. Though you can raise a follow-up and address in that Jira. ex: HDFS-8620 fixed such issues for ClientProtocol +1, Changes looks good to me. pending jenkins for one final report. [~ajisakaa] and [~wheat9], do you you also want to take a look? > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch, > HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708874#comment-14708874
]
Surendra Singh Lilhore commented on HDFS-8388:
--
Thanks [~vinayrpet] for review.
Attached updated patch , Please review..
bq../hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java:226:3:
Redundant 'public' modifier.
bq../hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java:228:
First sentence should end with a period.
These two checkstyles is applicable for all the API available in
{{NameNodeMXBean}} interface. Do we need to fix these ??
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: Surendra Singh Lilhore
>Priority: Minor
> Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch,
> HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388-006.patch,
> HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708784#comment-14708784
]
Vinayakumar B commented on HDFS-8388:
-
1. {code} var HELPERS = {
'helper_date_tostring' : function (chunk, ctx, bodies, params) {
var value = dust.helpers.tap(params.value, chunk, ctx);
-return chunk.write('' + new Date(Number(value)).toLocaleString());
+return chunk.write('' + moment(Number(v)).format('ddd MMM DD HH:mm:ss
ZZ '));
}
};{code}
Here, {{Number(v)}}, there is no {{v}}. You need to replace with {{value}}.
2. Need to fix 2 checkstyles out of 3 shown
3. You can clean lines with whitespace endings, though this can be done during
commit.
In addition to the above changes, just remove duplicate line in
{{dfshealth.html}}. Its not from this issue, but i think that also can go along
with this patch.
{{
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707565#comment-14707565
]
Hadoop QA commented on HDFS-8388:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 22m 46s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 56s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 48s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | site | 3m 1s | Site still builds. |
| {color:red}-1{color} | checkstyle | 2m 31s | The applied patch generated 3
new checkstyle issues (total was 303, now 305). |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 2 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 29s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 40s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 4m 22s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests | 22m 21s | Tests passed in
hadoop-common. |
| {color:red}-1{color} | hdfs tests | 177m 7s | Tests failed in hadoop-hdfs. |
| | | 252m 29s | |
\\
\\
|| Reason || Tests ||
| Timed out tests | org.apache.hadoop.hdfs.TestPread |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12751718/HDFS-8388-005.patch |
| Optional Tests | site javadoc javac unit findbugs checkstyle |
| git revision | trunk / 22de7c1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/12072/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/12072/artifact/patchprocess/whitespace.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12072/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12072/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/12072/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/12072/console |
This message was automatically generated.
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: Surendra Singh Lilhore
>Priority: Minor
> Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch,
> HDFS-8388-004.patch, HDFS-8388-005.patch, HDFS-8388.patch, HDFS-8388_1.patch,
> ScreenShot-InvalidDate.png
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706512#comment-14706512 ] Surendra Singh Lilhore commented on HDFS-8388: -- Thanks [~vinayrpet] for review bq. I feel, if we are unifying, then unify everywhere. agree? yes I will update the patch. > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388-004.patch, HDFS-8388.patch, HDFS-8388_1.patch, > ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706481#comment-14706481 ] Vinayakumar B commented on HDFS-8388: - Patch looks great. I feel there are some other places in NameNode UI where this unification could be done. ex: Datanode last contact time, file last modification time, datanode volume failure time, etc. I feel, if we are unifying, then unify everywhere. agree? > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388-004.patch, HDFS-8388.patch, HDFS-8388_1.patch, > ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706233#comment-14706233 ] Surendra Singh Lilhore commented on HDFS-8388: -- Thanks [~ajisakaa] for review Attached new patch , Please review... > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388-004.patch, HDFS-8388.patch, HDFS-8388_1.patch, > ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704264#comment-14704264 ] Surendra Singh Lilhore commented on HDFS-8388: -- yes, I will do this and update the patch here soon.. > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704184#comment-14704184
]
Akira AJISAKA commented on HDFS-8388:
-
bq. I didn't see any document for NNStarted, so I didn't added for new metric.
I'm thinking {{NNStarted}} should be documented as well. Would you document
both {{NNStarted}} and the new metric?
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: Surendra Singh Lilhore
>Priority: Minor
> Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch,
> HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693887#comment-14693887
]
Surendra Singh Lilhore commented on HDFS-8388:
--
Thanks [~ajisakaa] for comments..
I didn't see any document for {{NNStarted}}, so I didn't added for new metric.
http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/Metrics.html
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: Surendra Singh Lilhore
>Priority: Minor
> Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch,
> HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693111#comment-14693111
]
Akira AJISAKA commented on HDFS-8388:
-
I'm thinking moment-timezone.js can parse the format by using {{user.timezone}}
property via JMX, however, it needs a lot of work. I prefer adding a new metric
rather than parsing the date. Please correct me if I am wrong.
By the way, v3 patch needs documentation for the new metric.
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: Surendra Singh Lilhore
>Priority: Minor
> Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch,
> HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693005#comment-14693005
]
Akira AJISAKA commented on HDFS-8388:
-
bq. Is it possible to use moment.js to parse the date instead?
No, moment.js cannot parse {{zz}} format. I'll check whether moment-timezone.js
can parse {{zz}}. If it can parse the timezone, we can use it instead of adding
a new metric.
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: Surendra Singh Lilhore
>Priority: Minor
> Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch,
> HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681254#comment-14681254 ] Surendra Singh Lilhore commented on HDFS-8388: -- Thanks [~wheat9] for review... I tried to parse *NNstart* date in *002* patch using moment.js , but some time it is giving "invalid date" message... Please check attached image "ScreenShot-InvalidDate.png". > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680845#comment-14680845 ] Haohui Mai commented on HDFS-8388: -- I wonder why you need to change the JMX? Is it possible to use moment.js to parse the date instead? > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch, > HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680462#comment-14680462
]
Hadoop QA commented on HDFS-8388:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 17m 28s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 45s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 53s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 27s | The applied patch generated 3
new checkstyle issues (total was 305, now 307). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 22s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 2m 33s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 2s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 176m 31s | Tests failed in hadoop-hdfs. |
| | | 221m 0s | |
\\
\\
|| Reason || Tests ||
| Timed out tests | org.apache.hadoop.cli.TestHDFSCLI |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12749600/HDFS-8388-003.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 8f73bdd |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/11952/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11952/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11952/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11952/console |
This message was automatically generated.
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: Surendra Singh Lilhore
>Priority: Minor
> Attachments: HDFS-8388-002.patch, HDFS-8388-003.patch,
> HDFS-8388.patch, HDFS-8388_1.patch, ScreenShot-InvalidDate.png
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659897#comment-14659897
]
Akira AJISAKA commented on HDFS-8388:
-
Thanks [~surendrasingh] for the comment. I'm thinking we should convert the
started time to ZZ (ex. +0530) to be sync. Javascript does not support timezone
correctly and that's why moment.js "zz" format support is deprecated.
We cannot change the format of {{NNStarted}} metric for keeping compatibility,
so we need to create a new metric such as {{NNStartedTimeInMillis}} and parse
it by moment.js.
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: Surendra Singh Lilhore
>Priority: Minor
> Attachments: HDFS-8388-002.patch, HDFS-8388.patch, HDFS-8388_1.patch,
> ScreenShot-InvalidDate.png
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647452#comment-14647452
]
Surendra Singh Lilhore commented on HDFS-8388:
--
Thanks [~ajisakaa] for review..
bq. 2. Would you use "ddd MMM DD HH:mm:ss ZZ " format instead of "ddd MMM
DD HH:mm:ss " to be consistent with YARN Web UI?
If I use "ddd MMM DD HH:mm:ss ZZ " format then "Block Deletion Start Time"
and "Compiled" time is coming like this
{noformat}
Compiled: Mon Jul 06 12:20:00 +0530 2015 by sslilhore from trunk
Block Deletion Start Time: Thu Jul 30 14:31:30 +0530 2015
{noformat}
and Started time is like this
{noformat}
Started:Thu Jul 30 17:01:30 CST 2015
{noformat}
here Compiled time zone is "+0530" but Started time zone is "CST".
is this ok ??
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: Surendra Singh Lilhore
>Priority: Minor
> Attachments: HDFS-8388-002.patch, HDFS-8388.patch, HDFS-8388_1.patch,
> ScreenShot-InvalidDate.png
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642351#comment-14642351 ] Akira AJISAKA commented on HDFS-8388: - bq. 1. Started time looks invalid. Would you fix it? Started time is already rendered by Date.toString(), so I'm thinking we don't need to re-format by moment.js. I have an additional comment: Would you use moment.min.js instead of moment.js to minimize the source code as HDFS-8816? > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Attachments: HDFS-8388-002.patch, HDFS-8388.patch, HDFS-8388_1.patch, > ScreenShot-InvalidDate.png > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642325#comment-14642325 ] Akira AJISAKA commented on HDFS-8388: - Thanks [~surendrasingh] for updating the patch. Two comments from me. 1. Started time looks invalid. Would you fix it? 2. Would you use "ddd MMM DD HH:mm:ss ZZ " format instead of "ddd MMM DD HH:mm:ss " to be consistent with YARN Web UI? > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Attachments: HDFS-8388-002.patch, HDFS-8388.patch, HDFS-8388_1.patch > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621924#comment-14621924
]
Hadoop QA commented on HDFS-8388:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 54s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 37s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 44s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 22s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | native | 3m 5s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 160m 53s | Tests passed in hadoop-hdfs.
|
| | | 198m 34s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12744632/HDFS-8388-002.patch |
| Optional Tests | javadoc javac unit |
| git revision | trunk / 1a0752d |
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11652/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11652/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11652/console |
This message was automatically generated.
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: Surendra Singh Lilhore
>Priority: Minor
> Attachments: HDFS-8388-002.patch, HDFS-8388.patch, HDFS-8388_1.patch
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621700#comment-14621700 ] Surendra Singh Lilhore commented on HDFS-8388: -- Thanks [~ajisakaa] for reviewing... Attached updated patch.. Please review. > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Attachments: HDFS-8388-002.patch, HDFS-8388.patch, HDFS-8388_1.patch > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621647#comment-14621647
]
Akira AJISAKA commented on HDFS-8388:
-
One comment from me.
bq. The applied patch generated 1 release audit warnings.
We need to add a line to the pom.xml not to check moment.js.
{code:title=hadoop-hdfs-project/hadoop-hdfs/pom.xml}
org.apache.rat
apache-rat-plugin
CHANGES.txt
...
{code}
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: Surendra Singh Lilhore
>Priority: Minor
> Attachments: HDFS-8388.patch, HDFS-8388_1.patch
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Auto-Re: [jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
您的邮件已收到！谢谢！
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610745#comment-14610745 ] Surendra Singh Lilhore commented on HDFS-8388: -- [~ajisakaa] and [~wheat9] , Would you please review ? :) > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: Surendra Singh Lilhore >Priority: Minor > Attachments: HDFS-8388.patch, HDFS-8388_1.patch > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585732#comment-14585732
]
Hadoop QA commented on HDFS-8388:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 0m 0s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | release audit | 0m 16s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| | | 0m 21s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12739584/HDFS-8388_1.patch |
| Optional Tests | |
| git revision | trunk / 4c5da9b |
| Release Audit |
https://builds.apache.org/job/PreCommit-HDFS-Build/11356/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11356/console |
This message was automatically generated.
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: surendra singh lilhore
>Priority: Minor
> Attachments: HDFS-8388.patch, HDFS-8388_1.patch
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585731#comment-14585731
]
surendra singh lilhore commented on HDFS-8388:
--
Thanks [~ajisakaa] and [~wheat9] for suggestion.
I attached new patch, Please review...
Now this patch will format date in local time zone and display like this:
{code}
Started:Tue Jun 16 04:53:21 2015
Compiled: Tue Jun 02 12:40:00 2015 by xyz from Unknown
Block Deletion Start Time Mon Jun 15 14:53:21 2015
{code}
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: surendra singh lilhore
>Priority: Minor
> Attachments: HDFS-8388.patch, HDFS-8388_1.patch
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584634#comment-14584634 ] Akira AJISAKA commented on HDFS-8388: - Thanks [~wheat9]. Using dedicated library like [moment.js|http://momentjs.com/] seems better than implementing it. > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: surendra singh lilhore >Priority: Minor > Attachments: HDFS-8388.patch > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584611#comment-14584611 ] Haohui Mai commented on HDFS-8388: -- The formatting should be fully done in the client side instead of server side due to complications such as locale and DST. A robust solution should use dedicated library like moment.hs > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: surendra singh lilhore >Priority: Minor > Attachments: HDFS-8388.patch > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584607#comment-14584607
]
Akira AJISAKA commented on HDFS-8388:
-
Thanks [~surendrasingh] for taking this issue.
{code}
@Override
- public long getBlockDeletionStartTime() {
-return startTime + blockManager.getStartupDelayBlockDeletionInMs();
+ public String getBlockDeletionStartTime() {
+return Time.DATEFORMAT.get().format(
+new Date(startTime + blockManager.getStartupDelayBlockDeletionInMs()));
}
{code}
{code}
@Override // NameNodeMXBean
public String getNNStarted() {
-return getStartTime().toString();
+return Time.DATEFORMAT.get().format(new Date(startTime));
}
{code}
I'm thinking changing the return value of these method is incompatible because
the method is used for metrics and JMX.
http://hadoop.apache.org/docs/r2.7.0/hadoop-project-dist/hadoop-common/Compatibility.html#MetricsJMX
Would you fix the formatting in {{helper_date_tostring}} of {{dfshealth.js}}?
I've implemented similar function in YARN WebUI by YARN-570, so you can re-use
the code.
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: surendra singh lilhore
>Priority: Minor
> Attachments: HDFS-8388.patch
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[
https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572649#comment-14572649
]
Hadoop QA commented on HDFS-8388:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 20m 23s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 43s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 58s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 22s | The applied patch generated 2
new checkstyle issues (total was 2, now 4). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 38s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 5m 48s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests | 23m 43s | Tests passed in
hadoop-common. |
| {color:green}+1{color} | maven tests | 0m 13s | Tests passed in
hadoop-maven-plugins. |
| {color:green}+1{color} | hdfs tests | 164m 34s | Tests passed in hadoop-hdfs.
|
| | | 237m 55s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12735549/HDFS-8388.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / e830207 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/11229/artifact/patchprocess/diffcheckstylehadoop-common.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11229/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-maven-plugins test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11229/artifact/patchprocess/testrun_hadoop-maven-plugins.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11229/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11229/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11229/console |
This message was automatically generated.
> Time and Date format need to be in sync in Namenode UI page
> ---
>
> Key: HDFS-8388
> URL: https://issues.apache.org/jira/browse/HDFS-8388
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Archana T
>Assignee: surendra singh lilhore
>Priority: Minor
> Attachments: HDFS-8388.patch
>
>
> In NameNode UI Page, Date and Time FORMAT displayed on the page are not in
> sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59
> Block Deletion Start Time 13 May 2015 12:28:02
> We can keep a common format in all the above places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
[ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560625#comment-14560625 ] surendra singh lilhore commented on HDFS-8388: -- Attached patch , Please review... > Time and Date format need to be in sync in Namenode UI page > --- > > Key: HDFS-8388 > URL: https://issues.apache.org/jira/browse/HDFS-8388 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Archana T >Assignee: surendra singh lilhore >Priority: Minor > Attachments: HDFS-8388.patch > > > In NameNode UI Page, Date and Time FORMAT displayed on the page are not in > sync currently. > Started:Wed May 13 12:28:02 IST 2015 > Compiled:23 Apr 2015 12:22:59 > Block Deletion Start Time 13 May 2015 12:28:02 > We can keep a common format in all the above places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
