[jira] [Commented] (HDFS-8422) Recursive mkdir removes sticky bit when adding implicit u+wx to intermediate directories
[
https://issues.apache.org/jira/browse/HDFS-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713343#comment-15713343
]
Hadoop QA commented on HDFS-8422:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
1s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
58s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
51s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
47s{color} | {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
48s{color} | {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 48s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 24s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch
generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
46s{color} | {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
17s{color} | {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 48s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 19m 40s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | HDFS-8422 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12733633/HDFS-8422.002.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 11092f39987b 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18
21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 19f373a |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| findbugs |
https://builds.apache.org/job/PreCommit-HDFS-Build/17734/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HDFS-Build/17734/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HDFS-Build/17734/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HDFS-Build/17734/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/17734/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HDFS-Build/17734/artifact/patchprocess/patch-
[jira] [Commented] (HDFS-8422) Recursive mkdir removes sticky bit when adding implicit u+wx to intermediate directories
[
https://issues.apache.org/jira/browse/HDFS-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713281#comment-15713281
]
David Tucker commented on HDFS-8422:
Jake should probably be unassigned from this issue.
> Recursive mkdir removes sticky bit when adding implicit u+wx to intermediate
> directories
>
>
> Key: HDFS-8422
> URL: https://issues.apache.org/jira/browse/HDFS-8422
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.7.0
>Reporter: Jake Low
>Assignee: Jake Low
>Priority: Minor
> Attachments: HDFS-8422.001.patch, HDFS-8422.002.patch
>
>
> When performing a recursive {{mkdirs}} operation, the NameNode takes the
> provided {{FsPermission}} and applies it to the final directory that is
> created. The NameNode also uses these permissions when creating intermediate
> directories, except it promotes with {{u+wx}} (i.e. {{mode |= 0300}}) in
> order to ensure that there are sufficient permissions on the new directory to
> create further subdirectories within it.
> Currently the code that does this permission promotion uses the
> three-argument {{FsPermission}} constructor, which sets the sticky bit to
> {{false}}. I think this is probably not the intended behaviour, so I'm
> opening a bug. I'll attach a patch shortly that changes the behaviour so that
> the sticky bit is always retained.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-8422) Recursive mkdir removes sticky bit when adding implicit u+wx to intermediate directories
[
https://issues.apache.org/jira/browse/HDFS-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549367#comment-14549367
]
Hadoop QA commented on HDFS-8422:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 45s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:red}-1{color} | javac | 1m 57s | The patch appears to cause the
build to fail. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12733633/HDFS-8422.002.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 0790275 |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11039/console |
This message was automatically generated.
> Recursive mkdir removes sticky bit when adding implicit u+wx to intermediate
> directories
>
>
> Key: HDFS-8422
> URL: https://issues.apache.org/jira/browse/HDFS-8422
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.7.0
>Reporter: Jake Low
>Assignee: Jake Low
>Priority: Minor
> Attachments: HDFS-8422.001.patch, HDFS-8422.002.patch
>
>
> When performing a recursive {{mkdirs}} operation, the NameNode takes the
> provided {{FsPermission}} and applies it to the final directory that is
> created. The NameNode also uses these permissions when creating intermediate
> directories, except it promotes with {{u+wx}} (i.e. {{mode |= 0300}}) in
> order to ensure that there are sufficient permissions on the new directory to
> create further subdirectories within it.
> Currently the code that does this permission promotion uses the
> three-argument {{FsPermission}} constructor, which sets the sticky bit to
> {{false}}. I think this is probably not the intended behaviour, so I'm
> opening a bug. I'll attach a patch shortly that changes the behaviour so that
> the sticky bit is always retained.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8422) Recursive mkdir removes sticky bit when adding implicit u+wx to intermediate directories
[
https://issues.apache.org/jira/browse/HDFS-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549251#comment-14549251
]
Hadoop QA commented on HDFS-8422:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 8s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:red}-1{color} | javac | 1m 56s | The patch appears to cause the
build to fail. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12733623/HDFS-8422.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 0790275 |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11036/console |
This message was automatically generated.
> Recursive mkdir removes sticky bit when adding implicit u+wx to intermediate
> directories
>
>
> Key: HDFS-8422
> URL: https://issues.apache.org/jira/browse/HDFS-8422
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.7.0
>Reporter: Jake Low
>Assignee: Jake Low
>Priority: Minor
> Attachments: HDFS-8422.001.patch
>
>
> When performing a recursive {{mkdirs}} operation, the NameNode takes the
> provided {{FsPermission}} and applies it to the final directory that is
> created. The NameNode also uses these permissions when creating intermediate
> directories, except it promotes with {{u+wx}} (i.e. {{mode |= 0300}}) in
> order to ensure that there are sufficient permissions on the new directory to
> create further subdirectories within it.
> Currently the code that does this permission promotion uses the
> three-argument {{FsPermission}} constructor, which sets the sticky bit to
> {{false}}. I think this is probably not the intended behaviour, so I'm
> opening a bug. I'll attach a patch shortly that changes the behaviour so that
> the sticky bit is always retained.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
