[jira] [Commented] (HDFS-8448) Create REST Interface for Volumes

2018-04-26 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454928#comment-16454928
 ] 

Hudson commented on HDFS-8448:
--

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14070 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14070/])
HDFS-8448. Create REST Interface for Volumes. Contributed by Anu (omalley: rev 
2ea29ee062f6f4e6313e0d767e50d1d9e7d7c60a)
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/headers/Header.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/interfaces/StorageHandler.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/exceptions/OzoneException.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/handlers/VolumeArgs.java
* (edit) hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-7240.txt
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/response/ListVolumes.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/response/VolumeInfo.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/handlers/UserArgs.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/response/VolumeOwner.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/interfaces/Volume.java


> Create REST Interface for Volumes
> -
>
> Key: HDFS-8448
> URL: https://issues.apache.org/jira/browse/HDFS-8448
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
> Fix For: HDFS-7240
>
> Attachments: hdfs-8448-HDFS-7240.003.patch, 
> hdfs-8448-HDFS-7240.004.patch, hdfs-8448-hdfs-7240.001.patch, 
> hdfs-8448-hdfs-7240.002.patch
>
>
> Create REST interfaces as specified in the architecture document.
> This Jira is for creating the Volume Interface



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-8448) Create REST Interface for Volumes

2018-04-24 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450485#comment-16450485
 ] 

Hudson commented on HDFS-8448:
--

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14057/])
HDFS-8448. Create REST Interface for Volumes. Contributed by Anu (arp: rev 
f0b2b26c34fd703b03eebad146b1ed685285dc7f)
* (edit) hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-7240.txt
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/handlers/UserArgs.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/response/VolumeOwner.java
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/headers/Header.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/interfaces/Volume.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/exceptions/OzoneException.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/handlers/VolumeArgs.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/interfaces/StorageHandler.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/response/ListVolumes.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/response/VolumeInfo.java


> Create REST Interface for Volumes
> -
>
> Key: HDFS-8448
> URL: https://issues.apache.org/jira/browse/HDFS-8448
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
> Fix For: HDFS-7240
>
> Attachments: hdfs-8448-HDFS-7240.003.patch, 
> hdfs-8448-HDFS-7240.004.patch, hdfs-8448-hdfs-7240.001.patch, 
> hdfs-8448-hdfs-7240.002.patch
>
>
> Create REST interfaces as specified in the architecture document.
> This Jira is for creating the Volume Interface



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-8448) Create REST Interface for Volumes

2015-06-20 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594542#comment-14594542
 ] 

Hadoop QA commented on HDFS-8448:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  15m 37s | Findbugs (version ) appears to 
be broken on HDFS-7240. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | javac |   7m 45s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |  10m  1s | There were no new javadoc 
warning messages. |
| {color:red}-1{color} | release audit |   0m 18s | The applied patch generated 
1 release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 49s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   3m 26s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native |   3m 17s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 161m 11s | Tests failed in hadoop-hdfs. |
| | | 204m 37s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.TestSetrepIncreasing |
|   | hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes |
|   | hadoop.hdfs.tools.TestDFSAdmin |
|   | hadoop.hdfs.crypto.TestHdfsCryptoStreams |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12740734/hdfs-8448-HDFS-7240.004.patch
 |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | HDFS-7240 / a229f69 |
| Release Audit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11420/artifact/patchprocess/patchReleaseAuditProblems.txt
 |
| hadoop-hdfs test log | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11420/artifact/patchprocess/testrun_hadoop-hdfs.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11420/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11420/console |


This message was automatically generated.

 Create REST Interface for Volumes
 -

 Key: HDFS-8448
 URL: https://issues.apache.org/jira/browse/HDFS-8448
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Anu Engineer
Assignee: Anu Engineer
 Attachments: hdfs-8448-HDFS-7240.003.patch, 
 hdfs-8448-HDFS-7240.004.patch, hdfs-8448-hdfs-7240.001.patch, 
 hdfs-8448-hdfs-7240.002.patch


 Create REST interfaces as specified in the architecture document.
 This Jira is for creating the Volume Interface



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8448) Create REST Interface for Volumes

2015-06-20 Thread Anu Engineer (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594692#comment-14594692
 ] 

Anu Engineer commented on HDFS-8448:


test failures are not related to this patch.

 Create REST Interface for Volumes
 -

 Key: HDFS-8448
 URL: https://issues.apache.org/jira/browse/HDFS-8448
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Anu Engineer
Assignee: Anu Engineer
 Attachments: hdfs-8448-HDFS-7240.003.patch, 
 hdfs-8448-HDFS-7240.004.patch, hdfs-8448-hdfs-7240.001.patch, 
 hdfs-8448-hdfs-7240.002.patch


 Create REST interfaces as specified in the architecture document.
 This Jira is for creating the Volume Interface



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8448) Create REST Interface for Volumes

2015-06-19 Thread Chris Nauroth (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593759#comment-14593759
 ] 

Chris Nauroth commented on HDFS-8448:
-

Hi [~anu].  This patch looks pretty good!  I have just a few minor suggestions.

# Can we remove the default constructor in {{OzoneException}}?  In general, 
it's better practice to build an exception with a descriptive message and 
optionally a root cause exception.  If a default constructor is available, then 
it might encourage writing code that doesn't provide a descriptive message.
# Do you think it makes sense for the *Args classes to be made immutable by 
moving all member initialization into the constructors and removing the setter 
methods?
# In general, there are inaccuracies in JavaDoc.  I saw missing parameters or 
incorrect parameters in several of the classes.  test-patch will catch these 
during the JavaDoc check, or you could review manually now.

BTW, I just heard from Apache infrastructure that Jenkins got really backed up. 
 Jobs are flowing now, but it might take a while sitting in the queue.


 Create REST Interface for Volumes
 -

 Key: HDFS-8448
 URL: https://issues.apache.org/jira/browse/HDFS-8448
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Anu Engineer
Assignee: Anu Engineer
 Attachments: hdfs-8448-HDFS-7240.003.patch, 
 hdfs-8448-hdfs-7240.001.patch, hdfs-8448-hdfs-7240.002.patch


 Create REST interfaces as specified in the architecture document.
 This Jira is for creating the Volume Interface



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8448) Create REST Interface for Volumes

2015-06-19 Thread Anu Engineer (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593793#comment-14593793
 ] 

Anu Engineer commented on HDFS-8448:


Thanks [~cnauroth] for the review.

bq.Can we remove the default constructor in OzoneException? In general, it's 
better practice to build an exception with a descriptive message and optionally 
a root cause exception. If a default constructor is available, then it might 
encourage writing code that doesn't provide a descriptive message

We serialize and deserialize this using jackson, hence the default constructor. 
I will check if it works correctly if we remove this.

bq. Do you think it makes sense for the *Args classes to be made immutable by 
moving all member initialization into the constructors and removing the setter 
methods?

The way we use *Args make it slightly hard to make it immutable. I can do it 
for a large number of fields, but one field - the userName in the UserArgs is 
an exception. The reason is that we create userArgs with requestID and hostname 
and then pass that to userAuth Interface and ask the Auth interface to return a 
user name. it is possible that call will fail at that location, then end user 
will get a request ID for the call that was made with appropriate error code - 
in this case for missing user name. if we get a valid user name we set that to 
userArgs and then call the underlying file system.

However I can make a large number of those fields immutable and I will do so.

bq. In general, there are inaccuracies in JavaDoc. I saw missing parameters or 
incorrect parameters in several of the classes. test-patch will catch these 
during the JavaDoc check, or you could review manually now.

Thanks for the catch, I will clean up the javadoc in the next patch.



 Create REST Interface for Volumes
 -

 Key: HDFS-8448
 URL: https://issues.apache.org/jira/browse/HDFS-8448
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Anu Engineer
Assignee: Anu Engineer
 Attachments: hdfs-8448-HDFS-7240.003.patch, 
 hdfs-8448-hdfs-7240.001.patch, hdfs-8448-hdfs-7240.002.patch


 Create REST interfaces as specified in the architecture document.
 This Jira is for creating the Volume Interface



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8448) Create REST Interface for Volumes

2015-06-18 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592717#comment-14592717
 ] 

Hadoop QA commented on HDFS-8448:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch |   0m  0s | The patch command could not apply 
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12740428/hdfs-8448-hdfs-7240.002.patch
 |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 5b5bb8d |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11408/console |


This message was automatically generated.

 Create REST Interface for Volumes
 -

 Key: HDFS-8448
 URL: https://issues.apache.org/jira/browse/HDFS-8448
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Anu Engineer
Assignee: Anu Engineer
 Attachments: hdfs-8448-hdfs-7240.001.patch, 
 hdfs-8448-hdfs-7240.002.patch


 Create REST interfaces as specified in the architecture document.
 This Jira is for creating the Volume Interface



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8448) Create REST Interface for Volumes

2015-06-18 Thread Anu Engineer (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592725#comment-14592725
 ] 

Anu Engineer commented on HDFS-8448:


No idea why this patch failed to apply. It applies to the top of the tree 
cleanly on my machine. The console output link is also timing out. I suspect a 
build outage.



 Create REST Interface for Volumes
 -

 Key: HDFS-8448
 URL: https://issues.apache.org/jira/browse/HDFS-8448
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Anu Engineer
Assignee: Anu Engineer
 Attachments: hdfs-8448-hdfs-7240.001.patch, 
 hdfs-8448-hdfs-7240.002.patch


 Create REST interfaces as specified in the architecture document.
 This Jira is for creating the Volume Interface



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8448) Create REST Interface for Volumes

2015-06-18 Thread Anu Engineer (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592732#comment-14592732
 ] 

Anu Engineer commented on HDFS-8448:


looks like https://builds.apache.org is down. I will follow up in  a while.

 Create REST Interface for Volumes
 -

 Key: HDFS-8448
 URL: https://issues.apache.org/jira/browse/HDFS-8448
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Anu Engineer
Assignee: Anu Engineer
 Attachments: hdfs-8448-hdfs-7240.001.patch, 
 hdfs-8448-hdfs-7240.002.patch


 Create REST interfaces as specified in the architecture document.
 This Jira is for creating the Volume Interface



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8448) Create REST Interface for Volumes

2015-05-22 Thread Chris Nauroth (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556833#comment-14556833
 ] 

Chris Nauroth commented on HDFS-8448:
-

Hi Anu.  This is looking great overall!

I'd like to suggest that we split this patch up into a few separate jiras for 
smaller, more focused reviews.  Maybe a natural way to do this would be to 
split along high-level functional areas, like volumes, buckets and keys.  (i.e. 
{{BucketArgs}} wouldn't show up in the volumes patch.)

 Create REST Interface for Volumes
 -

 Key: HDFS-8448
 URL: https://issues.apache.org/jira/browse/HDFS-8448
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Anu Engineer
Assignee: Anu Engineer
 Attachments: hdfs-8448-hdfs-7240.001.patch


 Create REST interfaces as specified in the architecture document.
 This Jira is for creating the Volume Interface



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-8448) Create REST Interface for Volumes

2015-05-20 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553555#comment-14553555
 ] 

Hadoop QA commented on HDFS-8448:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  15m 17s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 10 new or modified test files. |
| {color:green}+1{color} | javac |   7m 52s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |  10m  2s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 25s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   2m 20s | The applied patch generated  
272 new checkstyle issues (total was 0, now 272). |
| {color:green}+1{color} | shellcheck |   0m  6s | There were no new shellcheck 
(v0.3.3) issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 34s | The patch built with 
eclipse:eclipse. |
| {color:red}-1{color} | findbugs |   0m 30s | The patch appears to cause 
Findbugs (version ) to fail. |
| {color:green}+1{color} | native |   3m 14s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests |   0m 31s | Tests failed in hadoop-hdfs. |
| | |  42m 33s | |
\\
\\
|| Reason || Tests ||
| Failed build | hadoop-hdfs |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12734300/hdfs-8448-hdfs-7240.001.patch
 |
| Optional Tests | javadoc javac unit findbugs checkstyle shellcheck |
| git revision | trunk / 6329bd0 |
| checkstyle |  
https://builds.apache.org/job/PreCommit-HDFS-Build/11067/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
 |
| hadoop-hdfs test log | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11067/artifact/patchprocess/testrun_hadoop-hdfs.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11067/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11067/console |


This message was automatically generated.

 Create REST Interface for Volumes
 -

 Key: HDFS-8448
 URL: https://issues.apache.org/jira/browse/HDFS-8448
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Anu Engineer
Assignee: Anu Engineer
 Attachments: hdfs-8448-hdfs-7240.001.patch


 Create REST interfaces as specified in the architecture document.
 This Jira is for creating the Volume Interface



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)