[jira] [Commented] (HDFS-8469) Lockfiles are not being created for datanode storage directories
[
https://issues.apache.org/jira/browse/HDFS-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805913#comment-15805913
]
Hadoop QA commented on HDFS-8469:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} HDFS-8469 does not apply to trunk. Rebase required? Wrong Branch?
See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-8469 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12734900/HDFS-8469.001.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/18061/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Lockfiles are not being created for datanode storage directories
>
>
> Key: HDFS-8469
> URL: https://issues.apache.org/jira/browse/HDFS-8469
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
>Affects Versions: 2.4.0
>Reporter: Colin P. McCabe
>Assignee: Colin P. McCabe
> Attachments: HDFS-8469.001.patch
>
>
> Lockfiles are not being created for datanode storage directories. Due to a
> mixup, we are initializing the StorageDirectory class with shared=true (an
> option which was only intended for NFS directories used to implement NameNode
> HA). Setting shared=true disables lockfile generation and prints a log
> message like this:
> {code}
> 2015-05-22 11:45:16,367 INFO common.Storage (Storage.java:lock(675)) -
> Locking is disabled for
> /home/cmccabe/hadoop2/hadoop-hdfs-project/hadoop-hdfs/target/
> test/data/dfs/data/data5/current/BP-122766180-127.0.0.1-1432320314834
> {code}
> Without lock files, we could accidentally spawn two datanode processes using
> the same directories without realizing it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-8469) Lockfiles are not being created for datanode storage directories
[
https://issues.apache.org/jira/browse/HDFS-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14587238#comment-14587238
]
Hadoop QA commented on HDFS-8469:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 18m 19s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 51s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 45s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 26s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 2m 31s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 2m 0s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 43s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 4m 3s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 4m 14s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 136m 25s | Tests failed in hadoop-hdfs. |
| | | 187m 21s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead |
| | hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes |
| | hadoop.hdfs.server.namenode.TestFileContextAcl |
| | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS |
| | hadoop.hdfs.web.TestWebHDFSXAttr |
| | hadoop.hdfs.server.blockmanagement.TestNodeCount |
| | hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks |
| | hadoop.hdfs.TestDatanodeRegistration |
| | hadoop.hdfs.web.TestWebHDFSAcl |
| | hadoop.hdfs.TestFileCreationDelete |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart |
| | hadoop.hdfs.TestSafeMode |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestWriteToReplica |
| | hadoop.hdfs.server.blockmanagement.TestNameNodePrunesMissingStorages |
| | hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation |
| | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration |
| | hadoop.hdfs.TestDecommission |
| | hadoop.hdfs.TestEncryptionZonesWithKMS |
| | hadoop.hdfs.TestSetTimes |
| | hadoop.hdfs.server.datanode.TestBlockScanner |
| | hadoop.hdfs.server.namenode.TestXAttrConfigFlag |
| | hadoop.hdfs.TestRestartDFS |
| | hadoop.hdfs.TestRollingUpgrade |
| | hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks |
| | hadoop.hdfs.TestDataTransferKeepalive |
| | hadoop.hdfs.TestRenameWhileOpen |
| | hadoop.hdfs.TestDFSClientExcludedNodes |
| | hadoop.hdfs.TestFileCreation |
| | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting |
| | hadoop.hdfs.TestDFSShell |
| | hadoop.hdfs.server.namenode.TestProcessCorruptBlocks |
| | hadoop.hdfs.TestDistributedFileSystem |
| | hadoop.hdfs.server.namenode.TestNameNodeAcl |
| | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
|
| | hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade |
| | hadoop.hdfs.TestLeaseRecovery |
| Timed out tests | org.apache.hadoop.hdfs.TestReplication |
| | org.apache.hadoop.hdfs.TestPread |
| | org.apache.hadoop.hdfs.qjournal.client.TestQJMWithFaults |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12734900/HDFS-8469.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 04c9a07 |
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11362/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11362/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11362/console |
This message was automatically generated.
Lockfiles are not being created for datanode storage directories
Key: HDFS-8469
URL: https://issues.apache.org/jira/browse/HDFS-8469
Project: Hadoop HDFS
Issue Type: Bug
[jira] [Commented] (HDFS-8469) Lockfiles are not being created for datanode storage directories
[
https://issues.apache.org/jira/browse/HDFS-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14557178#comment-14557178
]
Aaron T. Myers commented on HDFS-8469:
--
Agree, seems unintentional. It'd be pretty difficult to inadvertently start up
two DNs on the same host, since they'll likely try to bind to the same
RPC/HTTP/DTP ports and fail, but still seems like we should fix this anyway, if
only to get rid of the warning message.
Lockfiles are not being created for datanode storage directories
Key: HDFS-8469
URL: https://issues.apache.org/jira/browse/HDFS-8469
Project: Hadoop HDFS
Issue Type: Bug
Components: datanode
Affects Versions: 2.4.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Attachments: HDFS-8469.001.patch
Lockfiles are not being created for datanode storage directories. Due to a
mixup, we are initializing the StorageDirectory class with shared=true (an
option which was only intended for NFS directories used to implement NameNode
HA). Setting shared=true disables lockfile generation and prints a log
message like this:
{code}
2015-05-22 11:45:16,367 INFO common.Storage (Storage.java:lock(675)) -
Locking is disabled for
/home/cmccabe/hadoop2/hadoop-hdfs-project/hadoop-hdfs/target/
test/data/dfs/data/data5/current/BP-122766180-127.0.0.1-1432320314834
{code}
Without lock files, we could accidentally spawn two datanode processes using
the same directories without realizing it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8469) Lockfiles are not being created for datanode storage directories
[
https://issues.apache.org/jira/browse/HDFS-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14557036#comment-14557036
]
Hadoop QA commented on HDFS-8469:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 37s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 35s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 37s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 2m 13s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 3s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 12s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 255m 53s | Tests failed in hadoop-hdfs. |
| | | 298m 42s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.TestLeaseRecovery |
| | hadoop.hdfs.server.namenode.snapshot.TestSnapshot |
| | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting |
| | hadoop.hdfs.TestSafeMode |
| | hadoop.hdfs.server.namenode.TestNamenodeCapacityReport |
| | hadoop.hdfs.TestDatanodeRegistration |
| | hadoop.hdfs.TestSetTimes |
| | hadoop.hdfs.TestEncryptedTransfer |
| | hadoop.hdfs.server.namenode.TestNameEditsConfigs |
| | hadoop.net.TestNetworkTopology |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestWriteToReplica |
| | hadoop.hdfs.server.namenode.TestFSImage |
| | hadoop.hdfs.server.namenode.TestCheckpoint |
| | hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead |
| | hadoop.hdfs.server.namenode.TestFSImageWithSnapshot |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart |
| | hadoop.hdfs.TestDecommission |
| | hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks |
| | hadoop.hdfs.server.namenode.TestParallelImageWrite |
| | hadoop.hdfs.server.blockmanagement.TestNameNodePrunesMissingStorages |
| | hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation |
| | hadoop.fs.permission.TestStickyBit |
| | hadoop.hdfs.server.namenode.TestAclConfigFlag |
| | hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes |
| | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration |
| | hadoop.hdfs.TestDFSShell |
| | hadoop.hdfs.server.namenode.TestFileTruncate |
| | hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot |
| | hadoop.hdfs.TestFileCreationDelete |
| | hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot |
| | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS |
| | hadoop.hdfs.tools.TestDFSHAAdminMiniCluster |
| | hadoop.hdfs.server.namenode.TestXAttrConfigFlag |
| | hadoop.hdfs.server.namenode.TestCheckPointForSecurityTokens |
| | hadoop.hdfs.server.blockmanagement.TestNodeCount |
| | hadoop.hdfs.web.TestWebHDFSAcl |
| | hadoop.hdfs.TestRestartDFS |
| | hadoop.hdfs.TestDistributedFileSystem |
| | hadoop.hdfs.TestFileCreation |
| | hadoop.hdfs.TestDataTransferKeepalive |
| | hadoop.hdfs.server.namenode.TestDecommissioningStatus |
| | hadoop.hdfs.server.namenode.ha.TestStandbyIsHot |
| | hadoop.hdfs.server.datanode.TestBlockScanner |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
|
| | hadoop.hdfs.TestClientProtocolForPipelineRecovery |
| | hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots |
| | hadoop.hdfs.server.namenode.TestFileContextAcl |
| | hadoop.hdfs.TestRenameWhileOpen |
| | hadoop.hdfs.server.namenode.TestNameNodeXAttr |
| | hadoop.hdfs.TestRollingUpgrade |
| | hadoop.fs.TestHDFSFileContextMainOperations |
| | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure |
| | hadoop.hdfs.web.TestWebHDFSXAttr |
| | hadoop.hdfs.TestDFSClientExcludedNodes |
| | hadoop.hdfs.server.namenode.TestFsck |
| | hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks |
| | hadoop.hdfs.server.namenode.TestProcessCorruptBlocks |
| | hadoop.hdfs.server.namenode.TestNameNodeAcl |
| |
[jira] [Commented] (HDFS-8469) Lockfiles are not being created for datanode storage directories
[
https://issues.apache.org/jira/browse/HDFS-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556632#comment-14556632
]
Colin Patrick McCabe commented on HDFS-8469:
It looks like this behavior was introduced by HDFS-5138. I skimmed the
comments, but I didn't see any discussion of datanode lock file changes. As
far as I can tell, the fact that locking is now disabled on the datanode was
unintentional. [~atm], [~tlipcon], [~sureshms], any perspective on this?
Lockfiles are not being created for datanode storage directories
Key: HDFS-8469
URL: https://issues.apache.org/jira/browse/HDFS-8469
Project: Hadoop HDFS
Issue Type: Bug
Components: datanode
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Lockfiles are not being created for datanode storage directories. Due to a
mixup, we are initializing the StorageDirectory class with shared=true (an
option which was only intended for NFS directories used to implement NameNode
HA). Setting shared=true disables lockfile generation and prints a log
message like this:
{code}
2015-05-22 11:45:16,367 INFO common.Storage (Storage.java:lock(675)) -
Locking is disabled for
/home/cmccabe/hadoop2/hadoop-hdfs-project/hadoop-hdfs/target/
test/data/dfs/data/data5/current/BP-122766180-127.0.0.1-1432320314834
{code}
Without lock files, we could accidentally spawn two datanode processes using
the same directories without realizing it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
