[jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
[
https://issues.apache.org/jira/browse/HDFS-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578306#comment-14578306
]
Hadoop QA commented on HDFS-8515:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 18m 6s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 36s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 53s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 14s | The applied patch generated
16 new checkstyle issues (total was 163, now 169). |
| {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 20s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 17s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 161m 19s | Tests passed in hadoop-hdfs.
|
| | | 208m 19s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12738478/HDFS-8515.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / fc2ed4a |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/11283/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11283/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11283/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11283/console |
This message was automatically generated.
> Abstract a DTP/2 HTTP/2 server
> --
>
> Key: HDFS-8515
> URL: https://issues.apache.org/jira/browse/HDFS-8515
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Attachments: HDFS-8515.patch
>
>
> Discussed in HDFS-8471.
> https://issues.apache.org/jira/browse/HDFS-8471?focusedCommentId=14568196&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568196
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
[
https://issues.apache.org/jira/browse/HDFS-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584230#comment-14584230
]
Haohui Mai commented on HDFS-8515:
--
It looks like that the patch still contains significant portions of code
related to the DTP (e.g., {{datatransferv2.proto}}, catching exceptions like
InvalidToken, etc.) Maybe it makes more sense to remove them from this patch
and put them in a separate jira as discussed in HDFS-8471?
> Abstract a DTP/2 HTTP/2 server
> --
>
> Key: HDFS-8515
> URL: https://issues.apache.org/jira/browse/HDFS-8515
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Attachments: HDFS-8515.patch
>
>
> Discussed in HDFS-8471.
> https://issues.apache.org/jira/browse/HDFS-8471?focusedCommentId=14568196&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568196
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
[
https://issues.apache.org/jira/browse/HDFS-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585133#comment-14585133
]
Hadoop QA commented on HDFS-8515:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 17m 38s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 2 new or modified test files. |
| {color:green}+1{color} | javac | 7m 30s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 38s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 15s | The applied patch generated
18 new checkstyle issues (total was 20, now 30). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 17s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 14s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 160m 47s | Tests failed in hadoop-hdfs. |
| | | 206m 53s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.TestAppendSnapshotTruncate |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12739489/HDFS-8515-v1.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / b8341f1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/11347/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11347/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11347/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11347/console |
This message was automatically generated.
> Abstract a DTP/2 HTTP/2 server
> --
>
> Key: HDFS-8515
> URL: https://issues.apache.org/jira/browse/HDFS-8515
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Attachments: HDFS-8515-v1.patch, HDFS-8515.patch
>
>
> Discussed in HDFS-8471.
> https://issues.apache.org/jira/browse/HDFS-8471?focusedCommentId=14568196&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568196
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
[ https://issues.apache.org/jira/browse/HDFS-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589291#comment-14589291 ] Haohui Mai commented on HDFS-8515: -- I think it might make sense to further separate the client and the server into separate jiras. I would prefer to pushing for the client first -- as it is possible to test basic functionality against existing HTTP/2 server like H2O. > Abstract a DTP/2 HTTP/2 server > -- > > Key: HDFS-8515 > URL: https://issues.apache.org/jira/browse/HDFS-8515 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang > Attachments: HDFS-8515-v1.patch, HDFS-8515.patch > > > Discussed in HDFS-8471. > https://issues.apache.org/jira/browse/HDFS-8471?focusedCommentId=14568196&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568196 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
[
https://issues.apache.org/jira/browse/HDFS-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1459#comment-1459
]
Hadoop QA commented on HDFS-8515:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 18m 17s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 2 new or modified test files. |
| {color:green}+1{color} | javac | 7m 46s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 54s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 24s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 15s | The applied patch generated
15 new checkstyle issues (total was 21, now 28). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 38s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 19s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 19s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 162m 59s | Tests failed in hadoop-hdfs. |
| | | 210m 28s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests |
hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12740048/HDFS-8515-v2.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / ebb9a82 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/11388/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11388/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11388/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11388/console |
This message was automatically generated.
> Abstract a DTP/2 HTTP/2 server
> --
>
> Key: HDFS-8515
> URL: https://issues.apache.org/jira/browse/HDFS-8515
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Attachments: HDFS-8515-v1.patch, HDFS-8515-v2.patch,
> HDFS-8515-v3.patch, HDFS-8515.patch
>
>
> Discussed in HDFS-8471.
> https://issues.apache.org/jira/browse/HDFS-8471?focusedCommentId=14568196&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568196
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
[
https://issues.apache.org/jira/browse/HDFS-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590479#comment-14590479
]
Hadoop QA commented on HDFS-8515:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 18m 11s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 3 new or modified test files. |
| {color:green}+1{color} | javac | 7m 47s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 52s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 14s | The applied patch generated
15 new checkstyle issues (total was 21, now 28). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 18s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 24s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 163m 31s | Tests passed in hadoop-hdfs.
|
| | | 210m 52s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12740108/HDFS-8515-v3.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 6e3fcff |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/11390/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11390/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11390/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11390/console |
This message was automatically generated.
> Abstract a DTP/2 HTTP/2 server
> --
>
> Key: HDFS-8515
> URL: https://issues.apache.org/jira/browse/HDFS-8515
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Attachments: HDFS-8515-v1.patch, HDFS-8515-v2.patch,
> HDFS-8515-v3.patch, HDFS-8515.patch
>
>
> Discussed in HDFS-8471.
> https://issues.apache.org/jira/browse/HDFS-8471?focusedCommentId=14568196&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568196
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
[
https://issues.apache.org/jira/browse/HDFS-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596293#comment-14596293
]
Haohui Mai commented on HDFS-8515:
--
The patch looks good. I'm wondering whether it is possible to inherit the
{{AbstractChannel}} for the stream class, which is similar to what the
{{ChildChannel}} patch has done in https://github.com/netty/netty/issues/3667.
This will make the abstraction closer to the ones that netty provides,
simplifying the effort of building the applications at the upper layer.
> Abstract a DTP/2 HTTP/2 server
> --
>
> Key: HDFS-8515
> URL: https://issues.apache.org/jira/browse/HDFS-8515
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Attachments: HDFS-8515-v1.patch, HDFS-8515-v2.patch,
> HDFS-8515-v3.patch, HDFS-8515.patch
>
>
> Discussed in HDFS-8471.
> https://issues.apache.org/jira/browse/HDFS-8471?focusedCommentId=14568196&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568196
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
[ https://issues.apache.org/jira/browse/HDFS-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597011#comment-14597011 ] Duo Zhang commented on HDFS-8515: - I've introduced a Http2StreamChannel on the POC branch. https://github.com/Apache9/hadoop/tree/HDFS-7966-POC/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/http2 Let me extract a patch for it, thanks. > Abstract a DTP/2 HTTP/2 server > -- > > Key: HDFS-8515 > URL: https://issues.apache.org/jira/browse/HDFS-8515 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang > Attachments: HDFS-8515-v1.patch, HDFS-8515-v2.patch, > HDFS-8515-v3.patch, HDFS-8515.patch > > > Discussed in HDFS-8471. > https://issues.apache.org/jira/browse/HDFS-8471?focusedCommentId=14568196&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568196 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
[
https://issues.apache.org/jira/browse/HDFS-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597399#comment-14597399
]
Hadoop QA commented on HDFS-8515:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 17m 55s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 7 new or modified test files. |
| {color:green}+1{color} | javac | 7m 38s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 34s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 14s | The applied patch generated
11 new checkstyle issues (total was 426, now 430). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 15s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 11s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 158m 17s | Tests failed in hadoop-hdfs. |
| | | 204m 40s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.namenode.TestFileTruncate |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12741216/HDFS-8515-v4.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 41ae776 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/11445/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11445/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11445/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11445/console |
This message was automatically generated.
> Abstract a DTP/2 HTTP/2 server
> --
>
> Key: HDFS-8515
> URL: https://issues.apache.org/jira/browse/HDFS-8515
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Attachments: HDFS-8515-v1.patch, HDFS-8515-v2.patch,
> HDFS-8515-v3.patch, HDFS-8515-v4.patch, HDFS-8515.patch
>
>
> Discussed in HDFS-8471.
> https://issues.apache.org/jira/browse/HDFS-8471?focusedCommentId=14568196&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568196
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
[
https://issues.apache.org/jira/browse/HDFS-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598578#comment-14598578
]
Haohui Mai commented on HDFS-8515:
--
It might make sense to move all the code into the {o.a.h.web.http2} package.
{code}
+
+ // whether to log http2 frame for debugging
+ public static final String DFS_HTTP2_VERBOSE_KEY = "dfs.http2.verbose";
+ public static final boolean DFS_HTTP2_VERBOSE_DEFAULT = false;
+if (verbose) {
+ frameReader =
+ new Http2InboundFrameLogger(new DefaultHttp2FrameReader(),
+ FRAME_LOGGER);
+ frameWriter =
+ new Http2OutboundFrameLogger(new DefaultHttp2FrameWriter(),
+ FRAME_LOGGER);
{code}
Instead of adding a new configuration, a better approach might be adding a
logger into {{ServerHttp2ConectionHandler}} and check whether the debug log is
enabled.
{code}
+ private static final ChannelMetadata METADATA = new ChannelMetadata(false);
+
+ private final ChannelHandlerContext http2ConnHandlerCtx;
+
+ private final Http2Stream connStream;
+
+ private final Http2Stream stream;
+
{code}
There should be no empty lines between these members.
{code}
+ private final Http2LocalFlowController localFlowController;
+
+ private final Http2RemoteFlowController remoteFlowController;
+
{code}
It might make sense to separate the flow control logic into a separate patch.
{code}
+encoder.writeHeaders(http2ConnHandlerCtx, stream.id(),
+ (Http2Headers) msg, 0, endOfStream,
http2ConnHandlerCtx.newPromise());
{code}
encoder is not thread-safe. It seems to me the right approach is to run the
write in the event loop of the parent channel. The read path might have the
same issue.
{code}
+public class LastChunkedInput implements ChunkedInput {
+public class LastMessage {
{code}
To me both {{LastChunkedInput}} and {{LastMessage}} look like more of an
optimization right now. A simpler approach is to send an empty HEADER with the
end-of-stream bit on to tell the remote peer that the stream has been closed.
{code}
+public abstract class AbstractTestHttp2Server {
{code}
It can be a utility class instead of asking all HTTP2 test cases to inherit it.
{code}
+public class TestHttp2ServerMultiThread extends AbstractTestHttp2Server {
{code}
I'm yet to be convinced that testing of mutli threading is required right now.
Maybe having some coverage of the basic funciationlities is a higher priority.
> Abstract a DTP/2 HTTP/2 server
> --
>
> Key: HDFS-8515
> URL: https://issues.apache.org/jira/browse/HDFS-8515
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Attachments: HDFS-8515-v1.patch, HDFS-8515-v2.patch,
> HDFS-8515-v3.patch, HDFS-8515-v4.patch, HDFS-8515.patch
>
>
> Discussed in HDFS-8471.
> https://issues.apache.org/jira/browse/HDFS-8471?focusedCommentId=14568196&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568196
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
[
https://issues.apache.org/jira/browse/HDFS-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598634#comment-14598634
]
Duo Zhang commented on HDFS-8515:
-
{quote}
o.a.h.web.http2
{quote}
Then in hadoop-hdfs or hadoop-common? Seems all the codes in hdfs are under
o.a.h.fs or o.a.h.hdfs...
{quote}
encoder is not thread-safe. It seems to me the right approach is to run the
write in the event loop of the parent channel. The read path might have the
same issue.
{quote}
I think there are already in the event loop? Channel.read, Channel.write and
Channel.flush call the methods in DefaultChannelPipeline, and then call the
methods in TailContext, there will switch to run in EventLoop.
{quote}
To me both LastChunkedInput and LastMessage look like more of an optimization
right now. A simpler approach is to send an empty HEADER with the end-of-stream
bit on to tell the remote peer that the stream has been closed.
{quote}
This is used to notice {{Http2StreamChannel}} we need to send an endStream to
the remote side, so at least something like a {{LastMessage}} is needed(Think
of {{LastHttpContent}}). I'd say that sending an endStream with the last data
frame is an optimization, but I think it is simple enough to implement now?
{quote}
It can be a utility class instead of asking all HTTP2 test cases to inherit it.
{quote}
Any example? And what is the benefit of using an utility class instead of a
parent class? Thanks.
> Abstract a DTP/2 HTTP/2 server
> --
>
> Key: HDFS-8515
> URL: https://issues.apache.org/jira/browse/HDFS-8515
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Attachments: HDFS-8515-v1.patch, HDFS-8515-v2.patch,
> HDFS-8515-v3.patch, HDFS-8515-v4.patch, HDFS-8515.patch
>
>
> Discussed in HDFS-8471.
> https://issues.apache.org/jira/browse/HDFS-8471?focusedCommentId=14568196&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568196
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
[
https://issues.apache.org/jira/browse/HDFS-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598638#comment-14598638
]
Duo Zhang commented on HDFS-8515:
-
{quote}
I'm yet to be convinced that testing of mutli threading is required right now.
Maybe having some coverage of the basic funciationlities is a higher priority.
{quote}
The basic tests are in {{TestHttp2Server}}. Thanks.
> Abstract a DTP/2 HTTP/2 server
> --
>
> Key: HDFS-8515
> URL: https://issues.apache.org/jira/browse/HDFS-8515
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Attachments: HDFS-8515-v1.patch, HDFS-8515-v2.patch,
> HDFS-8515-v3.patch, HDFS-8515-v4.patch, HDFS-8515.patch
>
>
> Discussed in HDFS-8471.
> https://issues.apache.org/jira/browse/HDFS-8471?focusedCommentId=14568196&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568196
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
[
https://issues.apache.org/jira/browse/HDFS-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599259#comment-14599259
]
Hadoop QA commented on HDFS-8515:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 15m 20s | Findbugs (version ) appears to
be broken on trunk. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 6 new or modified test files. |
| {color:green}+1{color} | javac | 8m 12s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 38s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 24s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 49s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 40s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 13s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 14s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 162m 40s | Tests passed in hadoop-hdfs.
|
| | | 205m 48s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12741463/HDFS-8515-v5.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 2ba6465 |
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11461/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11461/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11461/console |
This message was automatically generated.
> Abstract a DTP/2 HTTP/2 server
> --
>
> Key: HDFS-8515
> URL: https://issues.apache.org/jira/browse/HDFS-8515
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Attachments: HDFS-8515-v1.patch, HDFS-8515-v2.patch,
> HDFS-8515-v3.patch, HDFS-8515-v4.patch, HDFS-8515-v5.patch,
> HDFS-8515-v6.patch, HDFS-8515.patch
>
>
> Discussed in HDFS-8471.
> https://issues.apache.org/jira/browse/HDFS-8471?focusedCommentId=14568196&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568196
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
[
https://issues.apache.org/jira/browse/HDFS-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599485#comment-14599485
]
Hadoop QA commented on HDFS-8515:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 18m 0s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 6 new or modified test files. |
| {color:green}+1{color} | javac | 7m 34s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 30s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 24s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 16s | The applied patch generated 8
new checkstyle issues (total was 9, now 9). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 13s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 14s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 161m 2s | Tests failed in hadoop-hdfs. |
| | | 207m 27s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.namenode.TestFileTruncate |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12741577/HDFS-8515-v6.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 2ba6465 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/11463/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11463/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11463/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11463/console |
This message was automatically generated.
> Abstract a DTP/2 HTTP/2 server
> --
>
> Key: HDFS-8515
> URL: https://issues.apache.org/jira/browse/HDFS-8515
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Attachments: HDFS-8515-v1.patch, HDFS-8515-v2.patch,
> HDFS-8515-v3.patch, HDFS-8515-v4.patch, HDFS-8515-v5.patch,
> HDFS-8515-v6.patch, HDFS-8515.patch
>
>
> Discussed in HDFS-8471.
> https://issues.apache.org/jira/browse/HDFS-8471?focusedCommentId=14568196&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568196
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
[ https://issues.apache.org/jira/browse/HDFS-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600465#comment-14600465 ] Haohui Mai commented on HDFS-8515: -- +1 > Abstract a DTP/2 HTTP/2 server > -- > > Key: HDFS-8515 > URL: https://issues.apache.org/jira/browse/HDFS-8515 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang > Attachments: HDFS-8515-v1.patch, HDFS-8515-v2.patch, > HDFS-8515-v3.patch, HDFS-8515-v4.patch, HDFS-8515-v5.patch, > HDFS-8515-v6.patch, HDFS-8515.patch > > > Discussed in HDFS-8471. > https://issues.apache.org/jira/browse/HDFS-8471?focusedCommentId=14568196&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568196 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Auto-Re: [jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
您的邮件已收到！谢谢！
Auto-Re: [jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
您的邮件已收到！谢谢！
Auto-Re: [jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
您的邮件已收到！谢谢！
Auto-Re: [jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
您的邮件已收到！谢谢！
Auto-Re: [jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
您的邮件已收到！谢谢！
Auto-Re: [jira] [Commented] (HDFS-8515) Abstract a DTP/2 HTTP/2 server
您的邮件已收到！谢谢！
