[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985664#comment-14985664 ] Hudson commented on HDFS-8777: -- FAILURE: Integrated in Hadoop-Yarn-trunk #1350 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1350/]) HDFS-8777. Erasure Coding: add tests for taking snapshots on EC files. (zhz: rev 90e14055168afdb93fa8089158c03a6a694e066c) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestErasureCodingPolicyWithSnapshot.java > Erasure Coding: add tests for taking snapshots on EC files > -- > > Key: HDFS-8777 > URL: https://issues.apache.org/jira/browse/HDFS-8777 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: erasure-coding >Reporter: Jing Zhao >Assignee: Rakesh R > Labels: test > Fix For: 3.0.0 > > Attachments: HDFS-8777-01.patch, HDFS-8777-02.patch, > HDFS-8777-03.patch, HDFS-8777-HDFS-7285-00.patch, HDFS-8777-HDFS-7285-01.patch > > > We need to add more tests for (EC + snapshots). The tests need to verify the > fsimage saving/loading is correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985715#comment-14985715 ] Hudson commented on HDFS-8777: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #616 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/616/]) HDFS-8777. Erasure Coding: add tests for taking snapshots on EC files. (zhz: rev 90e14055168afdb93fa8089158c03a6a694e066c) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestErasureCodingPolicyWithSnapshot.java > Erasure Coding: add tests for taking snapshots on EC files > -- > > Key: HDFS-8777 > URL: https://issues.apache.org/jira/browse/HDFS-8777 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: erasure-coding >Reporter: Jing Zhao >Assignee: Rakesh R > Labels: test > Fix For: 3.0.0 > > Attachments: HDFS-8777-01.patch, HDFS-8777-02.patch, > HDFS-8777-03.patch, HDFS-8777-HDFS-7285-00.patch, HDFS-8777-HDFS-7285-01.patch > > > We need to add more tests for (EC + snapshots). The tests need to verify the > fsimage saving/loading is correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985967#comment-14985967 ] Hudson commented on HDFS-8777: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #628 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/628/]) HDFS-8777. Erasure Coding: add tests for taking snapshots on EC files. (zhz: rev 90e14055168afdb93fa8089158c03a6a694e066c) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestErasureCodingPolicyWithSnapshot.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Erasure Coding: add tests for taking snapshots on EC files > -- > > Key: HDFS-8777 > URL: https://issues.apache.org/jira/browse/HDFS-8777 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: erasure-coding >Reporter: Jing Zhao >Assignee: Rakesh R > Labels: test > Fix For: 3.0.0 > > Attachments: HDFS-8777-01.patch, HDFS-8777-02.patch, > HDFS-8777-03.patch, HDFS-8777-HDFS-7285-00.patch, HDFS-8777-HDFS-7285-01.patch > > > We need to add more tests for (EC + snapshots). The tests need to verify the > fsimage saving/loading is correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986003#comment-14986003 ] Hudson commented on HDFS-8777: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2558 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2558/]) HDFS-8777. Erasure Coding: add tests for taking snapshots on EC files. (zhz: rev 90e14055168afdb93fa8089158c03a6a694e066c) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestErasureCodingPolicyWithSnapshot.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Erasure Coding: add tests for taking snapshots on EC files > -- > > Key: HDFS-8777 > URL: https://issues.apache.org/jira/browse/HDFS-8777 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: erasure-coding >Reporter: Jing Zhao >Assignee: Rakesh R > Labels: test > Fix For: 3.0.0 > > Attachments: HDFS-8777-01.patch, HDFS-8777-02.patch, > HDFS-8777-03.patch, HDFS-8777-HDFS-7285-00.patch, HDFS-8777-HDFS-7285-01.patch > > > We need to add more tests for (EC + snapshots). The tests need to verify the > fsimage saving/loading is correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985465#comment-14985465 ] Hudson commented on HDFS-8777: -- FAILURE: Integrated in Hadoop-trunk-Commit #8742 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8742/]) HDFS-8777. Erasure Coding: add tests for taking snapshots on EC files. (zhz: rev 90e14055168afdb93fa8089158c03a6a694e066c) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestErasureCodingPolicyWithSnapshot.java > Erasure Coding: add tests for taking snapshots on EC files > -- > > Key: HDFS-8777 > URL: https://issues.apache.org/jira/browse/HDFS-8777 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: erasure-coding >Reporter: Jing Zhao >Assignee: Rakesh R > Labels: test > Fix For: 3.0.0 > > Attachments: HDFS-8777-01.patch, HDFS-8777-02.patch, > HDFS-8777-03.patch, HDFS-8777-HDFS-7285-00.patch, HDFS-8777-HDFS-7285-01.patch > > > We need to add more tests for (EC + snapshots). The tests need to verify the > fsimage saving/loading is correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986189#comment-14986189 ] Hudson commented on HDFS-8777: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2500 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2500/]) HDFS-8777. Erasure Coding: add tests for taking snapshots on EC files. (zhz: rev 90e14055168afdb93fa8089158c03a6a694e066c) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestErasureCodingPolicyWithSnapshot.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Erasure Coding: add tests for taking snapshots on EC files > -- > > Key: HDFS-8777 > URL: https://issues.apache.org/jira/browse/HDFS-8777 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: erasure-coding >Reporter: Jing Zhao >Assignee: Rakesh R > Labels: test > Fix For: 3.0.0 > > Attachments: HDFS-8777-01.patch, HDFS-8777-02.patch, > HDFS-8777-03.patch, HDFS-8777-HDFS-7285-00.patch, HDFS-8777-HDFS-7285-01.patch > > > We need to add more tests for (EC + snapshots). The tests need to verify the > fsimage saving/loading is correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986455#comment-14986455 ] Hudson commented on HDFS-8777: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #564 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/564/]) HDFS-8777. Erasure Coding: add tests for taking snapshots on EC files. (zhz: rev 90e14055168afdb93fa8089158c03a6a694e066c) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestErasureCodingPolicyWithSnapshot.java > Erasure Coding: add tests for taking snapshots on EC files > -- > > Key: HDFS-8777 > URL: https://issues.apache.org/jira/browse/HDFS-8777 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: erasure-coding >Reporter: Jing Zhao >Assignee: Rakesh R > Labels: test > Fix For: 3.0.0 > > Attachments: HDFS-8777-01.patch, HDFS-8777-02.patch, > HDFS-8777-03.patch, HDFS-8777-HDFS-7285-00.patch, HDFS-8777-HDFS-7285-01.patch > > > We need to add more tests for (EC + snapshots). The tests need to verify the > fsimage saving/loading is correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[
https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984109#comment-14984109
]
Hadoop QA commented on HDFS-8777:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 8s
{color} | {color:blue} docker + precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
48s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s
{color} | {color:green} trunk passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s {color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 29s
{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs in trunk cannot run
convertXmlToText from findbugs {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 30s
{color} | {color:green} trunk passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 24s
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
53s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s
{color} | {color:green} the patch passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 50s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 47s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 47s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
38s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 34s
{color} | {color:green} the patch passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 27s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 74m 27s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.8.0_60. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 58m 28s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 21s
{color} | {color:red} Patch generated 58 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 158m 40s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_60 Failed junit tests |
hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes |
| | hadoop.hdfs.server.namenode.ha.TestEditLogTailer |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
|
| | hadoop.hdfs.server.namenode.TestCheckpoint |
| | hadoop.hdfs.security.TestDelegationTokenForProxyUser |
| | hadoop.hdfs.TestSafeModeWithStripedFile |
| | hadoop.hdfs.server.datanode.TestBlockScanner |
| | hadoop.hdfs.TestDataTransferKeepalive |
| JDK v1.7.0_79 Failed junit tests |
hadoop.hdfs.server.blockmanagement.TestNodeCount |
| | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140 |
| | hadoop.hdfs.TestRollingUpgrade |
| | hadoop.hdfs.server.namenode.TestDecommissioningStatus |
| | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure200 |
| | hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA |
| |
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[
https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982092#comment-14982092
]
Rakesh R commented on HDFS-8777:
Thanks a lot [~zhz] for the useful comments.
- 1, 2, 3 >> Agreed and will update it when creating another patch.
- 4 >> yeah, I think it is possible to add strict validation by checking
{{iip.getLastINode() == null}} and throw exception. Probably will keep the
condition [here
FSDirErasureCodingOp.java#L229|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirErasureCodingOp.java#L229].
How about raise a minor sub-task under HDFS-8031 and discuss there separately?
- 5 >> To test erasure coding policy + snapshot behavior I think we need to add
extra code and do assertions in between. IMHO would be good to keep ec policy
tests separately. Does it make sense to you?
> Erasure Coding: add tests for taking snapshots on EC files
> --
>
> Key: HDFS-8777
> URL: https://issues.apache.org/jira/browse/HDFS-8777
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: erasure-coding
>Reporter: Jing Zhao
>Assignee: Rakesh R
> Labels: test
> Attachments: HDFS-8777-01.patch, HDFS-8777-02.patch,
> HDFS-8777-HDFS-7285-00.patch, HDFS-8777-HDFS-7285-01.patch
>
>
> We need to add more tests for (EC + snapshots). The tests need to verify the
> fsimage saving/loading is correct.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[
https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983528#comment-14983528
]
Hadoop QA commented on HDFS-8777:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 7s
{color} | {color:blue} docker + precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 3m 19s
{color} | {color:red} root in trunk failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s
{color} | {color:green} trunk passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 51s
{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs in trunk cannot run
convertXmlToText from findbugs {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s
{color} | {color:green} trunk passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 46s
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
36s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s
{color} | {color:green} the patch passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 30s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 31s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 1s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s
{color} | {color:green} the patch passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 50s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 62m 31s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.8.0_60. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 60m 41s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 20s
{color} | {color:red} Patch generated 56 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 142m 41s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_60 Failed junit tests |
hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes |
| | hadoop.hdfs.server.namenode.TestAddStripedBlocks |
| | hadoop.hdfs.TestSafeModeWithStripedFile |
| | hadoop.hdfs.TestPread |
| | hadoop.hdfs.server.namenode.TestFileTruncate |
| | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure100 |
| | hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock |
| | hadoop.hdfs.TestReadStripedFileWithMissingBlocks |
| | hadoop.hdfs.server.namenode.TestRecoverStripedBlocks |
| | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS |
| | hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer |
| | hadoop.hdfs.server.namenode.TestAddBlockRetry |
| | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160 |
| | hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes |
| |
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983108#comment-14983108 ] Rakesh R commented on HDFS-8777: Thanks [~zhz] for the reply. Attached another patch fixing 1,2,3 comments. Also, I've removed the non-existent file part from this unit testing and raised HDFS-9348 jira to implement this behavior. > Erasure Coding: add tests for taking snapshots on EC files > -- > > Key: HDFS-8777 > URL: https://issues.apache.org/jira/browse/HDFS-8777 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: erasure-coding >Reporter: Jing Zhao >Assignee: Rakesh R > Labels: test > Attachments: HDFS-8777-01.patch, HDFS-8777-02.patch, > HDFS-8777-03.patch, HDFS-8777-HDFS-7285-00.patch, HDFS-8777-HDFS-7285-01.patch > > > We need to add more tests for (EC + snapshots). The tests need to verify the > fsimage saving/loading is correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982865#comment-14982865 ] Zhe Zhang commented on HDFS-8777: - Agree on both points above. But for 4), we can probly address the issue for both EC and EZ in one JIRA. Thanks Rakesh. > Erasure Coding: add tests for taking snapshots on EC files > -- > > Key: HDFS-8777 > URL: https://issues.apache.org/jira/browse/HDFS-8777 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: erasure-coding >Reporter: Jing Zhao >Assignee: Rakesh R > Labels: test > Attachments: HDFS-8777-01.patch, HDFS-8777-02.patch, > HDFS-8777-HDFS-7285-00.patch, HDFS-8777-HDFS-7285-01.patch > > > We need to add more tests for (EC + snapshots). The tests need to verify the > fsimage saving/loading is correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[
https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981077#comment-14981077
]
Zhe Zhang commented on HDFS-8777:
-
Thanks Rakesh for the patch! It looks good overall. A few minor comments:
# Maybe explicitly use {{sysDefaultPolicy}} in all {{setErasureCodingPolicy}}
calls in this test? Now there's a mix of {{sysDefaultPolicy}} and null.
# Missing "coding": "// Now delete the dir which has erasure policy."
# In section "// Check that older snapshots still have the old ECPolicy
settings", should we also verify {{snap2}}?
# The below verifies the EC policy on a non-existent file. It looks like a bug
in {{getErasureCodingPolicy}}. Actually it looks like
{{getEncryptionZoneForPath}} has the same behavior.
{code}
final Path snap1File = new Path(snap1, "file1");
assertEquals("Got unexpected erasure coding policy", sysDefaultPolicy,
fs.getErasureCodingPolicy(snap1File));
{code}
# As a follow-on, we can explore whether it's possible to subclass
{{TestSnapshot}} with {{setErasureCodingPolicy}} hooks. I'm not sure how hard
it is, just a thought.
> Erasure Coding: add tests for taking snapshots on EC files
> --
>
> Key: HDFS-8777
> URL: https://issues.apache.org/jira/browse/HDFS-8777
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: erasure-coding
>Reporter: Jing Zhao
>Assignee: Rakesh R
> Labels: test
> Attachments: HDFS-8777-01.patch, HDFS-8777-02.patch,
> HDFS-8777-HDFS-7285-00.patch, HDFS-8777-HDFS-7285-01.patch
>
>
> We need to add more tests for (EC + snapshots). The tests need to verify the
> fsimage saving/loading is correct.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[
https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948288#comment-14948288
]
Hadoop QA commented on HDFS-8777:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 9m 35s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 9m 0s | There were no new javac warning
messages. |
| {color:red}-1{color} | release audit | 0m 19s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 37s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 43s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 38s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 2m 44s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 1m 9s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 185m 45s | Tests failed in hadoop-hdfs. |
| | | 212m 33s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA |
| Timed out tests | org.apache.hadoop.hdfs.TestFileAppend2 |
| | org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12765435/HDFS-8777-02.patch |
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / 35affec |
| Release Audit |
https://builds.apache.org/job/PreCommit-HDFS-Build/12852/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12852/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/12852/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/12852/console |
This message was automatically generated.
> Erasure Coding: add tests for taking snapshots on EC files
> --
>
> Key: HDFS-8777
> URL: https://issues.apache.org/jira/browse/HDFS-8777
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Jing Zhao
>Assignee: Rakesh R
> Labels: test
> Attachments: HDFS-8777-01.patch, HDFS-8777-02.patch,
> HDFS-8777-HDFS-7285-00.patch, HDFS-8777-HDFS-7285-01.patch
>
>
> We need to add more tests for (EC + snapshots). The tests need to verify the
> fsimage saving/loading is correct.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[
https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946716#comment-14946716
]
Hadoop QA commented on HDFS-8777:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 8m 22s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:red}-1{color} | javac | 1m 53s | The patch appears to cause the
build to fail. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12765373/HDFS-8777-01.patch |
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / 61b3547 |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/12833/console |
This message was automatically generated.
> Erasure Coding: add tests for taking snapshots on EC files
> --
>
> Key: HDFS-8777
> URL: https://issues.apache.org/jira/browse/HDFS-8777
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Jing Zhao
>Assignee: Rakesh R
> Labels: test
> Attachments: HDFS-8777-01.patch, HDFS-8777-HDFS-7285-00.patch,
> HDFS-8777-HDFS-7285-01.patch
>
>
> We need to add more tests for (EC + snapshots). The tests need to verify the
> fsimage saving/loading is correct.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746948#comment-14746948 ] Rakesh R commented on HDFS-8777: Hi [~zhz], I've rebased the patch on latest EC branch code. Please take a look at it. It would be good to merge if we all agree with the patch. Thanks! > Erasure Coding: add tests for taking snapshots on EC files > -- > > Key: HDFS-8777 > URL: https://issues.apache.org/jira/browse/HDFS-8777 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Jing Zhao >Assignee: Rakesh R > Labels: test > Attachments: HDFS-8777-HDFS-7285-00.patch, > HDFS-8777-HDFS-7285-01.patch > > > We need to add more tests for (EC + snapshots). The tests need to verify the > fsimage saving/loading is correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[
https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14747220#comment-14747220
]
Hadoop QA commented on HDFS-8777:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 7m 49s | Pre-patch HDFS-7285 has 4
extant Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 49s | There were no new javac warning
messages. |
| {color:red}-1{color} | release audit | 0m 14s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 21s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 27s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 2m 34s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 1m 13s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 187m 45s | Tests failed in hadoop-hdfs. |
| | | 210m 51s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.TestWriteStripedFileWithFailure |
| Timed out tests |
org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000 |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12756174/HDFS-8777-HDFS-7285-01.patch
|
| Optional Tests | javac unit findbugs checkstyle |
| git revision | HDFS-7285 / ced438a |
| Pre-patch Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/12470/artifact/patchprocess/HDFS-7285FindbugsWarningshadoop-hdfs.html
|
| Release Audit |
https://builds.apache.org/job/PreCommit-HDFS-Build/12470/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12470/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/12470/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/12470/console |
This message was automatically generated.
> Erasure Coding: add tests for taking snapshots on EC files
> --
>
> Key: HDFS-8777
> URL: https://issues.apache.org/jira/browse/HDFS-8777
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Jing Zhao
>Assignee: Rakesh R
> Labels: test
> Attachments: HDFS-8777-HDFS-7285-00.patch,
> HDFS-8777-HDFS-7285-01.patch
>
>
> We need to add more tests for (EC + snapshots). The tests need to verify the
> fsimage saving/loading is correct.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14744115#comment-14744115 ] Zhe Zhang commented on HDFS-8777: - [~rakeshr] I just moved this as a follow-on. But if you have time to rebase the patch we can always commit it before merging. Thanks. > Erasure Coding: add tests for taking snapshots on EC files > -- > > Key: HDFS-8777 > URL: https://issues.apache.org/jira/browse/HDFS-8777 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Jing Zhao >Assignee: Rakesh R > Labels: test > Attachments: HDFS-8777-HDFS-7285-00.patch > > > We need to add more tests for (EC + snapshots). The tests need to verify the > fsimage saving/loading is correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716131#comment-14716131 ] Rakesh R commented on HDFS-8777: Thanks [~zhz] for the interest. I will rebase the patch once HDFS-8833 is finalized. Erasure Coding: add tests for taking snapshots on EC files -- Key: HDFS-8777 URL: https://issues.apache.org/jira/browse/HDFS-8777 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Jing Zhao Assignee: Rakesh R Labels: test Attachments: HDFS-8777-HDFS-7285-00.patch We need to add more tests for (EC + snapshots). The tests need to verify the fsimage saving/loading is correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715599#comment-14715599 ] Zhe Zhang commented on HDFS-8777: - Thanks for the work Rakesh. With HDFS-8854 we should use ECPolicy instead of schema in hdfs. HDFS-8833 will likely eliminate the concept of EC zones. Do you mind rebasing the patch after HDFS-8833 is finalized? Erasure Coding: add tests for taking snapshots on EC files -- Key: HDFS-8777 URL: https://issues.apache.org/jira/browse/HDFS-8777 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Jing Zhao Assignee: Rakesh R Labels: test Attachments: HDFS-8777-HDFS-7285-00.patch We need to add more tests for (EC + snapshots). The tests need to verify the fsimage saving/loading is correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[
https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14640016#comment-14640016
]
Rakesh R commented on HDFS-8777:
I have attached patch taken from HDFS-8266 jira. Earlier [~demongaorui] helped
in reviews and got few
[comments|https://issues.apache.org/jira/browse/HDFS-8266?focusedCommentId=14568815page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14568815]
in HDFS-8266. I have addressed (1) and (2). Could you please give few
clarifications on (3) and (4).
bq. (3) I think we could not confirm the older snapshots still have the old EZ
settings here, cause snap1Zone has the exactly same value as snap3Zone. Maybe,
we can make different settings of old EZ and new EZ, so that we can confirm the
older snapshot keep the old EZ settings.
Presently there is no option to add a new schema apart from the
{{SYS_DEFAULT_SCHEMA}}. I have tested the behavior by creating a new ec zone
with different schema. It will allow to create the eczone without any ecschema.
IMHO we could improve this by validating the user given schema with the
{{ErasureCodingSchemaManager#activeSchemas}}, if not should throw IOException
to the users, right.
Shall I raise a separate jira to validate the user passed ECSchema against
{{activeSchemas}} and work on this ?
{code}
fs.createErasureCodingZone(zone, customECSchema, 0);
{code}
bq. (4) In method testSnapshotsOnECZoneDir(), ECZone was created based on
zone(value: /zone). When we call fs.getErasureCodingZone() respectively with
parameter
snap1Zone(value:/zone/.snapshot/snap1/zone)}}and{{snap1(value:/zone/.snapshot/snap1),
I think fs.getErasureCodingZone(snap1) actually returns the ECZone set to
zone(value:/zone), and {{fs.getErasureCodingZone(snap1Zone) returns the
ECZone set in the process of snapshot, right? If it's right, then ECZone can be
nested, so does fs.getErasureCodingZone() return the nearest parent dir which
is ECZone of the Path parameter (or the Path parameter itself if the Path
parameter is ECZone)?
IIUC {{fs.getErasureCodingZone}} will always returns the parent dir of the
ECZone. I have modified the testcase by giving a new snapfile name {{file1}}
instead of reusing the {{zone}} name to avoid confusion.
Erasure Coding: add tests for taking snapshots on EC files
--
Key: HDFS-8777
URL: https://issues.apache.org/jira/browse/HDFS-8777
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Jing Zhao
Assignee: Rakesh R
Attachments: HDFS-8777-HDFS-7285-00.patch
We need to add more tests for (EC + snapshots). The tests need to verify the
fsimage saving/loading is correct.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[
https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14640238#comment-14640238
]
Hadoop QA commented on HDFS-8777:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 6m 27s | Findbugs (version ) appears to
be broken on HDFS-7285. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 8m 16s | There were no new javac warning
messages. |
| {color:red}-1{color} | release audit | 0m 12s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 40s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 47s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 3m 41s | The patch appears to introduce 5
new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 1m 24s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 173m 7s | Tests failed in hadoop-hdfs. |
| | | 196m 13s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
| Failed unit tests | hadoop.hdfs.server.namenode.TestFileTruncate |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12746957/HDFS-8777-HDFS-7285-00.patch
|
| Optional Tests | javac unit findbugs checkstyle |
| git revision | HDFS-7285 / c2c26e6 |
| Release Audit |
https://builds.apache.org/job/PreCommit-HDFS-Build/11823/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/11823/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11823/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11823/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11823/console |
This message was automatically generated.
Erasure Coding: add tests for taking snapshots on EC files
--
Key: HDFS-8777
URL: https://issues.apache.org/jira/browse/HDFS-8777
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Jing Zhao
Assignee: Rakesh R
Attachments: HDFS-8777-HDFS-7285-00.patch
We need to add more tests for (EC + snapshots). The tests need to verify the
fsimage saving/loading is correct.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627500#comment-14627500 ] Jing Zhao commented on HDFS-8777: - Yes. Let me assign this jira to you. Erasure Coding: add tests for taking snapshots on EC files -- Key: HDFS-8777 URL: https://issues.apache.org/jira/browse/HDFS-8777 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Jing Zhao We need to add more tests for (EC + snapshots). The tests need to verify the fsimage saving/loading is correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
[ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627440#comment-14627440 ] Rakesh R commented on HDFS-8777: [~jingzhao] I hope this task is to add unit tests. Could you please take a look at HDFS-8266 system test task, as an initial attempt I had attached patch to unit tests EC + snapshots in that jira. I think will move the unit tests here and in that jira will focus only system test cases. Probably I will include few more test cases with fsimage saving/loading scenarios. Does this make sense? Erasure Coding: add tests for taking snapshots on EC files -- Key: HDFS-8777 URL: https://issues.apache.org/jira/browse/HDFS-8777 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Jing Zhao We need to add more tests for (EC + snapshots). The tests need to verify the fsimage saving/loading is correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
