[jira] [Commented] (HDFS-8930) Block report lease may leak if the 2nd full block report comes when NN is still in safemode
[ https://issues.apache.org/jira/browse/HDFS-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709770#comment-14709770 ] Colin Patrick McCabe commented on HDFS-8930: +1. Thanks, [~jingzhao]. Block report lease may leak if the 2nd full block report comes when NN is still in safemode --- Key: HDFS-8930 URL: https://issues.apache.org/jira/browse/HDFS-8930 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.8.0 Reporter: Jing Zhao Assignee: Jing Zhao Priority: Minor Attachments: HDFS-8930.000.patch This is a rare scenario in practice. If the NameNode is still in startup SafeMode while a DataNode sends it the 2nd FBR, the NameNode assigns the lease but rejects the report. The lease then leaves in NN until it expires. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8930) Block report lease may leak if the 2nd full block report comes when NN is still in safemode
[ https://issues.apache.org/jira/browse/HDFS-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709910#comment-14709910 ] Hudson commented on HDFS-8930: -- FAILURE: Integrated in Hadoop-trunk-Commit #8344 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8344/]) HDFS-8930. Block report lease may leak if the 2nd full block report comes when NN is still in safemode (Colin P. McCabe via Jing Zhao) (cmccabe: rev b5ce87f84d9de0a5347ab38c0567a5a70d1fbfd7) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockReportRateLimiting.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java Block report lease may leak if the 2nd full block report comes when NN is still in safemode --- Key: HDFS-8930 URL: https://issues.apache.org/jira/browse/HDFS-8930 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.8.0 Reporter: Jing Zhao Assignee: Jing Zhao Priority: Minor Fix For: 2.8.0 Attachments: HDFS-8930.000.patch This is a rare scenario in practice. If the NameNode is still in startup SafeMode while a DataNode sends it the 2nd FBR, the NameNode assigns the lease but rejects the report. The lease then leaves in NN until it expires. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8930) Block report lease may leak if the 2nd full block report comes when NN is still in safemode
[ https://issues.apache.org/jira/browse/HDFS-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709923#comment-14709923 ] Hudson commented on HDFS-8930: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #304 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/304/]) HDFS-8930. Block report lease may leak if the 2nd full block report comes when NN is still in safemode (Colin P. McCabe via Jing Zhao) (cmccabe: rev b5ce87f84d9de0a5347ab38c0567a5a70d1fbfd7) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockReportRateLimiting.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Block report lease may leak if the 2nd full block report comes when NN is still in safemode --- Key: HDFS-8930 URL: https://issues.apache.org/jira/browse/HDFS-8930 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.8.0 Reporter: Jing Zhao Assignee: Jing Zhao Priority: Minor Fix For: 2.8.0 Attachments: HDFS-8930.000.patch This is a rare scenario in practice. If the NameNode is still in startup SafeMode while a DataNode sends it the 2nd FBR, the NameNode assigns the lease but rejects the report. The lease then leaves in NN until it expires. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8930) Block report lease may leak if the 2nd full block report comes when NN is still in safemode
[ https://issues.apache.org/jira/browse/HDFS-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710138#comment-14710138 ] Hudson commented on HDFS-8930: -- FAILURE: Integrated in Hadoop-Yarn-trunk #1033 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1033/]) HDFS-8930. Block report lease may leak if the 2nd full block report comes when NN is still in safemode (Colin P. McCabe via Jing Zhao) (cmccabe: rev b5ce87f84d9de0a5347ab38c0567a5a70d1fbfd7) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockReportRateLimiting.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java Block report lease may leak if the 2nd full block report comes when NN is still in safemode --- Key: HDFS-8930 URL: https://issues.apache.org/jira/browse/HDFS-8930 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.8.0 Reporter: Jing Zhao Assignee: Jing Zhao Priority: Minor Fix For: 2.8.0 Attachments: HDFS-8930.000.patch This is a rare scenario in practice. If the NameNode is still in startup SafeMode while a DataNode sends it the 2nd FBR, the NameNode assigns the lease but rejects the report. The lease then leaves in NN until it expires. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8930) Block report lease may leak if the 2nd full block report comes when NN is still in safemode
[ https://issues.apache.org/jira/browse/HDFS-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710213#comment-14710213 ] Hudson commented on HDFS-8930: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2230 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2230/]) HDFS-8930. Block report lease may leak if the 2nd full block report comes when NN is still in safemode (Colin P. McCabe via Jing Zhao) (cmccabe: rev b5ce87f84d9de0a5347ab38c0567a5a70d1fbfd7) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockReportRateLimiting.java Block report lease may leak if the 2nd full block report comes when NN is still in safemode --- Key: HDFS-8930 URL: https://issues.apache.org/jira/browse/HDFS-8930 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.8.0 Reporter: Jing Zhao Assignee: Jing Zhao Priority: Minor Fix For: 2.8.0 Attachments: HDFS-8930.000.patch This is a rare scenario in practice. If the NameNode is still in startup SafeMode while a DataNode sends it the 2nd FBR, the NameNode assigns the lease but rejects the report. The lease then leaves in NN until it expires. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8930) Block report lease may leak if the 2nd full block report comes when NN is still in safemode
[ https://issues.apache.org/jira/browse/HDFS-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710224#comment-14710224 ] Hudson commented on HDFS-8930: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2249 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2249/]) HDFS-8930. Block report lease may leak if the 2nd full block report comes when NN is still in safemode (Colin P. McCabe via Jing Zhao) (cmccabe: rev b5ce87f84d9de0a5347ab38c0567a5a70d1fbfd7) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockReportRateLimiting.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java Block report lease may leak if the 2nd full block report comes when NN is still in safemode --- Key: HDFS-8930 URL: https://issues.apache.org/jira/browse/HDFS-8930 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.8.0 Reporter: Jing Zhao Assignee: Jing Zhao Priority: Minor Fix For: 2.8.0 Attachments: HDFS-8930.000.patch This is a rare scenario in practice. If the NameNode is still in startup SafeMode while a DataNode sends it the 2nd FBR, the NameNode assigns the lease but rejects the report. The lease then leaves in NN until it expires. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8930) Block report lease may leak if the 2nd full block report comes when NN is still in safemode
[ https://issues.apache.org/jira/browse/HDFS-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710188#comment-14710188 ] Hudson commented on HDFS-8930: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #300 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/300/]) HDFS-8930. Block report lease may leak if the 2nd full block report comes when NN is still in safemode (Colin P. McCabe via Jing Zhao) (cmccabe: rev b5ce87f84d9de0a5347ab38c0567a5a70d1fbfd7) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockReportRateLimiting.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java Block report lease may leak if the 2nd full block report comes when NN is still in safemode --- Key: HDFS-8930 URL: https://issues.apache.org/jira/browse/HDFS-8930 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.8.0 Reporter: Jing Zhao Assignee: Jing Zhao Priority: Minor Fix For: 2.8.0 Attachments: HDFS-8930.000.patch This is a rare scenario in practice. If the NameNode is still in startup SafeMode while a DataNode sends it the 2nd FBR, the NameNode assigns the lease but rejects the report. The lease then leaves in NN until it expires. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8930) Block report lease may leak if the 2nd full block report comes when NN is still in safemode
[ https://issues.apache.org/jira/browse/HDFS-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710228#comment-14710228 ] Hudson commented on HDFS-8930: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #292 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/292/]) HDFS-8930. Block report lease may leak if the 2nd full block report comes when NN is still in safemode (Colin P. McCabe via Jing Zhao) (cmccabe: rev b5ce87f84d9de0a5347ab38c0567a5a70d1fbfd7) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockReportRateLimiting.java Block report lease may leak if the 2nd full block report comes when NN is still in safemode --- Key: HDFS-8930 URL: https://issues.apache.org/jira/browse/HDFS-8930 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 2.8.0 Reporter: Jing Zhao Assignee: Jing Zhao Priority: Minor Fix For: 2.8.0 Attachments: HDFS-8930.000.patch This is a rare scenario in practice. If the NameNode is still in startup SafeMode while a DataNode sends it the 2nd FBR, the NameNode assigns the lease but rejects the report. The lease then leaves in NN until it expires. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8930) Block report lease may leak if the 2nd full block report comes when NN is still in safemode
[
https://issues.apache.org/jira/browse/HDFS-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707519#comment-14707519
]
Hadoop QA commented on HDFS-8930:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 21m 16s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 9m 4s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 11m 41s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 28s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 38s | The applied patch generated 1
new checkstyle issues (total was 196, now 196). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 2m 0s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 41s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 2m 45s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 12s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 69m 6s | Tests failed in hadoop-hdfs. |
| | | 121m 56s | |
\\
\\
|| Reason || Tests ||
| Timed out tests | org.apache.hadoop.hdfs.TestBlockReaderLocal |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12751611/HDFS-8930.000.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 22de7c1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/12076/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12076/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/12076/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/12076/console |
This message was automatically generated.
Block report lease may leak if the 2nd full block report comes when NN is
still in safemode
---
Key: HDFS-8930
URL: https://issues.apache.org/jira/browse/HDFS-8930
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 2.8.0
Reporter: Jing Zhao
Assignee: Jing Zhao
Priority: Minor
Attachments: HDFS-8930.000.patch
This is a rare scenario in practice. If the NameNode is still in startup
SafeMode while a DataNode sends it the 2nd FBR, the NameNode assigns the
lease but rejects the report. The lease then leaves in NN until it expires.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8930) Block report lease may leak if the 2nd full block report comes when NN is still in safemode
[
https://issues.apache.org/jira/browse/HDFS-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705942#comment-14705942
]
Jing Zhao commented on HDFS-8930:
-
A simple fix can be removing the lease in this scenario:
{code}
---
a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
+++
b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
@@ -1850,6 +1850,7 @@ public boolean processReport(final DatanodeID nodeID,
blockLog.info(BLOCK* processReport:
+ discarded non-initial block report from {}
+ because namenode still in startup phase, nodeID);
+blockReportLeaseManager.removeLease(node);
return !node.hasStaleStorages();
}
{code}
Block report lease may leak if the 2nd full block report comes when NN is
still in safemode
---
Key: HDFS-8930
URL: https://issues.apache.org/jira/browse/HDFS-8930
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Jing Zhao
Priority: Minor
This is a rare scenario in practice. If the NameNode is still in startup
SafeMode while a DataNode sends it the 2nd FBR, the NameNode assigns the
lease but rejects the report. The lease then leaves in NN until it expires.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
