[jira] [Commented] (HDFS-9024) Deprecate TotalFiles metric
[ https://issues.apache.org/jira/browse/HDFS-9024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021622#comment-15021622 ] Haohui Mai commented on HDFS-9024: -- +1 > Deprecate TotalFiles metric > --- > > Key: HDFS-9024 > URL: https://issues.apache.org/jira/browse/HDFS-9024 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Akira AJISAKA >Assignee: Akira AJISAKA > Labels: metrics > Attachments: HDFS-9024.001.patch, HDFS-9024.002.patch > > > There are two metrics (TotalFiles and FilesTotal) which are the same. In > HDFS-5165, we decided to remove TotalFiles but we need to deprecate the > metric before removing it. This issue is to deprecate the metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9024) Deprecate TotalFiles metric
[
https://issues.apache.org/jira/browse/HDFS-9024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730894#comment-14730894
]
Hadoop QA commented on HDFS-9024:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 23m 3s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 51s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 7s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 24s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | site | 3m 2s | Site still builds. |
| {color:red}-1{color} | checkstyle | 2m 26s | The applied patch generated 2
new checkstyle issues (total was 344, now 345). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 28s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 4m 23s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests | 23m 42s | Tests passed in
hadoop-common. |
| {color:red}-1{color} | hdfs tests | 188m 46s | Tests failed in hadoop-hdfs. |
| | | 265m 50s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.blockmanagement.TestBlockManager |
| | hadoop.hdfs.server.namenode.TestFileTruncate |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12754173/HDFS-9024.001.patch |
| Optional Tests | site javadoc javac unit findbugs checkstyle |
| git revision | trunk / 40d222e |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/12305/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12305/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12305/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/12305/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/12305/console |
This message was automatically generated.
> Deprecate TotalFiles metric
> ---
>
> Key: HDFS-9024
> URL: https://issues.apache.org/jira/browse/HDFS-9024
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Akira AJISAKA
>Assignee: Akira AJISAKA
> Labels: metrics
> Attachments: HDFS-9024.001.patch
>
>
> There are two metrics (TotalFiles and FilesTotal) which are the same. In
> HDFS-5165, we decided to remove TotalFiles but we need to deprecate the
> metric before removing it. This issue is to deprecate the metric.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9024) Deprecate TotalFiles metric
[ https://issues.apache.org/jira/browse/HDFS-9024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737295#comment-14737295 ] Daniel Templeton commented on HDFS-9024: In general the patch looks fine to me. Note that there is still a "TotalFiles" attribute in the fls.slive stuff in the MR job client test classes. Unrelated, but a potential source of confusion someone should think about resolving some day. The second checkstyle comment needs to be addressed. > Deprecate TotalFiles metric > --- > > Key: HDFS-9024 > URL: https://issues.apache.org/jira/browse/HDFS-9024 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Akira AJISAKA >Assignee: Akira AJISAKA > Labels: metrics > Attachments: HDFS-9024.001.patch > > > There are two metrics (TotalFiles and FilesTotal) which are the same. In > HDFS-5165, we decided to remove TotalFiles but we need to deprecate the > metric before removing it. This issue is to deprecate the metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9024) Deprecate TotalFiles metric
[
https://issues.apache.org/jira/browse/HDFS-9024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738574#comment-14738574
]
Hadoop QA commented on HDFS-9024:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 26m 52s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 9m 33s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 12s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | site | 3m 5s | Site still builds. |
| {color:red}-1{color} | checkstyle | 2m 41s | The applied patch generated 2
new checkstyle issues (total was 342, now 343). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 26s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 4m 23s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests | 23m 24s | Tests passed in
hadoop-common. |
| {color:red}-1{color} | hdfs tests | 0m 20s | Tests failed in hadoop-hdfs. |
| | | 82m 57s | |
\\
\\
|| Reason || Tests ||
| Failed build | hadoop-hdfs |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12755087/HDFS-9024.002.patch |
| Optional Tests | site javadoc javac unit findbugs checkstyle |
| git revision | trunk / 7b5b2c5 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/12370/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12370/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12370/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/12370/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/12370/console |
This message was automatically generated.
> Deprecate TotalFiles metric
> ---
>
> Key: HDFS-9024
> URL: https://issues.apache.org/jira/browse/HDFS-9024
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Akira AJISAKA
>Assignee: Akira AJISAKA
> Labels: metrics
> Attachments: HDFS-9024.001.patch, HDFS-9024.002.patch
>
>
> There are two metrics (TotalFiles and FilesTotal) which are the same. In
> HDFS-5165, we decided to remove TotalFiles but we need to deprecate the
> metric before removing it. This issue is to deprecate the metric.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9024) Deprecate TotalFiles metric
[ https://issues.apache.org/jira/browse/HDFS-9024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738729#comment-14738729 ] Vinayakumar B commented on HDFS-9024: - Also how about updating the UI related files with 'FilesTotal', where this is used? > Deprecate TotalFiles metric > --- > > Key: HDFS-9024 > URL: https://issues.apache.org/jira/browse/HDFS-9024 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Akira AJISAKA >Assignee: Akira AJISAKA > Labels: metrics > Attachments: HDFS-9024.001.patch, HDFS-9024.002.patch > > > There are two metrics (TotalFiles and FilesTotal) which are the same. In > HDFS-5165, we decided to remove TotalFiles but we need to deprecate the > metric before removing it. This issue is to deprecate the metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9024) Deprecate TotalFiles metric
[ https://issues.apache.org/jira/browse/HDFS-9024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739345#comment-14739345 ] Daniel Templeton commented on HDFS-9024: I don't see any UI files that use TotalFiles. Did you have something specific in mind? > Deprecate TotalFiles metric > --- > > Key: HDFS-9024 > URL: https://issues.apache.org/jira/browse/HDFS-9024 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Akira AJISAKA >Assignee: Akira AJISAKA > Labels: metrics > Attachments: HDFS-9024.001.patch, HDFS-9024.002.patch > > > There are two metrics (TotalFiles and FilesTotal) which are the same. In > HDFS-5165, we decided to remove TotalFiles but we need to deprecate the > metric before removing it. This issue is to deprecate the metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9024) Deprecate TotalFiles metric
[ https://issues.apache.org/jira/browse/HDFS-9024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739456#comment-14739456 ] Vinayakumar B commented on HDFS-9024: - oops, I got confused. Thought dfshealth,html using TotalFiles. But its using FilesTotal, Good to go. > Deprecate TotalFiles metric > --- > > Key: HDFS-9024 > URL: https://issues.apache.org/jira/browse/HDFS-9024 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Akira AJISAKA >Assignee: Akira AJISAKA > Labels: metrics > Attachments: HDFS-9024.001.patch, HDFS-9024.002.patch > > > There are two metrics (TotalFiles and FilesTotal) which are the same. In > HDFS-5165, we decided to remove TotalFiles but we need to deprecate the > metric before removing it. This issue is to deprecate the metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9024) Deprecate TotalFiles metric
[ https://issues.apache.org/jira/browse/HDFS-9024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739747#comment-14739747 ] Daniel Templeton commented on HDFS-9024: Not sure why the build failed for the tests in Jenkins. The build with this patch works for me. Looks fine. +1 (non-binding) > Deprecate TotalFiles metric > --- > > Key: HDFS-9024 > URL: https://issues.apache.org/jira/browse/HDFS-9024 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Akira AJISAKA >Assignee: Akira AJISAKA > Labels: metrics > Attachments: HDFS-9024.001.patch, HDFS-9024.002.patch > > > There are two metrics (TotalFiles and FilesTotal) which are the same. In > HDFS-5165, we decided to remove TotalFiles but we need to deprecate the > metric before removing it. This issue is to deprecate the metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
