[jira] [Commented] (HDFS-9264) Minor cleanup of operations on FsVolumeList#volumes
[ https://issues.apache.org/jira/browse/HDFS-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972243#comment-14972243 ] Hudson commented on HDFS-9264: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2467 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2467/]) HDFS-9264. Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java > Minor cleanup of operations on FsVolumeList#volumes > --- > > Key: HDFS-9264 > URL: https://issues.apache.org/jira/browse/HDFS-9264 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Walter Su >Assignee: Walter Su >Priority: Minor > Fix For: 3.0.0, 2.8.0 > > Attachments: HDFS-9264.01.patch, HDFS-9264.02.patch > > > We can use {{CopyOnWriteArrayList}} to simplify the operations on > {{FsVolumeList#volumes}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9264) Minor cleanup of operations on FsVolumeList#volumes
[ https://issues.apache.org/jira/browse/HDFS-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972201#comment-14972201 ] Hudson commented on HDFS-9264: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #531 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/531/]) HDFS-9264. Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java > Minor cleanup of operations on FsVolumeList#volumes > --- > > Key: HDFS-9264 > URL: https://issues.apache.org/jira/browse/HDFS-9264 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Walter Su >Assignee: Walter Su >Priority: Minor > Fix For: 3.0.0, 2.8.0 > > Attachments: HDFS-9264.01.patch, HDFS-9264.02.patch > > > We can use {{CopyOnWriteArrayList}} to simplify the operations on > {{FsVolumeList#volumes}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9264) Minor cleanup of operations on FsVolumeList#volumes
[ https://issues.apache.org/jira/browse/HDFS-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972118#comment-14972118 ] Hudson commented on HDFS-9264: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2521 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2521/]) HDFS-9264. Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Minor cleanup of operations on FsVolumeList#volumes > --- > > Key: HDFS-9264 > URL: https://issues.apache.org/jira/browse/HDFS-9264 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Walter Su >Assignee: Walter Su >Priority: Minor > Fix For: 3.0.0, 2.8.0 > > Attachments: HDFS-9264.01.patch, HDFS-9264.02.patch > > > We can use {{CopyOnWriteArrayList}} to simplify the operations on > {{FsVolumeList#volumes}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9264) Minor cleanup of operations on FsVolumeList#volumes
[ https://issues.apache.org/jira/browse/HDFS-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972105#comment-14972105 ] Hudson commented on HDFS-9264: -- FAILURE: Integrated in Hadoop-Yarn-trunk #1312 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1312/]) HDFS-9264. Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java > Minor cleanup of operations on FsVolumeList#volumes > --- > > Key: HDFS-9264 > URL: https://issues.apache.org/jira/browse/HDFS-9264 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Walter Su >Assignee: Walter Su >Priority: Minor > Fix For: 3.0.0, 2.8.0 > > Attachments: HDFS-9264.01.patch, HDFS-9264.02.patch > > > We can use {{CopyOnWriteArrayList}} to simplify the operations on > {{FsVolumeList#volumes}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9264) Minor cleanup of operations on FsVolumeList#volumes
[ https://issues.apache.org/jira/browse/HDFS-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971999#comment-14971999 ] Hudson commented on HDFS-9264: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #589 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/589/]) HDFS-9264. Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Minor cleanup of operations on FsVolumeList#volumes > --- > > Key: HDFS-9264 > URL: https://issues.apache.org/jira/browse/HDFS-9264 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Walter Su >Assignee: Walter Su >Priority: Minor > Fix For: 3.0.0, 2.8.0 > > Attachments: HDFS-9264.01.patch, HDFS-9264.02.patch > > > We can use {{CopyOnWriteArrayList}} to simplify the operations on > {{FsVolumeList#volumes}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9264) Minor cleanup of operations on FsVolumeList#volumes
[ https://issues.apache.org/jira/browse/HDFS-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971967#comment-14971967 ] Hudson commented on HDFS-9264: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #576 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/576/]) HDFS-9264. Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Minor cleanup of operations on FsVolumeList#volumes > --- > > Key: HDFS-9264 > URL: https://issues.apache.org/jira/browse/HDFS-9264 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Walter Su >Assignee: Walter Su >Priority: Minor > Fix For: 3.0.0, 2.8.0 > > Attachments: HDFS-9264.01.patch, HDFS-9264.02.patch > > > We can use {{CopyOnWriteArrayList}} to simplify the operations on > {{FsVolumeList#volumes}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9264) Minor cleanup of operations on FsVolumeList#volumes
[ https://issues.apache.org/jira/browse/HDFS-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971853#comment-14971853 ] Hudson commented on HDFS-9264: -- FAILURE: Integrated in Hadoop-trunk-Commit #8697 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8697/]) HDFS-9264. Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Minor cleanup of operations on FsVolumeList#volumes > --- > > Key: HDFS-9264 > URL: https://issues.apache.org/jira/browse/HDFS-9264 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Walter Su >Assignee: Walter Su >Priority: Minor > Fix For: 3.0.0, 2.8.0 > > Attachments: HDFS-9264.01.patch, HDFS-9264.02.patch > > > We can use {{CopyOnWriteArrayList}} to simplify the operations on > {{FsVolumeList#volumes}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9264) Minor cleanup of operations on FsVolumeList#volumes
[ https://issues.apache.org/jira/browse/HDFS-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965991#comment-14965991 ] Lei (Eddy) Xu commented on HDFS-9264: - Thanks a lot for cleanup the code. It LGTM. +1 > Minor cleanup of operations on FsVolumeList#volumes > --- > > Key: HDFS-9264 > URL: https://issues.apache.org/jira/browse/HDFS-9264 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Walter Su >Assignee: Walter Su >Priority: Minor > Attachments: HDFS-9264.01.patch, HDFS-9264.02.patch > > > We can use {{CopyOnWriteArrayList}} to simplify the operations on > {{FsVolumeList#volumes}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9264) Minor cleanup of operations on FsVolumeList#volumes
[ https://issues.apache.org/jira/browse/HDFS-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964526#comment-14964526 ] Hadoop QA commented on HDFS-9264: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | pre-patch | 20m 27s | Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | | {color:green}+1{color} | javac | 9m 0s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 11m 55s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 29s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 1m 44s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 43s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 38s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 2m 48s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | native | 3m 32s | Pre-build of native portion | | {color:red}-1{color} | hdfs tests | 55m 15s | Tests failed in hadoop-hdfs. | | | | 107m 38s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.hdfs.TestDFSUpgradeFromImage | | | hadoop.hdfs.TestReplaceDatanodeOnFailure | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12767524/HDFS-9264.02.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 7e2837f | | Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/13069/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/13069/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/13069/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/13069/console | This message was automatically generated. > Minor cleanup of operations on FsVolumeList#volumes > --- > > Key: HDFS-9264 > URL: https://issues.apache.org/jira/browse/HDFS-9264 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Walter Su >Assignee: Walter Su >Priority: Minor > Attachments: HDFS-9264.01.patch, HDFS-9264.02.patch > > > We can use {{CopyOnWriteArrayList}} to simplify the operations on > {{FsVolumeList#volumes}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9264) Minor cleanup of operations on FsVolumeList#volumes
[ https://issues.apache.org/jira/browse/HDFS-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963564#comment-14963564 ] Hadoop QA commented on HDFS-9264: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | pre-patch | 18m 39s | Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | | {color:red}-1{color} | javac | 7m 54s | The applied patch generated 1 additional warning messages. | | {color:green}+1{color} | javadoc | 10m 24s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 1m 24s | The applied patch generated 10 new checkstyle issues (total was 6, now 15). | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 28s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 2m 31s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | native | 3m 13s | Pre-build of native portion | | {color:red}-1{color} | hdfs tests | 48m 51s | Tests failed in hadoop-hdfs. | | | | 95m 31s | | \\ \\ || Reason || Tests || | Timed out tests | org.apache.hadoop.hdfs.server.namenode.TestFileTruncate | | | org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate | | | org.apache.hadoop.hdfs.server.namenode.TestMetaSave | | | org.apache.hadoop.hdfs.server.namenode.TestAddStripedBlocks | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12767368/HDFS-9264.01.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 7f0e1eb | | Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/13049/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html | | javac | https://builds.apache.org/job/PreCommit-HDFS-Build/13049/artifact/patchprocess/diffJavacWarnings.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/13049/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/13049/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/13049/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/13049/console | This message was automatically generated. > Minor cleanup of operations on FsVolumeList#volumes > --- > > Key: HDFS-9264 > URL: https://issues.apache.org/jira/browse/HDFS-9264 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Walter Su >Assignee: Walter Su >Priority: Minor > Attachments: HDFS-9264.01.patch > > > We can use {{CopyOnWriteArrayList}} to simplify the operations on > {{FsVolumeList#volumes}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)