[jira] [Commented] (HDFS-9339) Extend full test of KMS ACLs
[ https://issues.apache.org/jira/browse/HDFS-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986730#comment-14986730 ] Hudson commented on HDFS-9339: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #565 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/565/]) HDFS-9339. Extend full test of KMS ACLs. Contributed by Daniel (zhz: rev 78d6890865424db850faecfc5c76f14c64925063) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestAclsEndToEnd.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Extend full test of KMS ACLs > > > Key: HDFS-9339 > URL: https://issues.apache.org/jira/browse/HDFS-9339 > Project: Hadoop HDFS > Issue Type: Test > Components: HDFS >Affects Versions: 2.7.1 >Reporter: Daniel Templeton >Assignee: Daniel Templeton > Fix For: 2.8.0 > > Attachments: HDFS-9339.001.patch, HDFS-9339.002.patch > > > HDFS-9295 adds an end-to-end test for KMS, but it is missing a dimension. > The tests added in that JIRA hold the configuration constant and test that > all operations succeed or fail as expected. More tests are needed that hold > the operation constant and test that all possible configurations cause the > operations to succeed or fail as expected. This JIRA is to add those tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9339) Extend full test of KMS ACLs
[ https://issues.apache.org/jira/browse/HDFS-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986315#comment-14986315 ] Hudson commented on HDFS-9339: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #629 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/629/]) HDFS-9339. Extend full test of KMS ACLs. Contributed by Daniel (zhz: rev 78d6890865424db850faecfc5c76f14c64925063) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestAclsEndToEnd.java > Extend full test of KMS ACLs > > > Key: HDFS-9339 > URL: https://issues.apache.org/jira/browse/HDFS-9339 > Project: Hadoop HDFS > Issue Type: Test > Components: HDFS >Affects Versions: 2.7.1 >Reporter: Daniel Templeton >Assignee: Daniel Templeton > Fix For: 2.8.0 > > Attachments: HDFS-9339.001.patch, HDFS-9339.002.patch > > > HDFS-9295 adds an end-to-end test for KMS, but it is missing a dimension. > The tests added in that JIRA hold the configuration constant and test that > all operations succeed or fail as expected. More tests are needed that hold > the operation constant and test that all possible configurations cause the > operations to succeed or fail as expected. This JIRA is to add those tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9339) Extend full test of KMS ACLs
[ https://issues.apache.org/jira/browse/HDFS-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986203#comment-14986203 ] Hudson commented on HDFS-9339: -- FAILURE: Integrated in Hadoop-trunk-Commit #8744 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8744/]) HDFS-9339. Extend full test of KMS ACLs. Contributed by Daniel (zhz: rev 78d6890865424db850faecfc5c76f14c64925063) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestAclsEndToEnd.java > Extend full test of KMS ACLs > > > Key: HDFS-9339 > URL: https://issues.apache.org/jira/browse/HDFS-9339 > Project: Hadoop HDFS > Issue Type: Test > Components: HDFS >Affects Versions: 2.7.1 >Reporter: Daniel Templeton >Assignee: Daniel Templeton > Fix For: 2.8.0 > > Attachments: HDFS-9339.001.patch, HDFS-9339.002.patch > > > HDFS-9295 adds an end-to-end test for KMS, but it is missing a dimension. > The tests added in that JIRA hold the configuration constant and test that > all operations succeed or fail as expected. More tests are needed that hold > the operation constant and test that all possible configurations cause the > operations to succeed or fail as expected. This JIRA is to add those tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9339) Extend full test of KMS ACLs
[ https://issues.apache.org/jira/browse/HDFS-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986279#comment-14986279 ] Hudson commented on HDFS-9339: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #618 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/618/]) HDFS-9339. Extend full test of KMS ACLs. Contributed by Daniel (zhz: rev 78d6890865424db850faecfc5c76f14c64925063) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestAclsEndToEnd.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Extend full test of KMS ACLs > > > Key: HDFS-9339 > URL: https://issues.apache.org/jira/browse/HDFS-9339 > Project: Hadoop HDFS > Issue Type: Test > Components: HDFS >Affects Versions: 2.7.1 >Reporter: Daniel Templeton >Assignee: Daniel Templeton > Fix For: 2.8.0 > > Attachments: HDFS-9339.001.patch, HDFS-9339.002.patch > > > HDFS-9295 adds an end-to-end test for KMS, but it is missing a dimension. > The tests added in that JIRA hold the configuration constant and test that > all operations succeed or fail as expected. More tests are needed that hold > the operation constant and test that all possible configurations cause the > operations to succeed or fail as expected. This JIRA is to add those tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9339) Extend full test of KMS ACLs
[ https://issues.apache.org/jira/browse/HDFS-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986388#comment-14986388 ] Hudson commented on HDFS-9339: -- FAILURE: Integrated in Hadoop-Yarn-trunk #1352 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1352/]) HDFS-9339. Extend full test of KMS ACLs. Contributed by Daniel (zhz: rev 78d6890865424db850faecfc5c76f14c64925063) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestAclsEndToEnd.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Extend full test of KMS ACLs > > > Key: HDFS-9339 > URL: https://issues.apache.org/jira/browse/HDFS-9339 > Project: Hadoop HDFS > Issue Type: Test > Components: HDFS >Affects Versions: 2.7.1 >Reporter: Daniel Templeton >Assignee: Daniel Templeton > Fix For: 2.8.0 > > Attachments: HDFS-9339.001.patch, HDFS-9339.002.patch > > > HDFS-9295 adds an end-to-end test for KMS, but it is missing a dimension. > The tests added in that JIRA hold the configuration constant and test that > all operations succeed or fail as expected. More tests are needed that hold > the operation constant and test that all possible configurations cause the > operations to succeed or fail as expected. This JIRA is to add those tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9339) Extend full test of KMS ACLs
[ https://issues.apache.org/jira/browse/HDFS-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986564#comment-14986564 ] Hudson commented on HDFS-9339: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2501 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2501/]) HDFS-9339. Extend full test of KMS ACLs. Contributed by Daniel (zhz: rev 78d6890865424db850faecfc5c76f14c64925063) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestAclsEndToEnd.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Extend full test of KMS ACLs > > > Key: HDFS-9339 > URL: https://issues.apache.org/jira/browse/HDFS-9339 > Project: Hadoop HDFS > Issue Type: Test > Components: HDFS >Affects Versions: 2.7.1 >Reporter: Daniel Templeton >Assignee: Daniel Templeton > Fix For: 2.8.0 > > Attachments: HDFS-9339.001.patch, HDFS-9339.002.patch > > > HDFS-9295 adds an end-to-end test for KMS, but it is missing a dimension. > The tests added in that JIRA hold the configuration constant and test that > all operations succeed or fail as expected. More tests are needed that hold > the operation constant and test that all possible configurations cause the > operations to succeed or fail as expected. This JIRA is to add those tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9339) Extend full test of KMS ACLs
[ https://issues.apache.org/jira/browse/HDFS-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986567#comment-14986567 ] Hudson commented on HDFS-9339: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2560 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2560/]) HDFS-9339. Extend full test of KMS ACLs. Contributed by Daniel (zhz: rev 78d6890865424db850faecfc5c76f14c64925063) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestAclsEndToEnd.java > Extend full test of KMS ACLs > > > Key: HDFS-9339 > URL: https://issues.apache.org/jira/browse/HDFS-9339 > Project: Hadoop HDFS > Issue Type: Test > Components: HDFS >Affects Versions: 2.7.1 >Reporter: Daniel Templeton >Assignee: Daniel Templeton > Fix For: 2.8.0 > > Attachments: HDFS-9339.001.patch, HDFS-9339.002.patch > > > HDFS-9295 adds an end-to-end test for KMS, but it is missing a dimension. > The tests added in that JIRA hold the configuration constant and test that > all operations succeed or fail as expected. More tests are needed that hold > the operation constant and test that all possible configurations cause the > operations to succeed or fail as expected. This JIRA is to add those tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9339) Extend full test of KMS ACLs
[
https://issues.apache.org/jira/browse/HDFS-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980906#comment-14980906
]
Zhe Zhang commented on HDFS-9339:
-
Thanks Daniel! The patch looks pretty good. A few minor comments:
# Maybe we should improve the criteria in assertions?
{code}
try {
setup(conf);
assertTrue("Exception during key creation with correct config"
+ " using whitelist key ACLs", createKey(realUgi, KEY1, conf));
} finally {
teardown();
}
{code}
The test will pass if {{createKey}} throws an exception. A simple fix is to
{{fail()}} in the {{finally}} statement. But maybe there's a way to avoid
adding it in every {{finally}} statement.
# Since the above {{try-finally}} logic repeats many times we can also abstract
it out as a method.
# Looks like the {{// Correct config with blacklist}} {{//Missing GET_METADATA
KMS ACL}} sections are both repeated twice?
> Extend full test of KMS ACLs
>
>
> Key: HDFS-9339
> URL: https://issues.apache.org/jira/browse/HDFS-9339
> Project: Hadoop HDFS
> Issue Type: Test
> Components: HDFS
>Affects Versions: 2.7.1
>Reporter: Daniel Templeton
>Assignee: Daniel Templeton
> Attachments: HDFS-9339.001.patch
>
>
> HDFS-9295 adds an end-to-end test for KMS, but it is missing a dimension.
> The tests added in that JIRA hold the configuration constant and test that
> all operations succeed or fail as expected. More tests are needed that hold
> the operation constant and test that all possible configurations cause the
> operations to succeed or fail as expected. This JIRA is to add those tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9339) Extend full test of KMS ACLs
[ https://issues.apache.org/jira/browse/HDFS-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981239#comment-14981239 ] Daniel Templeton commented on HDFS-9339: 1. The createKey method is a local method that wraps the KeyProvider method. One of the things it does is return false if there's an exception. 2. It would be possible to abstract it out, but it would involve another anonymous inner class to perform the operations. I'm not sure that's an improvement. That's the way it's done in TestKMS, but I don't like it. :) 3. They aren't actually repeated. There are two different controlling ACLs, so one tests one ACL, and the other tests the other. > Extend full test of KMS ACLs > > > Key: HDFS-9339 > URL: https://issues.apache.org/jira/browse/HDFS-9339 > Project: Hadoop HDFS > Issue Type: Test > Components: HDFS >Affects Versions: 2.7.1 >Reporter: Daniel Templeton >Assignee: Daniel Templeton > Attachments: HDFS-9339.001.patch > > > HDFS-9295 adds an end-to-end test for KMS, but it is missing a dimension. > The tests added in that JIRA hold the configuration constant and test that > all operations succeed or fail as expected. More tests are needed that hold > the operation constant and test that all possible configurations cause the > operations to succeed or fail as expected. This JIRA is to add those tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9339) Extend full test of KMS ACLs
[ https://issues.apache.org/jira/browse/HDFS-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981299#comment-14981299 ] Daniel Templeton commented on HDFS-9339: bq. Maybe remove the try-finally and let the entire test fail if setup fails? If setup throws an exception, the exception isn't caught, so after executing the finally block, the exception will continue being passed up the stack, eventually causing the test to error. > Extend full test of KMS ACLs > > > Key: HDFS-9339 > URL: https://issues.apache.org/jira/browse/HDFS-9339 > Project: Hadoop HDFS > Issue Type: Test > Components: HDFS >Affects Versions: 2.7.1 >Reporter: Daniel Templeton >Assignee: Daniel Templeton > Attachments: HDFS-9339.001.patch > > > HDFS-9295 adds an end-to-end test for KMS, but it is missing a dimension. > The tests added in that JIRA hold the configuration constant and test that > all operations succeed or fail as expected. More tests are needed that hold > the operation constant and test that all possible configurations cause the > operations to succeed or fail as expected. This JIRA is to add those tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9339) Extend full test of KMS ACLs
[
https://issues.apache.org/jira/browse/HDFS-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981286#comment-14981286
]
Zhe Zhang commented on HDFS-9339:
-
bq. The createKey method is a local method that wraps the KeyProvider method.
One of the things it does is return false if there's an exception.
I see, so we {{try}} for {{setup}}. But should we consider the test pass if
{{setup}} fails from an exception (and therefore the {{assertTrue}} is not
visited)? Maybe remove the {{try-finally}} and let the entire test fail if
{{setup}} fails?
bq. It would be possible to abstract it out, but it would involve another
anonymous inner class
I see, thanks for explaining.
bq. They aren't actually repeated.
My bad, spotted the differences now.
+1 pending a conclusion on the first point.
> Extend full test of KMS ACLs
>
>
> Key: HDFS-9339
> URL: https://issues.apache.org/jira/browse/HDFS-9339
> Project: Hadoop HDFS
> Issue Type: Test
> Components: HDFS
>Affects Versions: 2.7.1
>Reporter: Daniel Templeton
>Assignee: Daniel Templeton
> Attachments: HDFS-9339.001.patch
>
>
> HDFS-9295 adds an end-to-end test for KMS, but it is missing a dimension.
> The tests added in that JIRA hold the configuration constant and test that
> all operations succeed or fail as expected. More tests are needed that hold
> the operation constant and test that all possible configurations cause the
> operations to succeed or fail as expected. This JIRA is to add those tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9339) Extend full test of KMS ACLs
[
https://issues.apache.org/jira/browse/HDFS-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981349#comment-14981349
]
Zhe Zhang commented on HDFS-9339:
-
Ah thanks, my bad. Then maybe we should {{try-finally}} for the entire test?
> Extend full test of KMS ACLs
>
>
> Key: HDFS-9339
> URL: https://issues.apache.org/jira/browse/HDFS-9339
> Project: Hadoop HDFS
> Issue Type: Test
> Components: HDFS
>Affects Versions: 2.7.1
>Reporter: Daniel Templeton
>Assignee: Daniel Templeton
> Attachments: HDFS-9339.001.patch
>
>
> HDFS-9295 adds an end-to-end test for KMS, but it is missing a dimension.
> The tests added in that JIRA hold the configuration constant and test that
> all operations succeed or fail as expected. More tests are needed that hold
> the operation constant and test that all possible configurations cause the
> operations to succeed or fail as expected. This JIRA is to add those tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
