[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[ https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047776#comment-15047776 ] Hudson commented on HDFS-9414: -- ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #676 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/676/]) HDFS-9414. Refactor reconfiguration of ClientDatanodeProtocol for (cnauroth: rev 303f80e6567023985f00e5f33ff41a7bbb4d6072) * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ReconfigurationProtocol.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolServerSideUtils.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolPB.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/package-info.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolUtils.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java > Refactor reconfiguration of ClientDatanodeProtocol for reusability > -- > > Key: HDFS-9414 > URL: https://issues.apache.org/jira/browse/HDFS-9414 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Fix For: 2.9.0 > > Attachments: HDFS-9414.001.patch, HDFS-9414.002.patch, > HDFS-9414.003.patch, HDFS-9414.004.patch > > > Since reconfiguration is reused by both DataNode and NameNode, this work > proposes to refactor that part in ClientDatanodeProtocol to be reused by > dedicated ReconfigurationProtocol. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[ https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047323#comment-15047323 ] Hudson commented on HDFS-9414: -- FAILURE: Integrated in Hadoop-trunk-Commit #8939 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8939/]) HDFS-9414. Refactor reconfiguration of ClientDatanodeProtocol for (cnauroth: rev 303f80e6567023985f00e5f33ff41a7bbb4d6072) * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolPB.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolServerSideUtils.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/package-info.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolUtils.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ReconfigurationProtocol.java > Refactor reconfiguration of ClientDatanodeProtocol for reusability > -- > > Key: HDFS-9414 > URL: https://issues.apache.org/jira/browse/HDFS-9414 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Fix For: 2.9.0 > > Attachments: HDFS-9414.001.patch, HDFS-9414.002.patch, > HDFS-9414.003.patch, HDFS-9414.004.patch > > > Since reconfiguration is reused by both DataNode and NameNode, this work > proposes to refactor that part in ClientDatanodeProtocol to be reused by > dedicated ReconfigurationProtocol. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[ https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047224#comment-15047224 ] Xiaobing Zhou commented on HDFS-9414: - The test failures are not related to V004. > Refactor reconfiguration of ClientDatanodeProtocol for reusability > -- > > Key: HDFS-9414 > URL: https://issues.apache.org/jira/browse/HDFS-9414 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Fix For: 2.9.0 > > Attachments: HDFS-9414.001.patch, HDFS-9414.002.patch, > HDFS-9414.003.patch, HDFS-9414.004.patch > > > Since reconfiguration is reused by both DataNode and NameNode, this work > proposes to refactor that part in ClientDatanodeProtocol to be reused by > dedicated ReconfigurationProtocol. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[
https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046123#comment-15046123
]
Hadoop QA commented on HDFS-9414:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
9s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 26s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 29s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 28s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
45s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 13s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
22s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 27s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 27s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 30s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 30s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 25s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 2s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 24s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 13s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 52s
{color} | {color:green} hadoop-hdfs-client in the patch passed with JDK
v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 65m 59s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.8.0_66. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 58s
{color} | {color:green} hadoop-hdfs-client in the patch passed with JDK
v1.7.0_91. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 68m 41s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.7.0_91. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 21s
{color} | {color:red} Patch generated 58 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 174m 55s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_66 Failed junit tests |
hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits |
| | hadoop.hdfs.server.namenode.TestBackupNode |
| | hadoop.hdfs.TestErasureCodeBenchmarkThroughput |
|
[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[ https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045880#comment-15045880 ] Xiaobing Zhou commented on HDFS-9414: - Thanks [~Naganarasimha] and [~arpitagarwal]. V004 only fixed the checkstyle issues. > Refactor reconfiguration of ClientDatanodeProtocol for reusability > -- > > Key: HDFS-9414 > URL: https://issues.apache.org/jira/browse/HDFS-9414 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Fix For: 2.9.0 > > Attachments: HDFS-9414.001.patch, HDFS-9414.002.patch, > HDFS-9414.003.patch, HDFS-9414.004.patch > > > Since reconfiguration is reused by both DataNode and NameNode, this work > proposes to refactor that part in ClientDatanodeProtocol to be reused by > dedicated ReconfigurationProtocol. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[ https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043523#comment-15043523 ] Hudson commented on HDFS-9414: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #669 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/669/]) HDFS-9414. Add missing license header (arp: rev 42d49016d4128eff71a7d1f8365be9ea9d222070) * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ReconfigurationProtocol.java > Refactor reconfiguration of ClientDatanodeProtocol for reusability > -- > > Key: HDFS-9414 > URL: https://issues.apache.org/jira/browse/HDFS-9414 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Fix For: 2.9.0 > > Attachments: HDFS-9414.001.patch, HDFS-9414.002.patch, > HDFS-9414.003.patch > > > Since reconfiguration is reused by both DataNode and NameNode, this work > proposes to refactor that part in ClientDatanodeProtocol to be reused by > dedicated ReconfigurationProtocol. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[ https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043396#comment-15043396 ] Hudson commented on HDFS-9414: -- FAILURE: Integrated in Hadoop-trunk-Commit #8929 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8929/]) HDFS-9414. Add missing license header (arp: rev 42d49016d4128eff71a7d1f8365be9ea9d222070) * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ReconfigurationProtocol.java > Refactor reconfiguration of ClientDatanodeProtocol for reusability > -- > > Key: HDFS-9414 > URL: https://issues.apache.org/jira/browse/HDFS-9414 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Fix For: 2.9.0 > > Attachments: HDFS-9414.001.patch, HDFS-9414.002.patch, > HDFS-9414.003.patch > > > Since reconfiguration is reused by both DataNode and NameNode, this work > proposes to refactor that part in ClientDatanodeProtocol to be reused by > dedicated ReconfigurationProtocol. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[ https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043394#comment-15043394 ] Arpit Agarwal commented on HDFS-9414: - Thanks [~Naganarasimha]. My bad for missing those. I've rectified the license warning. [~xiaobingo], can you please attach a patch to address the remaining check style issues. > Refactor reconfiguration of ClientDatanodeProtocol for reusability > -- > > Key: HDFS-9414 > URL: https://issues.apache.org/jira/browse/HDFS-9414 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Fix For: 2.9.0 > > Attachments: HDFS-9414.001.patch, HDFS-9414.002.patch, > HDFS-9414.003.patch > > > Since reconfiguration is reused by both DataNode and NameNode, this work > proposes to refactor that part in ClientDatanodeProtocol to be reused by > dedicated ReconfigurationProtocol. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[ https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042797#comment-15042797 ] Hudson commented on HDFS-9414: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #668 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/668/]) HDFS-9414. Refactor reconfiguration of ClientDatanodeProtocol for (arp: rev 86c95cb31a392d2ee4dcf3cc36e924ad34000b27) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ReconfigurationProtocol.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolServerSideUtils.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolPB.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolServerSideTranslatorPB.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolTranslatorPB.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/ReconfigurationProtocol.proto * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java * hadoop-hdfs-project/hadoop-hdfs-client/pom.xml * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolUtils.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/ClientDatanodeProtocol.proto > Refactor reconfiguration of ClientDatanodeProtocol for reusability > -- > > Key: HDFS-9414 > URL: https://issues.apache.org/jira/browse/HDFS-9414 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Fix For: 2.9.0 > > Attachments: HDFS-9414.001.patch, HDFS-9414.002.patch, > HDFS-9414.003.patch > > > Since reconfiguration is reused by both DataNode and NameNode, this work > proposes to refactor that part in ClientDatanodeProtocol to be reused by > dedicated ReconfigurationProtocol. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[ https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042693#comment-15042693 ] Hudson commented on HDFS-9414: -- FAILURE: Integrated in Hadoop-trunk-Commit #8928 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8928/]) HDFS-9414. Refactor reconfiguration of ClientDatanodeProtocol for (arp: rev 86c95cb31a392d2ee4dcf3cc36e924ad34000b27) * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ReconfigurationProtocol.java * hadoop-hdfs-project/hadoop-hdfs-client/pom.xml * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolPB.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolUtils.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolTranslatorPB.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/ReconfigurationProtocol.proto * hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/ClientDatanodeProtocol.proto * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolServerSideTranslatorPB.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ReconfigurationProtocolServerSideUtils.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java > Refactor reconfiguration of ClientDatanodeProtocol for reusability > -- > > Key: HDFS-9414 > URL: https://issues.apache.org/jira/browse/HDFS-9414 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Fix For: 2.9.0 > > Attachments: HDFS-9414.001.patch, HDFS-9414.002.patch, > HDFS-9414.003.patch > > > Since reconfiguration is reused by both DataNode and NameNode, this work > proposes to refactor that part in ClientDatanodeProtocol to be reused by > dedicated ReconfigurationProtocol. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[ https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042642#comment-15042642 ] Arpit Agarwal commented on HDFS-9414: - This is a refactoring change so no new unit tests required. The test failures look unrelated. I will commit it shortly. > Refactor reconfiguration of ClientDatanodeProtocol for reusability > -- > > Key: HDFS-9414 > URL: https://issues.apache.org/jira/browse/HDFS-9414 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HDFS-9414.001.patch, HDFS-9414.002.patch, > HDFS-9414.003.patch > > > Since reconfiguration is reused by both DataNode and NameNode, this work > proposes to refactor that part in ClientDatanodeProtocol to be reused by > dedicated ReconfigurationProtocol. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[
https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042638#comment-15042638
]
Hadoop QA commented on HDFS-9414:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
17s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 35s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 36s
{color} | {color:green} trunk passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 32s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
27s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
59s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 33s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 16s
{color} | {color:green} trunk passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
28s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 35s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 35s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 35s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 39s
{color} | {color:green} the patch passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 39s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 39s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 22s
{color} | {color:red} Patch generated 7 new checkstyle issues in
hadoop-hdfs-project (total was 142, now 148). {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 29s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
27s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 0s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
18s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 30s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 19s
{color} | {color:green} the patch passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 58s
{color} | {color:green} hadoop-hdfs-client in the patch passed with JDK
v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 68m 53s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.8.0_66. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 6s
{color} | {color:green} hadoop-hdfs-client in the patch passed with JDK
v1.7.0_85. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 66m 27s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.7.0_85. {color} |
| {color:red}-1{color} |
[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[ https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042473#comment-15042473 ] Arpit Agarwal commented on HDFS-9414: - +1 for the v002 patch pending Jenkins. > Refactor reconfiguration of ClientDatanodeProtocol for reusability > -- > > Key: HDFS-9414 > URL: https://issues.apache.org/jira/browse/HDFS-9414 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HDFS-9414.001.patch, HDFS-9414.002.patch, > HDFS-9414.003.patch > > > Since reconfiguration is reused by both DataNode and NameNode, this work > proposes to refactor that part in ClientDatanodeProtocol to be reused by > dedicated ReconfigurationProtocol. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[ https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042444#comment-15042444 ] Arpit Agarwal commented on HDFS-9414: - [~xiaobingo] thanks for the v002 patch. I believe this will not introduce any wire incompatibility. I am reviewing it. Meanwhile can you please take a look at the checkstyle warnings and fix those that are valid. > Refactor reconfiguration of ClientDatanodeProtocol for reusability > -- > > Key: HDFS-9414 > URL: https://issues.apache.org/jira/browse/HDFS-9414 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HDFS-9414.001.patch, HDFS-9414.002.patch > > > Since reconfiguration is reused by both DataNode and NameNode, this work > proposes to refactor that part in ClientDatanodeProtocol to be reused by > dedicated ReconfigurationProtocol. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[
https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042393#comment-15042393
]
Hadoop QA commented on HDFS-9414:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
7s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 38s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 41s
{color} | {color:green} trunk passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 34s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
58s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 40s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 25s
{color} | {color:green} trunk passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 46s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 46s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 46s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 39s
{color} | {color:green} the patch passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 39s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 39s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 25s
{color} | {color:red} Patch generated 19 new checkstyle issues in
hadoop-hdfs-project (total was 142, now 160). {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 32s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
27s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 0s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
16s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 31s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 20s
{color} | {color:green} the patch passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 56s
{color} | {color:green} hadoop-hdfs-client in the patch passed with JDK
v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 67m 10s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.8.0_66. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 1s
{color} | {color:green} hadoop-hdfs-client in the patch passed with JDK
v1.7.0_85. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 72m 9s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.7.0_85. {color} |
| {color:red}-1{color} | {
[jira] [Commented] (HDFS-9414) Refactor reconfiguration of ClientDatanodeProtocol for reusability
[ https://issues.apache.org/jira/browse/HDFS-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042025#comment-15042025 ] Xiaobing Zhou commented on HDFS-9414: - V002 patch: 1. kept all interfaces in ClientDatanodeProtocol unchanged 2. removed definition of protobuf type(e.g. request/response) to ReconfigurationProtocol.proto 3. delegated partial implementation in ClientDatanodeProtocol to ReconfigurationProtocol utilities. The tests are covered by TestDFSAdmin not changed. > Refactor reconfiguration of ClientDatanodeProtocol for reusability > -- > > Key: HDFS-9414 > URL: https://issues.apache.org/jira/browse/HDFS-9414 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HDFS-9414.001.patch, HDFS-9414.002.patch > > > Since reconfiguration is reused by both DataNode and NameNode, this work > proposes to refactor that part in ClientDatanodeProtocol to be reused by > dedicated ReconfigurationProtocol. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
