[jira] [Commented] (HDFS-9637) Tests for RollingFileSystemSink
[ https://issues.apache.org/jira/browse/HDFS-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141426#comment-15141426 ] Hudson commented on HDFS-9637: -- FAILURE: Integrated in Hadoop-trunk-Commit #9277 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9277/]) HDFS-9637. Tests for RollingFileSystemSink. (Daniel Templeton via kasha) (kasha: rev bc425a623fd06c4f56106fb2ea662b19e4434d11) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/metrics2/sink/TestRollingFileSystemSinkWithHdfs.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Tests for RollingFileSystemSink > --- > > Key: HDFS-9637 > URL: https://issues.apache.org/jira/browse/HDFS-9637 > Project: Hadoop HDFS > Issue Type: Improvement > Components: test >Affects Versions: 2.7.1 >Reporter: Daniel Templeton >Assignee: Daniel Templeton > Attachments: HDFS-9637.001.patch, HDFS-9637.002.patch, > HDFS-9637.003.patch, HDFS-9637.004.patch, HDFS-9637.005.patch, > HDFS-9637.006.patch > > > Per discussion on the dev list, the tests for the new FileSystemSink class > should be added to the HDFS project to avoid creating a dependency for the > common project on the HDFS project. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9637) Tests for RollingFileSystemSink
[
https://issues.apache.org/jira/browse/HDFS-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141384#comment-15141384
]
Karthik Kambatla commented on HDFS-9637:
Committed this to trunk.
On branch-2, one of the newly added tests fails:
{noformat}
Running org.apache.hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs
Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 39.088 sec <<<
FAILURE! - in org.apache.hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs
testFailedClose(org.apache.hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs)
Time elapsed: 1.385 sec <<< ERROR!
org.apache.hadoop.metrics2.MetricsException:
org.apache.hadoop.metrics2.MetricsException: Unable to close log file:
hdfs://localhost:51275/tmp/2016021018/testsrc-saya.local.log
at
org.apache.hadoop.metrics2.sink.RollingFileSystemSink.checkForErrors(RollingFileSystemSink.java:512)
at
org.apache.hadoop.metrics2.sink.RollingFileSystemSink.close(RollingFileSystemSink.java:488)
at
org.apache.hadoop.metrics2.sink.RollingFileSystemSinkTestBase$ErrorSink.close(RollingFileSystemSinkTestBase.java:498)
at org.apache.hadoop.io.IOUtils.cleanup(IOUtils.java:245)
at
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.stop(MetricsSinkAdapter.java:213)
at
org.apache.hadoop.metrics2.impl.MetricsSystemImpl.stopSinks(MetricsSystemImpl.java:471)
at
org.apache.hadoop.metrics2.impl.MetricsSystemImpl.stop(MetricsSystemImpl.java:214)
at
org.apache.hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs.testFailedClose(TestRollingFileSystemSinkWithHdfs.java:183)
{noformat}
> Tests for RollingFileSystemSink
> ---
>
> Key: HDFS-9637
> URL: https://issues.apache.org/jira/browse/HDFS-9637
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
>Affects Versions: 2.7.1
>Reporter: Daniel Templeton
>Assignee: Daniel Templeton
> Attachments: HDFS-9637.001.patch, HDFS-9637.002.patch,
> HDFS-9637.003.patch, HDFS-9637.004.patch, HDFS-9637.005.patch,
> HDFS-9637.006.patch
>
>
> Per discussion on the dev list, the tests for the new FileSystemSink class
> should be added to the HDFS project to avoid creating a dependency for the
> common project on the HDFS project.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9637) Tests for RollingFileSystemSink
[ https://issues.apache.org/jira/browse/HDFS-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141364#comment-15141364 ] Karthik Kambatla commented on HDFS-9637: +1, checking the latest patch in. > Tests for RollingFileSystemSink > --- > > Key: HDFS-9637 > URL: https://issues.apache.org/jira/browse/HDFS-9637 > Project: Hadoop HDFS > Issue Type: Improvement > Components: test >Affects Versions: 2.7.1 >Reporter: Daniel Templeton >Assignee: Daniel Templeton > Attachments: HDFS-9637.001.patch, HDFS-9637.002.patch, > HDFS-9637.003.patch, HDFS-9637.004.patch, HDFS-9637.005.patch, > HDFS-9637.006.patch > > > Per discussion on the dev list, the tests for the new FileSystemSink class > should be added to the HDFS project to avoid creating a dependency for the > common project on the HDFS project. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9637) Tests for RollingFileSystemSink
[
https://issues.apache.org/jira/browse/HDFS-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141978#comment-15141978
]
Hadoop QA commented on HDFS-9637:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
16s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 42s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 55s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 0s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 10s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 51s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
49s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 42s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 42s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 43s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 52s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
20s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 9s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 51s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 66m 39s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 61m 23s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.7.0_91. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
34s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 154m 5s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_66 Failed junit tests | hadoop.hdfs.TestRollingUpgrade |
| | hadoop.hdfs.server.blockmanagement.TestBlockManager |
| | hadoop.hdfs.server.datanode.TestBlockScanner |
| | hadoop.fs.TestHdfsNativeCodeLoader |
| JDK v1.7.0_91 Failed junit tests | hadoop.hdfs.TestFileCreationDelete |
| | hadoop.hdfs.TestFileAppend |
| | hadoop.fs.TestHdfsNativeCodeLoader |
| | hadoop.hdfs.qjournal.TestSecureNNWithQJM |
| | hadoop.hdfs.TestReconstructStripedFile |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:0ca8df7 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12787342/HDFS-9637.branch2.006.patch
|
| JIRA Issue |
