Tony Wu created HDFS-9491:
-----------------------------

             Summary: Tests should get the number of pending async delets via 
FsDatasetTestUtils
                 Key: HDFS-9491
                 URL: https://issues.apache.org/jira/browse/HDFS-9491
             Project: Hadoop HDFS
          Issue Type: Improvement
          Components: test
    Affects Versions: 2.7.1
            Reporter: Tony Wu
            Assignee: Tony Wu
            Priority: Minor


A few unit tests use {{DataNodeTestUtils#getPendingAsyncDeletions}} to retrieve 
the number of pending async deletions. It internally calls 
{{FsDatasetTestUtil#getPendingAsyncDeletions}}:
{code:java}
public static long getPendingAsyncDeletions(FsDatasetSpi<?> fsd) {
    return ((FsDatasetImpl)fsd).asyncDiskService.countPendingDeletions();
}
{code}
This assumes {{FsDatasetImpl}} is (the only implementation of) {{FsDataset}}. 
However {{FsDataset}} is pluggable and can have other implementations.

We can abstract getting the number of async deletions in {{FsDatasetTestUtils}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to