[jira] [Updated] (HDDS-2343) Add immutable entries in to the DoubleBuffer for Bucket requests.
[ https://issues.apache.org/jira/browse/HDDS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDDS-2343: Fix Version/s: 0.5.0 Resolution: Fixed Status: Resolved (was: Patch Available) +1 committed via GitHub. Thanks for the contribution [~bharat]. > Add immutable entries in to the DoubleBuffer for Bucket requests. > - > > Key: HDDS-2343 > URL: https://issues.apache.org/jira/browse/HDDS-2343 > Project: Hadoop Distributed Data Store > Issue Type: Task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Fix For: 0.5.0 > > Time Spent: 20m > Remaining Estimate: 0h > > OMBucketCreateRequest.java L181: > omClientResponse = > new OMBucketCreateResponse(omBucketInfo, > omResponse.build()); > > We add this to double-buffer, and double-buffer flushThread which is running > in the background when picks up, converts to protoBuf and to ByteArray and > write to rocksDB tables. So, during this conversion(This conversion will be > done without any lock acquire), if any other request changes internal > structure(like acls list) of OMBucketInfo we might get > ConcurrentModificationException. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-2343) Add immutable entries in to the DoubleBuffer for Bucket requests.
[ https://issues.apache.org/jira/browse/HDDS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharat Viswanadham updated HDDS-2343: - Status: Patch Available (was: Open) > Add immutable entries in to the DoubleBuffer for Bucket requests. > - > > Key: HDDS-2343 > URL: https://issues.apache.org/jira/browse/HDDS-2343 > Project: Hadoop Distributed Data Store > Issue Type: Task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > OMBucketCreateRequest.java L181: > omClientResponse = > new OMBucketCreateResponse(omBucketInfo, > omResponse.build()); > > We add this to double-buffer, and double-buffer flushThread which is running > in the background when picks up, converts to protoBuf and to ByteArray and > write to rocksDB tables. So, during this conversion(This conversion will be > done without any lock acquire), if any other request changes internal > structure(like acls list) of OMBucketInfo we might get > ConcurrentModificationException. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-2343) Add immutable entries in to the DoubleBuffer for Bucket requests.
[ https://issues.apache.org/jira/browse/HDDS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-2343: - Labels: pull-request-available (was: ) > Add immutable entries in to the DoubleBuffer for Bucket requests. > - > > Key: HDDS-2343 > URL: https://issues.apache.org/jira/browse/HDDS-2343 > Project: Hadoop Distributed Data Store > Issue Type: Task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > > OMBucketCreateRequest.java L181: > omClientResponse = > new OMBucketCreateResponse(omBucketInfo, > omResponse.build()); > > We add this to double-buffer, and double-buffer flushThread which is running > in the background when picks up, converts to protoBuf and to ByteArray and > write to rocksDB tables. So, during this conversion(This conversion will be > done without any lock acquire), if any other request changes internal > structure(like acls list) of OMBucketInfo we might get > ConcurrentModificationException. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-2343) Add immutable entries in to the DoubleBuffer for Bucket requests.
[ https://issues.apache.org/jira/browse/HDDS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharat Viswanadham updated HDDS-2343: - Summary: Add immutable entries in to the DoubleBuffer for Bucket requests. (was: Add immutable entries in to the DoubleBuffer.) > Add immutable entries in to the DoubleBuffer for Bucket requests. > - > > Key: HDDS-2343 > URL: https://issues.apache.org/jira/browse/HDDS-2343 > Project: Hadoop Distributed Data Store > Issue Type: Task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > > OMBucketCreateRequest.java L181: > omClientResponse = > new OMBucketCreateResponse(omBucketInfo, > omResponse.build()); > > We add this to double-buffer, and double-buffer flushThread which is running > in the background when picks up, converts to protoBuf and to ByteArray and > write to rocksDB tables. So, during this conversion(This conversion will be > done without any lock acquire), if any other request changes internal > structure(like acls list) of OMBucketInfo we might get > ConcurrentModificationException. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-2343) Add immutable entries in to the DoubleBuffer.
[ https://issues.apache.org/jira/browse/HDDS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharat Viswanadham updated HDDS-2343: - Description: OMBucketCreateRequest.java L181: omClientResponse = new OMBucketCreateResponse(omBucketInfo, omResponse.build()); We add this to double-buffer, and double-buffer flushThread which is running in the background when picks up, converts to protoBuf and to ByteArray and write to rocksDB tables. So, during this conversion(This conversion will be done without any lock acquire), if any other request changes internal structure(like acls list) of OMBucketInfo we might get ConcurrentModificationException. was: OMBucketCreateRequest.java L181: omClientResponse = new OMBucketCreateResponse(omBucketInfo, omResponse.build()); We add this to double-buffer, and double-buffer flushThread which is running in the background when picks up, converts to protoBuf and to ByteArray and write to rocksDB tables. So, during this conversion, if any other request changes internal structure(like acls list) of OMBucketInfo we might get ConcurrentModificationException. > Add immutable entries in to the DoubleBuffer. > - > > Key: HDDS-2343 > URL: https://issues.apache.org/jira/browse/HDDS-2343 > Project: Hadoop Distributed Data Store > Issue Type: Task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > > OMBucketCreateRequest.java L181: > omClientResponse = > new OMBucketCreateResponse(omBucketInfo, > omResponse.build()); > > We add this to double-buffer, and double-buffer flushThread which is running > in the background when picks up, converts to protoBuf and to ByteArray and > write to rocksDB tables. So, during this conversion(This conversion will be > done without any lock acquire), if any other request changes internal > structure(like acls list) of OMBucketInfo we might get > ConcurrentModificationException. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
