[jira] [Updated] (HDDS-809) Refactor SCMChillModeManager

2018-11-06 Thread Yiqun Lin (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDDS-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yiqun Lin updated HDDS-809:
---
   Resolution: Fixed
Fix Version/s: 0.4.0
   Status: Resolved  (was: Patch Available)

> Refactor SCMChillModeManager
> 
>
> Key: HDDS-809
> URL: https://issues.apache.org/jira/browse/HDDS-809
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Affects Versions: 0.3.0
>Reporter: Yiqun Lin
>Assignee: Yiqun Lin
>Priority: Major
> Fix For: 0.4.0
>
> Attachments: HDDS-809.001.patch, HDDS-809.002.patch, 
> HDDS-809.003.patch
>
>
> Currently the class SCMChillModeManager and related class 
> Precheck/ChillModePrecheck are directly under the package 
> {{org.apache.hadoop.hdds.scm.server}}. This looks not so appropriate and we 
> can have a refactor for this. 
> In addition, we can separate its inner classes (rule classes) and make them 
> as independent classes. This will make the logic of chillmode manage look 
> very clean.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Updated] (HDDS-809) Refactor SCMChillModeManager

2018-11-06 Thread Yiqun Lin (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDDS-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yiqun Lin updated HDDS-809:
---
Attachment: HDDS-809.003.patch

> Refactor SCMChillModeManager
> 
>
> Key: HDDS-809
> URL: https://issues.apache.org/jira/browse/HDDS-809
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Affects Versions: 0.3.0
>Reporter: Yiqun Lin
>Assignee: Yiqun Lin
>Priority: Major
> Attachments: HDDS-809.001.patch, HDDS-809.002.patch, 
> HDDS-809.003.patch
>
>
> Currently the class SCMChillModeManager and related class 
> Precheck/ChillModePrecheck are directly under the package 
> {{org.apache.hadoop.hdds.scm.server}}. This looks not so appropriate and we 
> can have a refactor for this. 
> In addition, we can separate its inner classes (rule classes) and make them 
> as independent classes. This will make the logic of chillmode manage look 
> very clean.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Updated] (HDDS-809) Refactor SCMChillModeManager

2018-11-06 Thread Yiqun Lin (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDDS-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yiqun Lin updated HDDS-809:
---
Attachment: HDDS-809.002.patch

> Refactor SCMChillModeManager
> 
>
> Key: HDDS-809
> URL: https://issues.apache.org/jira/browse/HDDS-809
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Affects Versions: 0.3.0
>Reporter: Yiqun Lin
>Assignee: Yiqun Lin
>Priority: Major
> Attachments: HDDS-809.001.patch, HDDS-809.002.patch
>
>
> Currently the class SCMChillModeManager and related class 
> Precheck/ChillModePrecheck are directly under the package 
> {{org.apache.hadoop.hdds.scm.server}}. This looks not so appropriate and we 
> can have a refactor for this. 
> In addition, we can separate its inner classes (rule classes) and make them 
> as independent classes. This will make the logic of chillmode manage look 
> very clean.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Updated] (HDDS-809) Refactor SCMChillModeManager

2018-11-06 Thread Yiqun Lin (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDDS-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yiqun Lin updated HDDS-809:
---
Status: Patch Available  (was: Open)

Attach the patch. 
Some notes:

* Remove PrecheckChillModePrecheck, SCMChillModeManager/TestSCMChillModeManager 
into new package org.apache.hadoop.hdds.scm.chillmode
* Separate ContainerChillModeRule, DataNodeChillModeRule and 
ChillModeRestrictedOps into the independent classes
* Other some package path adjustments

No chillmode manage logic change, so this should be a safe change.

> Refactor SCMChillModeManager
> 
>
> Key: HDDS-809
> URL: https://issues.apache.org/jira/browse/HDDS-809
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Affects Versions: 0.3.0
>Reporter: Yiqun Lin
>Assignee: Yiqun Lin
>Priority: Major
> Attachments: HDDS-809.001.patch
>
>
> Currently the class SCMChillModeManager and related class 
> Precheck/ChillModePrecheck are directly under the package 
> {{org.apache.hadoop.hdds.scm.server}}. This looks not so appropriate and we 
> can have a refactor for this. 
> In addition, we can separate its inner classes (rule classes) and make them 
> as independent classes. This will make the logic of chillmode manage look 
> very clean.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Updated] (HDDS-809) Refactor SCMChillModeManager

2018-11-06 Thread Yiqun Lin (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDDS-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yiqun Lin updated HDDS-809:
---
Attachment: HDDS-809.001.patch

> Refactor SCMChillModeManager
> 
>
> Key: HDDS-809
> URL: https://issues.apache.org/jira/browse/HDDS-809
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Affects Versions: 0.3.0
>Reporter: Yiqun Lin
>Assignee: Yiqun Lin
>Priority: Major
> Attachments: HDDS-809.001.patch
>
>
> Currently the class SCMChillModeManager and related class 
> Precheck/ChillModePrecheck are directly under the package 
> {{org.apache.hadoop.hdds.scm.server}}. This looks not so appropriate and we 
> can have a refactor for this. 
> In addition, we can separate its inner classes (rule classes) and make them 
> as independent classes. This will make the logic of chillmode manage look 
> very clean.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org