[jira] [Updated] (HDFS-10437) ReconfigurationProtocol not covered by HDFSPolicyProvider.
[ https://issues.apache.org/jira/browse/HDFS-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDFS-10437: - Resolution: Fixed Fix Version/s: 2.9.0 Status: Resolved (was: Patch Available) Pushed this to trunk and branch-2. Thank you for the reviews Chris and Xiaobing and thanks Chris for reporting it. > ReconfigurationProtocol not covered by HDFSPolicyProvider. > -- > > Key: HDFS-10437 > URL: https://issues.apache.org/jira/browse/HDFS-10437 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 2.9.0 >Reporter: Chris Nauroth >Assignee: Arpit Agarwal > Fix For: 2.9.0 > > Attachments: HDFS-10437.01.patch, HDFS-10437.02.patch, > HDFS-10437.03.patch > > > The {{HDFSPolicyProvider}} class contains an entry for defining the security > policy of each HDFS RPC protocol interface. {{ReconfigurationProtocol}} is > not listed currently. This may indicate that reconfiguration functionality > is not working correctly in secured clusters. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-10437) ReconfigurationProtocol not covered by HDFSPolicyProvider.
[ https://issues.apache.org/jira/browse/HDFS-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDFS-10437: - Affects Version/s: (was: 2.8.0) 2.9.0 > ReconfigurationProtocol not covered by HDFSPolicyProvider. > -- > > Key: HDFS-10437 > URL: https://issues.apache.org/jira/browse/HDFS-10437 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 2.9.0 >Reporter: Chris Nauroth >Assignee: Arpit Agarwal > Attachments: HDFS-10437.01.patch, HDFS-10437.02.patch, > HDFS-10437.03.patch > > > The {{HDFSPolicyProvider}} class contains an entry for defining the security > policy of each HDFS RPC protocol interface. {{ReconfigurationProtocol}} is > not listed currently. This may indicate that reconfiguration functionality > is not working correctly in secured clusters. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-10437) ReconfigurationProtocol not covered by HDFSPolicyProvider.
[ https://issues.apache.org/jira/browse/HDFS-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDFS-10437: - Attachment: HDFS-10437.03.patch Thanks for the reviews [~xiaobingo], [~cnauroth]. Yes the initial length makes little sense for a set construction, it was inadvertently left in the test case. Thanks for catching it! Attaching a v3 patch to fix that. The remaining checkstyle issues are due to following the style of the original sources. I will commit this shortly. > ReconfigurationProtocol not covered by HDFSPolicyProvider. > -- > > Key: HDFS-10437 > URL: https://issues.apache.org/jira/browse/HDFS-10437 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 2.8.0 >Reporter: Chris Nauroth >Assignee: Arpit Agarwal > Attachments: HDFS-10437.01.patch, HDFS-10437.02.patch, > HDFS-10437.03.patch > > > The {{HDFSPolicyProvider}} class contains an entry for defining the security > policy of each HDFS RPC protocol interface. {{ReconfigurationProtocol}} is > not listed currently. This may indicate that reconfiguration functionality > is not working correctly in secured clusters. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-10437) ReconfigurationProtocol not covered by HDFSPolicyProvider.
[ https://issues.apache.org/jira/browse/HDFS-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated HDFS-10437: - Assignee: Arpit Agarwal (was: Xiaobing Zhou) Hadoop Flags: Reviewed +1 for patch 02, pending pre-commit. {code} -policyProviderProtocols = new ArrayList<>(services.length); +policyProviderProtocols = new HashSet<>(services.length); {code} Just a very minor nit: Passing a length to a collection constructor is usually meant to avoid a memory realloc when the expected length is known. With the switch from {{ArrayList}} to {{HashSet}}, that doesn't really work anymore though, because the argument is now interpreted as the internal hash table's capacity, with a realloc occurring after exceeding (capacity * load factor), which defaults to 0.75. Things like Guava's {{Maps#newHashMapWithExpectedSize}} internally do some math on the argument to scale it up and try to stay ahead of the load factor to prevent a realloc. It doesn't really matter much here, where it's just test code and the data set is tiny, so I'm still +1 for the patch. It's just a common pitfall of the {{HashMap}}/{{HashSet}} API. Thanks for the patch! > ReconfigurationProtocol not covered by HDFSPolicyProvider. > -- > > Key: HDFS-10437 > URL: https://issues.apache.org/jira/browse/HDFS-10437 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 2.8.0 >Reporter: Chris Nauroth >Assignee: Arpit Agarwal > Attachments: HDFS-10437.01.patch, HDFS-10437.02.patch > > > The {{HDFSPolicyProvider}} class contains an entry for defining the security > policy of each HDFS RPC protocol interface. {{ReconfigurationProtocol}} is > not listed currently. This may indicate that reconfiguration functionality > is not working correctly in secured clusters. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-10437) ReconfigurationProtocol not covered by HDFSPolicyProvider.
[ https://issues.apache.org/jira/browse/HDFS-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDFS-10437: - Attachment: HDFS-10437.02.patch Fix checkstyle issues. > ReconfigurationProtocol not covered by HDFSPolicyProvider. > -- > > Key: HDFS-10437 > URL: https://issues.apache.org/jira/browse/HDFS-10437 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 2.8.0 >Reporter: Chris Nauroth >Assignee: Xiaobing Zhou > Attachments: HDFS-10437.01.patch, HDFS-10437.02.patch > > > The {{HDFSPolicyProvider}} class contains an entry for defining the security > policy of each HDFS RPC protocol interface. {{ReconfigurationProtocol}} is > not listed currently. This may indicate that reconfiguration functionality > is not working correctly in secured clusters. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-10437) ReconfigurationProtocol not covered by HDFSPolicyProvider.
[ https://issues.apache.org/jira/browse/HDFS-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDFS-10437: - Status: Patch Available (was: Open) > ReconfigurationProtocol not covered by HDFSPolicyProvider. > -- > > Key: HDFS-10437 > URL: https://issues.apache.org/jira/browse/HDFS-10437 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 2.8.0 >Reporter: Chris Nauroth >Assignee: Xiaobing Zhou > Attachments: HDFS-10437.01.patch > > > The {{HDFSPolicyProvider}} class contains an entry for defining the security > policy of each HDFS RPC protocol interface. {{ReconfigurationProtocol}} is > not listed currently. This may indicate that reconfiguration functionality > is not working correctly in secured clusters. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-10437) ReconfigurationProtocol not covered by HDFSPolicyProvider.
[ https://issues.apache.org/jira/browse/HDFS-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDFS-10437: - Attachment: HDFS-10437.01.patch Attaching a simple fix for this issue. Updated the test to remove the exception for ReconfigurationProtocol. > ReconfigurationProtocol not covered by HDFSPolicyProvider. > -- > > Key: HDFS-10437 > URL: https://issues.apache.org/jira/browse/HDFS-10437 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 2.8.0 >Reporter: Chris Nauroth >Assignee: Xiaobing Zhou > Attachments: HDFS-10437.01.patch > > > The {{HDFSPolicyProvider}} class contains an entry for defining the security > policy of each HDFS RPC protocol interface. {{ReconfigurationProtocol}} is > not listed currently. This may indicate that reconfiguration functionality > is not working correctly in secured clusters. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org