[jira] [Updated] (HDFS-11011) Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota'
[ https://issues.apache.org/jira/browse/HDFS-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Zhou updated HDFS-11011: - Summary: Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota' (was: Add unit test for HDFS command 'dfsadmin -set/clrSpaceQuota') > Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota' > - > > Key: HDFS-11011 > URL: https://issues.apache.org/jira/browse/HDFS-11011 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Labels: fs, shell, test > Attachments: HDFS-11011.000.patch, HDFS-11011.001.patch > > > This proposes adding a bunch of unit tests for command 'dfsadmin > setSpaceQuota' and 'dfsadmin clrSpaceQuota'. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11011) Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota'
[ https://issues.apache.org/jira/browse/HDFS-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Zhou updated HDFS-11011: - Attachment: HDFS-11011.002.patch > Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota' > - > > Key: HDFS-11011 > URL: https://issues.apache.org/jira/browse/HDFS-11011 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Labels: fs, shell, test > Attachments: HDFS-11011.000.patch, HDFS-11011.001.patch, > HDFS-11011.002.patch > > > This proposes adding a bunch of unit tests for command 'dfsadmin > setSpaceQuota' and 'dfsadmin clrSpaceQuota'. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11011) Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota'
[ https://issues.apache.org/jira/browse/HDFS-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Zhou updated HDFS-11011: - Description: This proposes adding a bunch of unit tests for command 'dfsadmin setSpaceQuota' and 'dfsadmin clrSpaceQuota'. 1. test to set space quote using negative number. 2. test to set and clear space quote, regular usage. 3. test to set and clear space quote by storage type. 4. test to set and clear space quote when directory doesn't exist. 5. test to set and clear space quote when path is a file. 6. test to set and clear space quote when user has no access right. was:This proposes adding a bunch of unit tests for command 'dfsadmin setSpaceQuota' and 'dfsadmin clrSpaceQuota'. > Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota' > - > > Key: HDFS-11011 > URL: https://issues.apache.org/jira/browse/HDFS-11011 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Labels: fs, shell, test > Attachments: HDFS-11011.000.patch, HDFS-11011.001.patch, > HDFS-11011.002.patch > > > This proposes adding a bunch of unit tests for command 'dfsadmin > setSpaceQuota' and 'dfsadmin clrSpaceQuota'. > 1. test to set space quote using negative number. > 2. test to set and clear space quote, regular usage. > 3. test to set and clear space quote by storage type. > 4. test to set and clear space quote when directory doesn't exist. > 5. test to set and clear space quote when path is a file. > 6. test to set and clear space quote when user has no access right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11011) Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota'
[ https://issues.apache.org/jira/browse/HDFS-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Zhou updated HDFS-11011: - Attachment: HDFS-11011.003.patch > Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota' > - > > Key: HDFS-11011 > URL: https://issues.apache.org/jira/browse/HDFS-11011 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Labels: fs, shell, test > Attachments: HDFS-11011.000.patch, HDFS-11011.001.patch, > HDFS-11011.002.patch, HDFS-11011.003.patch > > > This proposes adding a bunch of unit tests for command 'dfsadmin > setSpaceQuota' and 'dfsadmin clrSpaceQuota'. > 1. test to set space quote using negative number. > 2. test to set and clear space quote, regular usage. > 3. test to set and clear space quote by storage type. > 4. test to set and clear space quote when directory doesn't exist. > 5. test to set and clear space quote when path is a file. > 6. test to set and clear space quote when user has no access right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11011) Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota'
[
https://issues.apache.org/jira/browse/HDFS-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu updated HDFS-11011:
-
Attachment: HDFS-11011.004.patch
The v3 patch looks good to me overall.
{code}
1454new String[] {
1455"It should be one line error message like:"
1456+ " clrSpaceQuota...Access denied for user...",
1457"clrSpaceQuota",
1458"Access denied for user"});
{code}
For var args, we don't need to construct the String[] every time. Just pass as
many parameters as we wish.
{code:title= runAndVerifyQuota()}
...
1539/* verify outputs */
1540scanIntoList(ioBuf, outs);
1541assertEquals(msgs[0], expectedOutNum, outs.size());
1542if (expectedOutNum > 0) {
1543 assertThat(outs.get(0),
1544 is(allOf(containsString(msgs[1]),
1545 containsString(msgs[2];
1546}
1547 }
{code}
This indicates that if {{expectedOutNum}} is greater than zero, the {{msgs}}
will always have at least three parameters. This is error-prone to use.
Meanwhile, the first string aka {{msg\[0\]}} is the assertEquals failing
message, different from other msgs. Let's split them.
I updated the patch slightly and upload a v4 version. Can you review that,
[~xiaobingo]? Thanks,
> Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota'
> -
>
> Key: HDFS-11011
> URL: https://issues.apache.org/jira/browse/HDFS-11011
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
>Reporter: Xiaobing Zhou
>Assignee: Xiaobing Zhou
> Labels: fs, shell, test
> Attachments: HDFS-11011.000.patch, HDFS-11011.001.patch,
> HDFS-11011.002.patch, HDFS-11011.003.patch, HDFS-11011.004.patch
>
>
> This proposes adding a bunch of unit tests for command 'dfsadmin
> setSpaceQuota' and 'dfsadmin clrSpaceQuota'.
> 1. test to set space quote using negative number.
> 2. test to set and clear space quote, regular usage.
> 3. test to set and clear space quote by storage type.
> 4. test to set and clear space quote when directory doesn't exist.
> 5. test to set and clear space quote when path is a file.
> 6. test to set and clear space quote when user has no access right.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11011) Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota'
[ https://issues.apache.org/jira/browse/HDFS-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Zhou updated HDFS-11011: - Attachment: HDFS-11011.005.patch > Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota' > - > > Key: HDFS-11011 > URL: https://issues.apache.org/jira/browse/HDFS-11011 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Labels: fs, shell, test > Attachments: HDFS-11011.000.patch, HDFS-11011.001.patch, > HDFS-11011.002.patch, HDFS-11011.003.patch, HDFS-11011.004.patch, > HDFS-11011.005.patch > > > This proposes adding a bunch of unit tests for command 'dfsadmin > setSpaceQuota' and 'dfsadmin clrSpaceQuota'. > 1. test to set space quote using negative number. > 2. test to set and clear space quote, regular usage. > 3. test to set and clear space quote by storage type. > 4. test to set and clear space quote when directory doesn't exist. > 5. test to set and clear space quote when path is a file. > 6. test to set and clear space quote when user has no access right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11011) Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota'
[ https://issues.apache.org/jira/browse/HDFS-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Zhou updated HDFS-11011: - Attachment: HDFS-11011.006.patch Posted v006 patch to fix check style issues. Thanks for reviews. > Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota' > - > > Key: HDFS-11011 > URL: https://issues.apache.org/jira/browse/HDFS-11011 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Labels: fs, shell, test > Attachments: HDFS-11011.000.patch, HDFS-11011.001.patch, > HDFS-11011.002.patch, HDFS-11011.003.patch, HDFS-11011.004.patch, > HDFS-11011.005.patch, HDFS-11011.006.patch > > > This proposes adding a bunch of unit tests for command 'dfsadmin > setSpaceQuota' and 'dfsadmin clrSpaceQuota'. > 1. test to set space quote using negative number. > 2. test to set and clear space quote, regular usage. > 3. test to set and clear space quote by storage type. > 4. test to set and clear space quote when directory doesn't exist. > 5. test to set and clear space quote when path is a file. > 6. test to set and clear space quote when user has no access right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11011) Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota'
[ https://issues.apache.org/jira/browse/HDFS-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Zhou updated HDFS-11011: - Attachment: HDFS-11011.007.patch > Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota' > - > > Key: HDFS-11011 > URL: https://issues.apache.org/jira/browse/HDFS-11011 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Labels: fs, shell, test > Attachments: HDFS-11011.000.patch, HDFS-11011.001.patch, > HDFS-11011.002.patch, HDFS-11011.003.patch, HDFS-11011.004.patch, > HDFS-11011.005.patch, HDFS-11011.006.patch, HDFS-11011.007.patch > > > This proposes adding a bunch of unit tests for command 'dfsadmin > setSpaceQuota' and 'dfsadmin clrSpaceQuota'. > 1. test to set space quote using negative number. > 2. test to set and clear space quote, regular usage. > 3. test to set and clear space quote by storage type. > 4. test to set and clear space quote when directory doesn't exist. > 5. test to set and clear space quote when path is a file. > 6. test to set and clear space quote when user has no access right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11011) Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota'
[ https://issues.apache.org/jira/browse/HDFS-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Zhou updated HDFS-11011: - Attachment: HDFS-11011.008.patch > Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota' > - > > Key: HDFS-11011 > URL: https://issues.apache.org/jira/browse/HDFS-11011 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Labels: fs, shell, test > Attachments: HDFS-11011.000.patch, HDFS-11011.001.patch, > HDFS-11011.002.patch, HDFS-11011.003.patch, HDFS-11011.004.patch, > HDFS-11011.005.patch, HDFS-11011.006.patch, HDFS-11011.007.patch, > HDFS-11011.008.patch > > > This proposes adding a bunch of unit tests for command 'dfsadmin > setSpaceQuota' and 'dfsadmin clrSpaceQuota'. > 1. test to set space quote using negative number. > 2. test to set and clear space quote, regular usage. > 3. test to set and clear space quote by storage type. > 4. test to set and clear space quote when directory doesn't exist. > 5. test to set and clear space quote when path is a file. > 6. test to set and clear space quote when user has no access right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11011) Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota'
[ https://issues.apache.org/jira/browse/HDFS-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoyu Yao updated HDFS-11011: -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0-alpha2 2.8.0 Status: Resolved (was: Patch Available) Thanks [~xiaobingo] for the contribution and [~liuml07] for the reviews. I've commit the latest patch to trunk, branch-2 and branch-2.8. > Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota' > - > > Key: HDFS-11011 > URL: https://issues.apache.org/jira/browse/HDFS-11011 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Labels: fs, shell, test > Fix For: 2.8.0, 3.0.0-alpha2 > > Attachments: HDFS-11011.000.patch, HDFS-11011.001.patch, > HDFS-11011.002.patch, HDFS-11011.003.patch, HDFS-11011.004.patch, > HDFS-11011.005.patch, HDFS-11011.006.patch, HDFS-11011.007.patch, > HDFS-11011.008.patch > > > This proposes adding a bunch of unit tests for command 'dfsadmin > setSpaceQuota' and 'dfsadmin clrSpaceQuota'. > 1. test to set space quote using negative number. > 2. test to set and clear space quote, regular usage. > 3. test to set and clear space quote by storage type. > 4. test to set and clear space quote when directory doesn't exist. > 5. test to set and clear space quote when path is a file. > 6. test to set and clear space quote when user has no access right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
