[jira] [Updated] (HDFS-11027) libhdfs++: Don't retry if there is an authentication failure
[ https://issues.apache.org/jira/browse/HDFS-11027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Clampffer updated HDFS-11027: --- Resolution: Fixed Status: Resolved (was: Patch Available) Committed to HDFS-8707. Thanks for the patch [~xiaowei.zhu]. > libhdfs++: Don't retry if there is an authentication failure > > > Key: HDFS-11027 > URL: https://issues.apache.org/jira/browse/HDFS-11027 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: James Clampffer >Assignee: James Clampffer > Attachments: HDFS-11027.HDFS-8707.000.patch, > HDFS-11027.HDFS-8707.001.patch > > > "Authentication failed" status falls into the general !status.ok() block in > the HA retry policy so it will keep attempting to failover. If the client > isn't kerberized, or doesn't have the right ticket it should give up and > return a meaningful error message (right now it returns a generic bad > connection failure string). > Wouldn't hurt to check the FixedDelayRetryPolicy to make sure that doesn't > also keep attempting to retry in the same way. I suspect it does. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11027) libhdfs++: Don't retry if there is an authentication failure
[ https://issues.apache.org/jira/browse/HDFS-11027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Clampffer updated HDFS-11027: --- Attachment: HDFS-11027.HDFS-8707.001.patch New Patch from [~xiaowei.zhu]. Looks good to me, more coverage for similar issues. +1 > libhdfs++: Don't retry if there is an authentication failure > > > Key: HDFS-11027 > URL: https://issues.apache.org/jira/browse/HDFS-11027 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: James Clampffer >Assignee: James Clampffer > Attachments: HDFS-11027.HDFS-8707.000.patch, > HDFS-11027.HDFS-8707.001.patch > > > "Authentication failed" status falls into the general !status.ok() block in > the HA retry policy so it will keep attempting to failover. If the client > isn't kerberized, or doesn't have the right ticket it should give up and > return a meaningful error message (right now it returns a generic bad > connection failure string). > Wouldn't hurt to check the FixedDelayRetryPolicy to make sure that doesn't > also keep attempting to retry in the same way. I suspect it does. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11027) libhdfs++: Don't retry if there is an authentication failure
[ https://issues.apache.org/jira/browse/HDFS-11027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Clampffer updated HDFS-11027: --- Status: Patch Available (was: Open) > libhdfs++: Don't retry if there is an authentication failure > > > Key: HDFS-11027 > URL: https://issues.apache.org/jira/browse/HDFS-11027 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: James Clampffer >Assignee: James Clampffer > Attachments: HDFS-11027.HDFS-8707.000.patch > > > "Authentication failed" status falls into the general !status.ok() block in > the HA retry policy so it will keep attempting to failover. If the client > isn't kerberized, or doesn't have the right ticket it should give up and > return a meaningful error message (right now it returns a generic bad > connection failure string). > Wouldn't hurt to check the FixedDelayRetryPolicy to make sure that doesn't > also keep attempting to retry in the same way. I suspect it does. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11027) libhdfs++: Don't retry if there is an authentication failure
[ https://issues.apache.org/jira/browse/HDFS-11027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Clampffer updated HDFS-11027: --- Attachment: HDFS-11027.HDFS-8707.000.patch Uploading patch on behalf of [~xiaowei.zhu], can't assign to him either until permissions issues are sorted out. Patch looks good to me, +1. > libhdfs++: Don't retry if there is an authentication failure > > > Key: HDFS-11027 > URL: https://issues.apache.org/jira/browse/HDFS-11027 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: James Clampffer >Assignee: James Clampffer > Attachments: HDFS-11027.HDFS-8707.000.patch > > > "Authentication failed" status falls into the general !status.ok() block in > the HA retry policy so it will keep attempting to failover. If the client > isn't kerberized, or doesn't have the right ticket it should give up and > return a meaningful error message (right now it returns a generic bad > connection failure string). > Wouldn't hurt to check the FixedDelayRetryPolicy to make sure that doesn't > also keep attempting to retry in the same way. I suspect it does. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11027) libhdfs++: Don't retry if there is an authentication failure
[ https://issues.apache.org/jira/browse/HDFS-11027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Clampffer updated HDFS-11027: --- Summary: libhdfs++: Don't retry if there is an authentication failure (was: libhdfs++: Make sure HA retry policy is aware of authentication failures) > libhdfs++: Don't retry if there is an authentication failure > > > Key: HDFS-11027 > URL: https://issues.apache.org/jira/browse/HDFS-11027 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: James Clampffer >Assignee: James Clampffer > > "Authentication failed" status falls into the general !status.ok() block in > the HA retry policy so it will keep attempting to failover. If the client > isn't kerberized, or doesn't have the right ticket it should give up and > return a meaningful error message (right now it returns a generic bad > connection failure string). > Wouldn't hurt to check the FixedDelayRetryPolicy to make sure that doesn't > also keep attempting to retry in the same way. I suspect it does. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
