[jira] [Updated] (HDFS-16402) Improve HeartbeatManager logic to avoid incorrect stats
[ https://issues.apache.org/jira/browse/HDFS-16402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan updated HDFS-16402: -- Component/s: datanode Target Version/s: 3.4.0 Affects Version/s: 3.4.0 > Improve HeartbeatManager logic to avoid incorrect stats > --- > > Key: HDFS-16402 > URL: https://issues.apache.org/jira/browse/HDFS-16402 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.4.0 >Reporter: Tao Li >Assignee: Tao Li >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Attachments: image-2021-12-29-08-25-44-303.png, > image-2021-12-29-08-25-54-441.png > > Time Spent: 3h > Remaining Estimate: 0h > > After reconfig {*}dfs.datanode.data.dir{*}, we found that the stats of the > Namenode Web became *negative* and there were many NPE in namenode logs. This > problem has been solved by HDFS-14042. > !image-2021-12-29-08-25-54-441.png|width=681,height=293! > !image-2021-12-29-08-25-44-303.png|width=677,height=180! > However, if *HeartbeatManager#updateHeartbeat* and > *HeartbeatManager#updateLifeline* throw other exceptions, stats errors can > also occur. We should ensure that *stats.subtract()* and *stats.add()* are > transactional. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-16402) Improve HeartbeatManager logic to avoid incorrect stats
[ https://issues.apache.org/jira/browse/HDFS-16402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoqiao He updated HDFS-16402: --- Summary: Improve HeartbeatManager logic to avoid incorrect stats (was: HeartbeatManager may cause incorrect stats) > Improve HeartbeatManager logic to avoid incorrect stats > --- > > Key: HDFS-16402 > URL: https://issues.apache.org/jira/browse/HDFS-16402 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: tomscut >Assignee: tomscut >Priority: Major > Labels: pull-request-available > Attachments: image-2021-12-29-08-25-44-303.png, > image-2021-12-29-08-25-54-441.png > > Time Spent: 2h 50m > Remaining Estimate: 0h > > After reconfig {*}dfs.datanode.data.dir{*}, we found that the stats of the > Namenode Web became *negative* and there were many NPE in namenode logs. This > problem has been solved by HDFS-14042. > !image-2021-12-29-08-25-54-441.png|width=681,height=293! > !image-2021-12-29-08-25-44-303.png|width=677,height=180! > However, if *HeartbeatManager#updateHeartbeat* and > *HeartbeatManager#updateLifeline* throw other exceptions, stats errors can > also occur. We should ensure that *stats.subtract()* and *stats.add()* are > transactional. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org