[jira] [Updated] (HDFS-16450) Give priority to releasing DNs with less free space
[ https://issues.apache.org/jira/browse/HDFS-16450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yanbin.zhang updated HDFS-16450: Labels: (was: 无) > Give priority to releasing DNs with less free space > --- > > Key: HDFS-16450 > URL: https://issues.apache.org/jira/browse/HDFS-16450 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Affects Versions: 3.3.0 >Reporter: yanbin.zhang >Assignee: yanbin.zhang >Priority: Major > Attachments: HDFS-16450.001.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > When deleting redundant replicas, the one with the least free space should be > prioritized. > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else { > return null; > } > excessTypes.remove(storage.getStorageType()); > return storage; {code} > Change the above logic to the following: > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else { > return null; > } {code} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-16450) Give priority to releasing DNs with less free space
[ https://issues.apache.org/jira/browse/HDFS-16450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yanbin.zhang updated HDFS-16450: Fix Version/s: 3.3.2 > Give priority to releasing DNs with less free space > --- > > Key: HDFS-16450 > URL: https://issues.apache.org/jira/browse/HDFS-16450 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Affects Versions: 3.3.0 >Reporter: yanbin.zhang >Assignee: yanbin.zhang >Priority: Major > Labels: 无 > Fix For: 3.3.2 > > Attachments: HDFS-16450.001.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > When deleting redundant replicas, the one with the least free space should be > prioritized. > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else { > return null; > } > excessTypes.remove(storage.getStorageType()); > return storage; {code} > Change the above logic to the following: > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else { > return null; > } {code} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-16450) Give priority to releasing DNs with less free space
[ https://issues.apache.org/jira/browse/HDFS-16450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yanbin.zhang updated HDFS-16450: Fix Version/s: (was: 3.3.2) > Give priority to releasing DNs with less free space > --- > > Key: HDFS-16450 > URL: https://issues.apache.org/jira/browse/HDFS-16450 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Affects Versions: 3.3.0 >Reporter: yanbin.zhang >Assignee: yanbin.zhang >Priority: Major > Labels: 无 > Attachments: HDFS-16450.001.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > When deleting redundant replicas, the one with the least free space should be > prioritized. > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else { > return null; > } > excessTypes.remove(storage.getStorageType()); > return storage; {code} > Change the above logic to the following: > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else { > return null; > } {code} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-16450) Give priority to releasing DNs with less free space
[ https://issues.apache.org/jira/browse/HDFS-16450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yanbin.zhang updated HDFS-16450: Labels: 无 (was: patch) > Give priority to releasing DNs with less free space > --- > > Key: HDFS-16450 > URL: https://issues.apache.org/jira/browse/HDFS-16450 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Affects Versions: 3.3.0 >Reporter: yanbin.zhang >Assignee: yanbin.zhang >Priority: Major > Labels: 无 > Attachments: HDFS-16450.001.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > When deleting redundant replicas, the one with the least free space should be > prioritized. > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else { > return null; > } > excessTypes.remove(storage.getStorageType()); > return storage; {code} > Change the above logic to the following: > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else { > return null; > } {code} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-16450) Give priority to releasing DNs with less free space
[ https://issues.apache.org/jira/browse/HDFS-16450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yanbin.zhang updated HDFS-16450: Labels: patch (was: pull-request-available) > Give priority to releasing DNs with less free space > --- > > Key: HDFS-16450 > URL: https://issues.apache.org/jira/browse/HDFS-16450 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Affects Versions: 3.3.0 >Reporter: yanbin.zhang >Assignee: yanbin.zhang >Priority: Major > Labels: patch > Attachments: HDFS-16450.001.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > When deleting redundant replicas, the one with the least free space should be > prioritized. > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else { > return null; > } > excessTypes.remove(storage.getStorageType()); > return storage; {code} > Change the above logic to the following: > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else { > return null; > } {code} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-16450) Give priority to releasing DNs with less free space
[ https://issues.apache.org/jira/browse/HDFS-16450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yanbin.zhang updated HDFS-16450: Description: When deleting redundant replicas, the one with the least free space should be prioritized. {code:java} //BlockPlacementPolicyDefault#chooseReplicaToDelete final DatanodeStorageInfo storage; if (oldestHeartbeatStorage != null) { storage = oldestHeartbeatStorage; } else if (minSpaceStorage != null) { storage = minSpaceStorage; } else { return null; } excessTypes.remove(storage.getStorageType()); return storage; {code} Change the above logic to the following: {code:java} //BlockPlacementPolicyDefault#chooseReplicaToDelete final DatanodeStorageInfo storage; if (minSpaceStorage != null) { storage = minSpaceStorage; } else if (oldestHeartbeatStorage != null) { storage = oldestHeartbeatStorage; } else { return null; } {code} was: When deleting redundant replicas, the one with the least free space should be prioritized. {code:java} //BlockPlacementPolicyDefault#chooseReplicaToDelete final DatanodeStorageInfo storage; if (oldestHeartbeatStorage != null) { storage = oldestHeartbeatStorage; } else if (minSpaceStorage != null) { storage = minSpaceStorage; } else { return null; } excessTypes.remove(storage.getStorageType()); return storage; {code} Change the above logic to the following: {code:java} //BlockPlacementPolicyDefault#chooseReplicaToDelete final DatanodeStorageInfo storage; if (minSpaceStorage != null) { storage = minSpaceStorage; } else if (oldestHeartbeatStorage != null) { storage = oldestHeartbeatStorage; } else { return null; } {code} > Give priority to releasing DNs with less free space > --- > > Key: HDFS-16450 > URL: https://issues.apache.org/jira/browse/HDFS-16450 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Affects Versions: 3.3.0 >Reporter: yanbin.zhang >Assignee: yanbin.zhang >Priority: Major > Labels: pull-request-available > Attachments: HDFS-16450.001.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > When deleting redundant replicas, the one with the least free space should be > prioritized. > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else { > return null; > } > excessTypes.remove(storage.getStorageType()); > return storage; {code} > Change the above logic to the following: > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else { > return null; > } {code} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-16450) Give priority to releasing DNs with less free space
[ https://issues.apache.org/jira/browse/HDFS-16450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yanbin.zhang updated HDFS-16450: Attachment: HDFS-16450.001.patch > Give priority to releasing DNs with less free space > --- > > Key: HDFS-16450 > URL: https://issues.apache.org/jira/browse/HDFS-16450 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Affects Versions: 3.3.0 >Reporter: yanbin.zhang >Assignee: yanbin.zhang >Priority: Major > Labels: pull-request-available > Attachments: HDFS-16450.001.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > When deleting redundant replicas, the one with the least free space should be > prioritized. > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else { > return null; > } > excessTypes.remove(storage.getStorageType()); > return storage; {code} > Change the above logic to the following: > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else { > return null; > } {code} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-16450) Give priority to releasing DNs with less free space
[ https://issues.apache.org/jira/browse/HDFS-16450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDFS-16450: -- Labels: pull-request-available (was: ) > Give priority to releasing DNs with less free space > --- > > Key: HDFS-16450 > URL: https://issues.apache.org/jira/browse/HDFS-16450 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Affects Versions: 3.3.0 >Reporter: yanbin.zhang >Assignee: yanbin.zhang >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > When deleting redundant replicas, the one with the least free space should be > prioritized. > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else { > return null; > } > excessTypes.remove(storage.getStorageType()); > return storage; {code} > Change the above logic to the following: > {code:java} > //BlockPlacementPolicyDefault#chooseReplicaToDelete > final DatanodeStorageInfo storage; > if (minSpaceStorage != null) { > storage = minSpaceStorage; > } else if (oldestHeartbeatStorage != null) { > storage = oldestHeartbeatStorage; > } else { > return null; > } {code} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org