[jira] [Updated] (HDFS-2547) ReplicationTargetChooser has incorrect block placement comments
[
https://issues.apache.org/jira/browse/HDFS-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harsh J updated HDFS-2547:
--
Description:
{code}
/** The class is responsible for choosing the desired number of targets
* for placing block replicas.
* The replica placement strategy is that if the writer is on a datanode,
* the 1st replica is placed on the local machine,
* otherwise a random datanode. The 2nd replica is placed on a datanode
* that is on a different rack. The 3rd replica is placed on a datanode
* which is on the same rack as the **first replca**.
*/
{code}
That should read "second replica". The test cases confirm that this is the
behavior, as well as the docs.
was:
bq. For the common case, when the replication factor is three, HDFS's placement
policy is to put one replica on one node in the local rack, another on a node
in a different (remote) rack, and the last on a different node in the same
*remote* rack.
Should actually be: "and the last on a different node in the same *local* rack."
Fix Version/s: (was: 0.24.0)
0.20.206.0
Summary: ReplicationTargetChooser has incorrect block placement
comments (was: Design doc is wrong about default block placement policy.)
Updating title/topic for 0.20
> ReplicationTargetChooser has incorrect block placement comments
> ---
>
> Key: HDFS-2547
> URL: https://issues.apache.org/jira/browse/HDFS-2547
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
>Affects Versions: 0.20.1
>Reporter: Harsh J
>Assignee: Harsh J
>Priority: Trivial
> Fix For: 0.20.206.0
>
> Attachments: HDFS-2547.patch
>
>
> {code}
> /** The class is responsible for choosing the desired number of targets
> * for placing block replicas.
> * The replica placement strategy is that if the writer is on a datanode,
> * the 1st replica is placed on the local machine,
> * otherwise a random datanode. The 2nd replica is placed on a datanode
> * that is on a different rack. The 3rd replica is placed on a datanode
> * which is on the same rack as the **first replca**.
> */
> {code}
> That should read "second replica". The test cases confirm that this is the
> behavior, as well as the docs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2547) ReplicationTargetChooser has incorrect block placement comments
[
https://issues.apache.org/jira/browse/HDFS-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harsh J updated HDFS-2547:
--
Attachment: HDFS-2547.patch
New patch that changes comments and fixes a typo.
> ReplicationTargetChooser has incorrect block placement comments
> ---
>
> Key: HDFS-2547
> URL: https://issues.apache.org/jira/browse/HDFS-2547
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
>Affects Versions: 0.20.1
>Reporter: Harsh J
>Assignee: Harsh J
>Priority: Trivial
> Fix For: 0.20.206.0
>
> Attachments: HDFS-2547.patch, HDFS-2547.patch
>
>
> {code}
> /** The class is responsible for choosing the desired number of targets
> * for placing block replicas.
> * The replica placement strategy is that if the writer is on a datanode,
> * the 1st replica is placed on the local machine,
> * otherwise a random datanode. The 2nd replica is placed on a datanode
> * that is on a different rack. The 3rd replica is placed on a datanode
> * which is on the same rack as the **first replca**.
> */
> {code}
> That should read "second replica". The test cases confirm that this is the
> behavior, as well as the docs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2547) ReplicationTargetChooser has incorrect block placement comments
[
https://issues.apache.org/jira/browse/HDFS-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harsh J updated HDFS-2547:
--
Status: Patch Available (was: Reopened)
> ReplicationTargetChooser has incorrect block placement comments
> ---
>
> Key: HDFS-2547
> URL: https://issues.apache.org/jira/browse/HDFS-2547
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
>Affects Versions: 0.20.1
>Reporter: Harsh J
>Assignee: Harsh J
>Priority: Trivial
> Fix For: 0.20.206.0
>
> Attachments: HDFS-2547.patch, HDFS-2547.patch
>
>
> {code}
> /** The class is responsible for choosing the desired number of targets
> * for placing block replicas.
> * The replica placement strategy is that if the writer is on a datanode,
> * the 1st replica is placed on the local machine,
> * otherwise a random datanode. The 2nd replica is placed on a datanode
> * that is on a different rack. The 3rd replica is placed on a datanode
> * which is on the same rack as the **first replca**.
> */
> {code}
> That should read "second replica". The test cases confirm that this is the
> behavior, as well as the docs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2547) ReplicationTargetChooser has incorrect block placement comments
[
https://issues.apache.org/jira/browse/HDFS-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harsh J updated HDFS-2547:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks Aaron for your persistence on this one. Committed to branch-1.
> ReplicationTargetChooser has incorrect block placement comments
> ---
>
> Key: HDFS-2547
> URL: https://issues.apache.org/jira/browse/HDFS-2547
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
>Affects Versions: 0.20.1
>Reporter: Harsh J
>Assignee: Harsh J
>Priority: Trivial
> Fix For: 1.1.0
>
> Attachments: HDFS-2547.patch, HDFS-2547.patch
>
>
> {code}
> /** The class is responsible for choosing the desired number of targets
> * for placing block replicas.
> * The replica placement strategy is that if the writer is on a datanode,
> * the 1st replica is placed on the local machine,
> * otherwise a random datanode. The 2nd replica is placed on a datanode
> * that is on a different rack. The 3rd replica is placed on a datanode
> * which is on the same rack as the **first replca**.
> */
> {code}
> That should read "second replica". The test cases confirm that this is the
> behavior, as well as the docs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
