[jira] [Updated] (HDFS-3652) 1.x: FSEditLog failure removes the wrong edit stream when storage dirs have same name
[
https://issues.apache.org/jira/browse/HDFS-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Foley updated HDFS-3652:
-
Target Version/s: 1.0.4 (was: 1.0.4, 1.1.0)
1.x: FSEditLog failure removes the wrong edit stream when storage dirs have
same name
-
Key: HDFS-3652
URL: https://issues.apache.org/jira/browse/HDFS-3652
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 1.0.3, 1.1.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Blocker
Fix For: 1.0.4
Attachments: hdfs-3652.txt
In {{FSEditLog.removeEditsForStorageDir}}, we iterate over the edits streams
trying to find the stream corresponding to a given dir. To check equality, we
currently use the following condition:
{code}
File parentDir = getStorageDirForStream(idx);
if (parentDir.getName().equals(sd.getRoot().getName())) {
{code}
... which is horribly incorrect. If two or more storage dirs happen to have
the same terminal path component (eg /data/1/nn and /data/2/nn) then it will
pick the wrong stream(s) to remove.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3652) 1.x: FSEditLog failure removes the wrong edit stream when storage dirs have same name
[
https://issues.apache.org/jira/browse/HDFS-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Foley updated HDFS-3652:
-
Fix Version/s: (was: 1.1.0)
1.x: FSEditLog failure removes the wrong edit stream when storage dirs have
same name
-
Key: HDFS-3652
URL: https://issues.apache.org/jira/browse/HDFS-3652
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 1.0.3, 1.1.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Blocker
Fix For: 1.0.4
Attachments: hdfs-3652.txt
In {{FSEditLog.removeEditsForStorageDir}}, we iterate over the edits streams
trying to find the stream corresponding to a given dir. To check equality, we
currently use the following condition:
{code}
File parentDir = getStorageDirForStream(idx);
if (parentDir.getName().equals(sd.getRoot().getName())) {
{code}
... which is horribly incorrect. If two or more storage dirs happen to have
the same terminal path component (eg /data/1/nn and /data/2/nn) then it will
pick the wrong stream(s) to remove.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3652) 1.x: FSEditLog failure removes the wrong edit stream when storage dirs have same name
[
https://issues.apache.org/jira/browse/HDFS-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Foley updated HDFS-3652:
-
Target Version/s: 1.0.4, 1.1.0 (was: 1.0.4, 1.1.0, 1.2.0)
Affects Version/s: (was: 1.2.0)
Fix Version/s: (was: 1.2.0)
since 1.2.0 is unreleased, it is sufficient to state it is fixed in 1.1.0.
1.x: FSEditLog failure removes the wrong edit stream when storage dirs have
same name
-
Key: HDFS-3652
URL: https://issues.apache.org/jira/browse/HDFS-3652
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 1.0.3, 1.1.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Blocker
Fix For: 1.0.4, 1.1.0
Attachments: hdfs-3652.txt
In {{FSEditLog.removeEditsForStorageDir}}, we iterate over the edits streams
trying to find the stream corresponding to a given dir. To check equality, we
currently use the following condition:
{code}
File parentDir = getStorageDirForStream(idx);
if (parentDir.getName().equals(sd.getRoot().getName())) {
{code}
... which is horribly incorrect. If two or more storage dirs happen to have
the same terminal path component (eg /data/1/nn and /data/2/nn) then it will
pick the wrong stream(s) to remove.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3652) 1.x: FSEditLog failure removes the wrong edit stream when storage dirs have same name
[
https://issues.apache.org/jira/browse/HDFS-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Lipcon updated HDFS-3652:
--
Attachment: hdfs-3652.txt
Attached patch is for branch-1.
I modified the existing storage dir failure test so that all of the name dirs
have the same name, and it started to fail. After fixing the bug, it passes.
1.x: FSEditLog failure removes the wrong edit stream when storage dirs have
same name
-
Key: HDFS-3652
URL: https://issues.apache.org/jira/browse/HDFS-3652
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 1.0.3, 1.1.0, 1.2.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Blocker
Attachments: hdfs-3652.txt
In {{FSEditLog.removeEditsForStorageDir}}, we iterate over the edits streams
trying to find the stream corresponding to a given dir. To check equality, we
currently use the following condition:
{code}
File parentDir = getStorageDirForStream(idx);
if (parentDir.getName().equals(sd.getRoot().getName())) {
{code}
... which is horribly incorrect. If two or more storage dirs happen to have
the same terminal path component (eg /data/1/nn and /data/2/nn) then it will
pick the wrong stream(s) to remove.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3652) 1.x: FSEditLog failure removes the wrong edit stream when storage dirs have same name
[
https://issues.apache.org/jira/browse/HDFS-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Lipcon updated HDFS-3652:
--
Target Version/s: 1.0.4, 1.1.0, 1.2.0 (was: 1.0.3, 1.1.0)
1.x: FSEditLog failure removes the wrong edit stream when storage dirs have
same name
-
Key: HDFS-3652
URL: https://issues.apache.org/jira/browse/HDFS-3652
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 1.0.3, 1.1.0, 1.2.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Blocker
Attachments: hdfs-3652.txt
In {{FSEditLog.removeEditsForStorageDir}}, we iterate over the edits streams
trying to find the stream corresponding to a given dir. To check equality, we
currently use the following condition:
{code}
File parentDir = getStorageDirForStream(idx);
if (parentDir.getName().equals(sd.getRoot().getName())) {
{code}
... which is horribly incorrect. If two or more storage dirs happen to have
the same terminal path component (eg /data/1/nn and /data/2/nn) then it will
pick the wrong stream(s) to remove.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
