[jira] [Updated] (HDFS-3887) Remove redundant chooseTarget methods in BlockPlacementPolicy.java
[ https://issues.apache.org/jira/browse/HDFS-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo (Nicholas), SZE updated HDFS-3887: - Resolution: Fixed Fix Version/s: 2.2.0-alpha Status: Resolved (was: Patch Available) I have committed this. Thanks, Jing! > Remove redundant chooseTarget methods in BlockPlacementPolicy.java > -- > > Key: HDFS-3887 > URL: https://issues.apache.org/jira/browse/HDFS-3887 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node >Affects Versions: 3.0.0 >Reporter: Jing Zhao >Assignee: Jing Zhao >Priority: Trivial > Fix For: 2.2.0-alpha > > Attachments: HDFS-3887.patch > > > BlockPlacementPolicy.java contains multiple chooseTarget() methods with > different parameter lists. It is difficult to follow and understand the code > since some chooseTarget methods only have minor differences and some of them > are only invoked by testing code. > In this patch, I try to remove some of the chooseTarget methods and only keep > three of them: two abstract methods and the third one using BlockCollection > as its parameter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3887) Remove redundant chooseTarget methods in BlockPlacementPolicy.java
[ https://issues.apache.org/jira/browse/HDFS-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo (Nicholas), SZE updated HDFS-3887: - Component/s: name-node Hadoop Flags: Reviewed +1 patch looks good. > Remove redundant chooseTarget methods in BlockPlacementPolicy.java > -- > > Key: HDFS-3887 > URL: https://issues.apache.org/jira/browse/HDFS-3887 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node >Affects Versions: 3.0.0 >Reporter: Jing Zhao >Assignee: Jing Zhao >Priority: Trivial > Attachments: HDFS-3887.patch > > > BlockPlacementPolicy.java contains multiple chooseTarget() methods with > different parameter lists. It is difficult to follow and understand the code > since some chooseTarget methods only have minor differences and some of them > are only invoked by testing code. > In this patch, I try to remove some of the chooseTarget methods and only keep > three of them: two abstract methods and the third one using BlockCollection > as its parameter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3887) Remove redundant chooseTarget methods in BlockPlacementPolicy.java
[ https://issues.apache.org/jira/browse/HDFS-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suresh Srinivas updated HDFS-3887: -- Status: Patch Available (was: Open) > Remove redundant chooseTarget methods in BlockPlacementPolicy.java > -- > > Key: HDFS-3887 > URL: https://issues.apache.org/jira/browse/HDFS-3887 > Project: Hadoop HDFS > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Jing Zhao >Assignee: Jing Zhao >Priority: Trivial > Attachments: HDFS-3887.patch > > > BlockPlacementPolicy.java contains multiple chooseTarget() methods with > different parameter lists. It is difficult to follow and understand the code > since some chooseTarget methods only have minor differences and some of them > are only invoked by testing code. > In this patch, I try to remove some of the chooseTarget methods and only keep > three of them: two abstract methods and the third one using BlockCollection > as its parameter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3887) Remove redundant chooseTarget methods in BlockPlacementPolicy.java
[ https://issues.apache.org/jira/browse/HDFS-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-3887: Attachment: HDFS-3887.patch > Remove redundant chooseTarget methods in BlockPlacementPolicy.java > -- > > Key: HDFS-3887 > URL: https://issues.apache.org/jira/browse/HDFS-3887 > Project: Hadoop HDFS > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Jing Zhao >Assignee: Jing Zhao >Priority: Trivial > Attachments: HDFS-3887.patch > > > BlockPlacementPolicy.java contains multiple chooseTarget() methods with > different parameter lists. It is difficult to follow and understand the code > since some chooseTarget methods only have minor differences and some of them > are only invoked by testing code. > In this patch, I try to remove some of the chooseTarget methods and only keep > three of them: two abstract methods and the third one using BlockCollection > as its parameter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
