[jira] [Updated] (HDFS-4206) Change the fields in INode and its subclasses to private

2012-11-16 Thread Tsz Wo (Nicholas), SZE (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-4206:
-

Status: Patch Available  (was: Open)

> Change the fields in INode and its subclasses to private
> 
>
> Key: HDFS-4206
> URL: https://issues.apache.org/jira/browse/HDFS-4206
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: name-node
>Reporter: Tsz Wo (Nicholas), SZE
>Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4206_20121116.patch
>
>
> The fields in INode and its subclasses are sometimes directly accessed and 
> modified by other code.  It is better to change them to private and use 
> getters/setters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HDFS-4206) Change the fields in INode and its subclasses to private

2012-11-16 Thread Tsz Wo (Nicholas), SZE (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-4206:
-

Attachment: h4206_20121116.patch

h4206_20121116.patch: 1st patch

> Change the fields in INode and its subclasses to private
> 
>
> Key: HDFS-4206
> URL: https://issues.apache.org/jira/browse/HDFS-4206
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: name-node
>Reporter: Tsz Wo (Nicholas), SZE
>Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4206_20121116.patch
>
>
> The fields in INode and its subclasses are sometimes directly accessed and 
> modified by other code.  It is better to change them to private and use 
> getters/setters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HDFS-4206) Change the fields in INode and its subclasses to private

2012-11-16 Thread Tsz Wo (Nicholas), SZE (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-4206:
-

Attachment: h4206_20121116b.patch

h4206_20121116b.patch: cannot get user serial numbers for group.

> Change the fields in INode and its subclasses to private
> 
>
> Key: HDFS-4206
> URL: https://issues.apache.org/jira/browse/HDFS-4206
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: name-node
>Reporter: Tsz Wo (Nicholas), SZE
>Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4206_20121116b.patch, h4206_20121116.patch
>
>
> The fields in INode and its subclasses are sometimes directly accessed and 
> modified by other code.  It is better to change them to private and use 
> getters/setters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HDFS-4206) Change the fields in INode and its subclasses to private

2012-11-16 Thread Tsz Wo (Nicholas), SZE (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-4206:
-

Attachment: h4206_20121116b.patch

> Change the fields in INode and its subclasses to private
> 
>
> Key: HDFS-4206
> URL: https://issues.apache.org/jira/browse/HDFS-4206
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: name-node
>Reporter: Tsz Wo (Nicholas), SZE
>Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4206_20121116b.patch, h4206_20121116.patch
>
>
> The fields in INode and its subclasses are sometimes directly accessed and 
> modified by other code.  It is better to change them to private and use 
> getters/setters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HDFS-4206) Change the fields in INode and its subclasses to private

2012-11-16 Thread Tsz Wo (Nicholas), SZE (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-4206:
-

Attachment: (was: h4206_20121116b.patch)

> Change the fields in INode and its subclasses to private
> 
>
> Key: HDFS-4206
> URL: https://issues.apache.org/jira/browse/HDFS-4206
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: name-node
>Reporter: Tsz Wo (Nicholas), SZE
>Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4206_20121116b.patch, h4206_20121116.patch
>
>
> The fields in INode and its subclasses are sometimes directly accessed and 
> modified by other code.  It is better to change them to private and use 
> getters/setters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HDFS-4206) Change the fields in INode and its subclasses to private

2012-11-18 Thread Tsz Wo (Nicholas), SZE (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-4206:
-

   Resolution: Fixed
Fix Version/s: 3.0.0
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

Suresh, thanks for reviewing the patch.

I have committed this.

> Change the fields in INode and its subclasses to private
> 
>
> Key: HDFS-4206
> URL: https://issues.apache.org/jira/browse/HDFS-4206
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: name-node
>Reporter: Tsz Wo (Nicholas), SZE
>Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 3.0.0
>
> Attachments: h4206_20121116b.patch, h4206_20121116.patch
>
>
> The fields in INode and its subclasses are sometimes directly accessed and 
> modified by other code.  It is better to change them to private and use 
> getters/setters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HDFS-4206) Change the fields in INode and its subclasses to private

2013-04-24 Thread Suresh Srinivas (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HDFS-4206:
--

Fix Version/s: 2.0.5-beta

I merged this change to branch-2.

> Change the fields in INode and its subclasses to private
> 
>
> Key: HDFS-4206
> URL: https://issues.apache.org/jira/browse/HDFS-4206
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namenode
>Reporter: Tsz Wo (Nicholas), SZE
>Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 3.0.0, 2.0.5-beta
>
> Attachments: h4206_20121116b.patch, h4206_20121116.patch
>
>
> The fields in INode and its subclasses are sometimes directly accessed and 
> modified by other code.  It is better to change them to private and use 
> getters/setters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira