[jira] [Updated] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suresh Srinivas updated HDFS-4572: -- Fix Version/s: (was: 3.0.0) 2.0.5-beta Merged the patch to branch-2 > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 2.0.5-beta > > Attachments: HDFS-4572.patch, HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suresh Srinivas updated HDFS-4572: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Committed the patch to trunk. Thank you Arpit. Thanks to Chris and Ivan for reviewing the patch. > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch, HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDFS-4572: Attachment: HDFS-4572.patch Thanks for the feedback Suresh! I have updated the patch. > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch, HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDFS-4572: Attachment: HDFS-4572.patch Thanks for the feedback Chris! Your second comment is the same as the findbug warning and I have fixed it. I did not spend much time looking into the file share APIs. Changing the file locking behavior may be risky and would require significant testing. It would be a lot of effort for the minimal diagnosability benefit and only on Windows. Would it be acceptable to file a separate Jira to look into that? > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDFS-4572: Assignee: Arpit Agarwal > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDFS-4572: Attachment: HDFS-4572.patch - Fix file handle leak in Journal.close. - Fix attempt to read from locked file that fails on Windows. - Fix a test case that was leaking a file handle. > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDFS-4572: Status: Patch Available (was: Open) > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira