[jira] [Updated] (HDFS-5146) JspHelper#bestNode() doesn't handle bad datanodes correctly
[
https://issues.apache.org/jira/browse/HDFS-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinayakumar B updated HDFS-5146:
Resolution: Cannot Reproduce
Status: Resolved (was: Patch Available)
resolving this issue as this code is no longer available after the migration of
UI to HTML5.
> JspHelper#bestNode() doesn't handle bad datanodes correctly
> ---
>
> Key: HDFS-5146
> URL: https://issues.apache.org/jira/browse/HDFS-5146
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Attachments: HDFS-5146.patch
>
>
> JspHelper#bestNode() doesn't handle correctly if the chosen datanode is down.
> {code}while (s == null) {
> if (chosenNode == null) {
> do {
> if (doRandom) {
> index = DFSUtil.getRandom().nextInt(nodes.length);
> } else {
> index++;
> }
> chosenNode = nodes[index];
> } while (deadNodes.contains(chosenNode));
> }
> chosenNode = nodes[index];
> {code}
> In this part of the code, choosing the datanode will be done only once.
> If the chosen datanode is down, then definitely exception will be thrown
> instead of re-chosing the available node.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-5146) JspHelper#bestNode() doesn't handle bad datanodes correctly
[
https://issues.apache.org/jira/browse/HDFS-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinay updated HDFS-5146:
Description:
JspHelper#bestNode() doesn't handle correctly if the chosen datanode is down.
{code}while (s == null) {
if (chosenNode == null) {
do {
if (doRandom) {
index = DFSUtil.getRandom().nextInt(nodes.length);
} else {
index++;
}
chosenNode = nodes[index];
} while (deadNodes.contains(chosenNode));
}
chosenNode = nodes[index];
{code}
In this part of the code, choosing the datanode will be done only once.
If the chosen datanode is down, then definitely exception will be thrown
instead of re-chosing the available node.
was:
JspHelper#bestNode() doesn't handle bad datanodes correctly if the chosen
datanode is down.
{code}while (s == null) {
if (chosenNode == null) {
do {
if (doRandom) {
index = DFSUtil.getRandom().nextInt(nodes.length);
} else {
index++;
}
chosenNode = nodes[index];
} while (deadNodes.contains(chosenNode));
}
chosenNode = nodes[index];
{code}
In this part of the code, choosing the datanode will be done only once.
If the chosen datanode is down, then definitely exception will be thrown
instead of re-chosing the available node.
> JspHelper#bestNode() doesn't handle bad datanodes correctly
> ---
>
> Key: HDFS-5146
> URL: https://issues.apache.org/jira/browse/HDFS-5146
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Vinay
>Assignee: Vinay
> Attachments: HDFS-5146.patch
>
>
> JspHelper#bestNode() doesn't handle correctly if the chosen datanode is down.
> {code}while (s == null) {
> if (chosenNode == null) {
> do {
> if (doRandom) {
> index = DFSUtil.getRandom().nextInt(nodes.length);
> } else {
> index++;
> }
> chosenNode = nodes[index];
> } while (deadNodes.contains(chosenNode));
> }
> chosenNode = nodes[index];
> {code}
> In this part of the code, choosing the datanode will be done only once.
> If the chosen datanode is down, then definitely exception will be thrown
> instead of re-chosing the available node.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-5146) JspHelper#bestNode() doesn't handle bad datanodes correctly
[
https://issues.apache.org/jira/browse/HDFS-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinay updated HDFS-5146:
Status: Patch Available (was: Open)
> JspHelper#bestNode() doesn't handle bad datanodes correctly
> ---
>
> Key: HDFS-5146
> URL: https://issues.apache.org/jira/browse/HDFS-5146
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.1.0-beta, 3.0.0
>Reporter: Vinay
>Assignee: Vinay
> Attachments: HDFS-5146.patch
>
>
> JspHelper#bestNode() doesn't handle bad datanodes correctly if the chosen
> datanode is down.
> {code}while (s == null) {
> if (chosenNode == null) {
> do {
> if (doRandom) {
> index = DFSUtil.getRandom().nextInt(nodes.length);
> } else {
> index++;
> }
> chosenNode = nodes[index];
> } while (deadNodes.contains(chosenNode));
> }
> chosenNode = nodes[index];
> {code}
> In this part of the code, choosing the datanode will be done only once.
> If the chosen datanode is down, then definitely exception will be thrown
> instead of re-chosing the available node.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-5146) JspHelper#bestNode() doesn't handle bad datanodes correctly
[
https://issues.apache.org/jira/browse/HDFS-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinay updated HDFS-5146:
Attachment: HDFS-5146.patch
Attached the patch, Please review
> JspHelper#bestNode() doesn't handle bad datanodes correctly
> ---
>
> Key: HDFS-5146
> URL: https://issues.apache.org/jira/browse/HDFS-5146
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Vinay
>Assignee: Vinay
> Attachments: HDFS-5146.patch
>
>
> JspHelper#bestNode() doesn't handle bad datanodes correctly if the chosen
> datanode is down.
> {code}while (s == null) {
> if (chosenNode == null) {
> do {
> if (doRandom) {
> index = DFSUtil.getRandom().nextInt(nodes.length);
> } else {
> index++;
> }
> chosenNode = nodes[index];
> } while (deadNodes.contains(chosenNode));
> }
> chosenNode = nodes[index];
> {code}
> In this part of the code, choosing the datanode will be done only once.
> If the chosen datanode is down, then definitely exception will be thrown
> instead of re-chosing the available node.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
