[jira] [Updated] (HDFS-5207) In BlockPlacementPolicy, update 2 parameters of chooseTarget()
[ https://issues.apache.org/jira/browse/HDFS-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo (Nicholas), SZE updated HDFS-5207: - Resolution: Fixed Fix Version/s: 2.3.0 Status: Resolved (was: Patch Available) I have committed this. Thanks, Junping! > In BlockPlacementPolicy, update 2 parameters of chooseTarget() > -- > > Key: HDFS-5207 > URL: https://issues.apache.org/jira/browse/HDFS-5207 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Junping Du >Assignee: Junping Du > Fix For: 2.3.0 > > Attachments: HDFS-5207-v1.patch, HDFS-5207-v2.patch, > HDFS-5207-v3.patch, HDFS-5207-v4.patch > > > We should change chooseTarget(..., DatanodeDescriptor writer, ...) to > chooseTarget (..., node writer, ...) as the only important property of writer > is to identify other nodes' location relationship so more generic one could > be better. It also helps to cover cases that client node is not a Datanode. > Also, the excluded nodes are not necessary to be a HashMap with the same key > and value, Set is more proper in this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-5207) In BlockPlacementPolicy, update 2 parameters of chooseTarget()
[ https://issues.apache.org/jira/browse/HDFS-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo (Nicholas), SZE updated HDFS-5207: - Hadoop Flags: Reviewed +1 patch looks good. > In BlockPlacementPolicy, update 2 parameters of chooseTarget() > -- > > Key: HDFS-5207 > URL: https://issues.apache.org/jira/browse/HDFS-5207 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Junping Du >Assignee: Junping Du > Attachments: HDFS-5207-v1.patch, HDFS-5207-v2.patch, > HDFS-5207-v3.patch, HDFS-5207-v4.patch > > > We should change chooseTarget(..., DatanodeDescriptor writer, ...) to > chooseTarget (..., node writer, ...) as the only important property of writer > is to identify other nodes' location relationship so more generic one could > be better. It also helps to cover cases that client node is not a Datanode. > Also, the excluded nodes are not necessary to be a HashMap with the same key > and value, Set is more proper in this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-5207) In BlockPlacementPolicy, update 2 parameters of chooseTarget()
[ https://issues.apache.org/jira/browse/HDFS-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junping Du updated HDFS-5207: - Attachment: HDFS-5207-v4.patch Sorry. The cast issue should be addressed in v3 patch. Now update in v4 patch. Thanks! > In BlockPlacementPolicy, update 2 parameters of chooseTarget() > -- > > Key: HDFS-5207 > URL: https://issues.apache.org/jira/browse/HDFS-5207 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Junping Du >Assignee: Junping Du > Attachments: HDFS-5207-v1.patch, HDFS-5207-v2.patch, > HDFS-5207-v3.patch, HDFS-5207-v4.patch > > > We should change chooseTarget(..., DatanodeDescriptor writer, ...) to > chooseTarget (..., node writer, ...) as the only important property of writer > is to identify other nodes' location relationship so more generic one could > be better. It also helps to cover cases that client node is not a Datanode. > Also, the excluded nodes are not necessary to be a HashMap with the same key > and value, Set is more proper in this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-5207) In BlockPlacementPolicy, update 2 parameters of chooseTarget()
[ https://issues.apache.org/jira/browse/HDFS-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junping Du updated HDFS-5207: - Attachment: HDFS-5207-v3.patch > In BlockPlacementPolicy, update 2 parameters of chooseTarget() > -- > > Key: HDFS-5207 > URL: https://issues.apache.org/jira/browse/HDFS-5207 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Junping Du >Assignee: Junping Du > Attachments: HDFS-5207-v1.patch, HDFS-5207-v2.patch, > HDFS-5207-v3.patch > > > We should change chooseTarget(..., DatanodeDescriptor writer, ...) to > chooseTarget (..., node writer, ...) as the only important property of writer > is to identify other nodes' location relationship so more generic one could > be better. It also helps to cover cases that client node is not a Datanode. > Also, the excluded nodes are not necessary to be a HashMap with the same key > and value, Set is more proper in this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-5207) In BlockPlacementPolicy, update 2 parameters of chooseTarget()
[ https://issues.apache.org/jira/browse/HDFS-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junping Du updated HDFS-5207: - Attachment: HDFS-5207-v2.patch Fix tiny issues on comments in v2 patch. > In BlockPlacementPolicy, update 2 parameters of chooseTarget() > -- > > Key: HDFS-5207 > URL: https://issues.apache.org/jira/browse/HDFS-5207 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Junping Du >Assignee: Junping Du > Attachments: HDFS-5207-v1.patch, HDFS-5207-v2.patch > > > We should change chooseTarget(..., DatanodeDescriptor writer, ...) to > chooseTarget (..., node writer, ...) as the only important property of writer > is to identify other nodes' location relationship so more generic one could > be better. It also helps to cover cases that client node is not a Datanode. > Also, the excluded nodes are not necessary to be a HashMap with the same key > and value, Set is more proper in this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-5207) In BlockPlacementPolicy, update 2 parameters of chooseTarget()
[ https://issues.apache.org/jira/browse/HDFS-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junping Du updated HDFS-5207: - Description: We should change chooseTarget(..., DatanodeDescriptor writer, ...) to chooseTarget (..., node writer, ...) as the only important property of writer is to identify other nodes' location relationship so more generic one could be better. It also helps to cover cases that client node is not a Datanode. Also, the excluded nodes are not necessary to be a HashMap with the same key and value, Set is more proper in this case. (was: We should change chooseTarget(..., DatanodeDescriptor writer, ...) to chooseTarget (..., node writer, ...) as the only important property of writer is to identify other nodes' location relationship so more generic one could be better. It also helps to cover cases that client node is not a Datanode also.) > In BlockPlacementPolicy, update 2 parameters of chooseTarget() > -- > > Key: HDFS-5207 > URL: https://issues.apache.org/jira/browse/HDFS-5207 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Junping Du >Assignee: Junping Du > Attachments: HDFS-5207-v1.patch > > > We should change chooseTarget(..., DatanodeDescriptor writer, ...) to > chooseTarget (..., node writer, ...) as the only important property of writer > is to identify other nodes' location relationship so more generic one could > be better. It also helps to cover cases that client node is not a Datanode. > Also, the excluded nodes are not necessary to be a HashMap with the same key > and value, Set is more proper in this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-5207) In BlockPlacementPolicy, update 2 parameters of chooseTarget()
[ https://issues.apache.org/jira/browse/HDFS-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junping Du updated HDFS-5207: - Summary: In BlockPlacementPolicy, update 2 parameters of chooseTarget() (was: In BlockPlacementPolicy, the type of writer in parameters of chooseTarget() should be updated from DatanodeDescriptor to Node) > In BlockPlacementPolicy, update 2 parameters of chooseTarget() > -- > > Key: HDFS-5207 > URL: https://issues.apache.org/jira/browse/HDFS-5207 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Junping Du >Assignee: Junping Du > Attachments: HDFS-5207-v1.patch > > > We should change chooseTarget(..., DatanodeDescriptor writer, ...) to > chooseTarget (..., node writer, ...) as the only important property of writer > is to identify other nodes' location relationship so more generic one could > be better. It also helps to cover cases that client node is not a Datanode > also. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
