[jira] [Updated] (HDFS-5252) Stable write is not handled correctly in someplace
[ https://issues.apache.org/jira/browse/HDFS-5252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Li updated HDFS-5252: - Fix Version/s: 2.2.1 > Stable write is not handled correctly in someplace > -- > > Key: HDFS-5252 > URL: https://issues.apache.org/jira/browse/HDFS-5252 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: nfs >Reporter: Brandon Li >Assignee: Brandon Li > Fix For: 2.2.1 > > Attachments: HDFS-5252.001.patch, HDFS-5252.002.patch > > > When the client asks for a stable write but the prerequisite writes are not > transferred to NFS gateway, the stableness can't be honored. NFS gateway has > to treat the write as unstable write and set the flag to UNSTABLE in the > write response. > One bug was found during test with Ubuntu client when copying one 1KB file. > For small files like 1KB file, Ubuntu client does one stable write (with > FILE_SYNC flag). However, NFS gateway missed one place > where(OpenFileCtx#doSingleWrite) it sends response with the flag NOT updated > to UNSTABLE. > With this bug, the client thinks the write is on disk and thus doesn't send > COMMIT anymore. The following test tries to read the data back and of course > fails to do so since the data was not synced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HDFS-5252) Stable write is not handled correctly in someplace
[ https://issues.apache.org/jira/browse/HDFS-5252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Li updated HDFS-5252: - Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) > Stable write is not handled correctly in someplace > -- > > Key: HDFS-5252 > URL: https://issues.apache.org/jira/browse/HDFS-5252 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: nfs >Reporter: Brandon Li >Assignee: Brandon Li > Attachments: HDFS-5252.001.patch, HDFS-5252.002.patch > > > When the client asks for a stable write but the prerequisite writes are not > transferred to NFS gateway, the stableness can't be honored. NFS gateway has > to treat the write as unstable write and set the flag to UNSTABLE in the > write response. > One bug was found during test with Ubuntu client when copying one 1KB file. > For small files like 1KB file, Ubuntu client does one stable write (with > FILE_SYNC flag). However, NFS gateway missed one place > where(OpenFileCtx#doSingleWrite) it sends response with the flag NOT updated > to UNSTABLE. > With this bug, the client thinks the write is on disk and thus doesn't send > COMMIT anymore. The following test tries to read the data back and of course > fails to do so since the data was not synced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HDFS-5252) Stable write is not handled correctly in someplace
[ https://issues.apache.org/jira/browse/HDFS-5252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Li updated HDFS-5252: - Attachment: HDFS-5252.002.patch Upload a new patch to address Jing's comments. Also added unit test. > Stable write is not handled correctly in someplace > -- > > Key: HDFS-5252 > URL: https://issues.apache.org/jira/browse/HDFS-5252 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: nfs >Reporter: Brandon Li >Assignee: Brandon Li > Attachments: HDFS-5252.001.patch, HDFS-5252.002.patch > > > When the client asks for a stable write but the prerequisite writes are not > transferred to NFS gateway, the stableness can't be honored. NFS gateway has > to treat the write as unstable write and set the flag to UNSTABLE in the > write response. > One bug was found during test with Ubuntu client when copying one 1KB file. > For small files like 1KB file, Ubuntu client does one stable write (with > FILE_SYNC flag). However, NFS gateway missed one place > where(OpenFileCtx#doSingleWrite) it sends response with the flag NOT updated > to UNSTABLE. > With this bug, the client thinks the write is on disk and thus doesn't send > COMMIT anymore. The following test tries to read the data back and of course > fails to do so since the data was not synced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HDFS-5252) Stable write is not handled correctly in someplace
[ https://issues.apache.org/jira/browse/HDFS-5252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Li updated HDFS-5252: - Status: Patch Available (was: Open) > Stable write is not handled correctly in someplace > -- > > Key: HDFS-5252 > URL: https://issues.apache.org/jira/browse/HDFS-5252 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: nfs >Reporter: Brandon Li >Assignee: Brandon Li > Attachments: HDFS-5252.001.patch > > > When the client asks for a stable write but the prerequisite writes are not > transferred to NFS gateway, the stableness can't be honored. NFS gateway has > to treat the write as unstable write and set the flag to UNSTABLE in the > write response. > One bug was found during test with Ubuntu client when copying one 1KB file. > For small files like 1KB file, Ubuntu client does one stable write (with > FILE_SYNC flag). However, NFS gateway missed one place > where(OpenFileCtx#doSingleWrite) it sends response with the flag NOT updated > to UNSTABLE. > With this bug, the client thinks the write is on disk and thus doesn't send > COMMIT anymore. The following test tries to read the data back and of course > fails to do so since the data was not synced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HDFS-5252) Stable write is not handled correctly in someplace
[ https://issues.apache.org/jira/browse/HDFS-5252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Li updated HDFS-5252: - Attachment: HDFS-5252.001.patch > Stable write is not handled correctly in someplace > -- > > Key: HDFS-5252 > URL: https://issues.apache.org/jira/browse/HDFS-5252 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: nfs >Reporter: Brandon Li >Assignee: Brandon Li > Attachments: HDFS-5252.001.patch > > > When the client asks for a stable write but the prerequisite writes are not > transferred to NFS gateway, the stableness can't be honored. NFS gateway has > to treat the write as unstable write and set the flag to UNSTABLE in the > write response. > One bug was found during test with Ubuntu client when copying one 1KB file. > For small files like 1KB file, Ubuntu client does one stable write (with > FILE_SYNC flag). However, NFS gateway missed one place > where(OpenFileCtx#doSingleWrite) it sends response with the flag NOT updated > to UNSTABLE. > With this bug, the client thinks the write is on disk and thus doesn't send > COMMIT anymore. The following test tries to read the data back and of course > fails to do so since the data was not synced. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HDFS-5252) Stable write is not handled correctly in someplace
[ https://issues.apache.org/jira/browse/HDFS-5252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Li updated HDFS-5252: - Summary: Stable write is not handled correctly in someplace (was: Stable write is handled correctly in someplace) > Stable write is not handled correctly in someplace > -- > > Key: HDFS-5252 > URL: https://issues.apache.org/jira/browse/HDFS-5252 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: nfs >Reporter: Brandon Li > > When the client asks for a stable write but the prerequisite writes are not > transferred to NFS gateway, the stableness can't be honored. NFS gateway has > to treat the write as unstable write and set the flag to UNSTABLE in the > write response. > One bug was found during test with Ubuntu client when copying one 1KB file. > For small files like 1KB file, Ubuntu client does one stable write (with > FILE_SYNC flag). However, NFS gateway missed one place > where(OpenFileCtx#doSingleWrite) it sends response with the flag NOT updated > to UNSTABLE. > With this bug, the client thinks the write is on disk and thus doesn't send > COMMIT anymore. The following test tries to read the data back and of course > fails to do so since the data was not synced. -- This message was sent by Atlassian JIRA (v6.1#6144)
