[jira] [Updated] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[ https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinay updated HDFS-5300: Attachment: HDFS-5300.patch Attached the patch, Please review > FSNameSystem#deleteSnapshot() should not check owner in case of permissions > disabled > > > Key: HDFS-5300 > URL: https://issues.apache.org/jira/browse/HDFS-5300 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Reporter: Vinay >Assignee: Vinay > Attachments: HDFS-5300.patch > > > FSNameSystem#deleteSnapshot() should not check owner in case of permissions > disabled > {code:java} checkOperation(OperationCategory.WRITE); > if (isInSafeMode()) { > throw new SafeModeException( > "Cannot delete snapshot for " + snapshotRoot, safeMode); > } > FSPermissionChecker pc = getPermissionChecker(); > checkOwner(pc, snapshotRoot); > BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo(); > List removedINodes = new ChunkedArrayList(); > dir.writeLock();{code} > should check owner only in case of permissions enabled as its done for all > other operations. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[ https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinay updated HDFS-5300: Affects Version/s: 3.0.0 2.1.0-beta Status: Patch Available (was: Open) > FSNameSystem#deleteSnapshot() should not check owner in case of permissions > disabled > > > Key: HDFS-5300 > URL: https://issues.apache.org/jira/browse/HDFS-5300 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 2.1.0-beta, 3.0.0 >Reporter: Vinay >Assignee: Vinay > Attachments: HDFS-5300.patch > > > FSNameSystem#deleteSnapshot() should not check owner in case of permissions > disabled > {code:java} checkOperation(OperationCategory.WRITE); > if (isInSafeMode()) { > throw new SafeModeException( > "Cannot delete snapshot for " + snapshotRoot, safeMode); > } > FSPermissionChecker pc = getPermissionChecker(); > checkOwner(pc, snapshotRoot); > BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo(); > List removedINodes = new ChunkedArrayList(); > dir.writeLock();{code} > should check owner only in case of permissions enabled as its done for all > other operations. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[ https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinay updated HDFS-5300: Attachment: HDFS-5300.patch Here is the updated patch > FSNameSystem#deleteSnapshot() should not check owner in case of permissions > disabled > > > Key: HDFS-5300 > URL: https://issues.apache.org/jira/browse/HDFS-5300 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 3.0.0, 2.1.0-beta >Reporter: Vinay >Assignee: Vinay > Attachments: HDFS-5300.patch, HDFS-5300.patch > > > FSNameSystem#deleteSnapshot() should not check owner in case of permissions > disabled > {code:java} checkOperation(OperationCategory.WRITE); > if (isInSafeMode()) { > throw new SafeModeException( > "Cannot delete snapshot for " + snapshotRoot, safeMode); > } > FSPermissionChecker pc = getPermissionChecker(); > checkOwner(pc, snapshotRoot); > BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo(); > List removedINodes = new ChunkedArrayList(); > dir.writeLock();{code} > should check owner only in case of permissions enabled as its done for all > other operations. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[ https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-5300: Attachment: HDFS-5300.patch Upload a patch with the nit fix to save time. > FSNameSystem#deleteSnapshot() should not check owner in case of permissions > disabled > > > Key: HDFS-5300 > URL: https://issues.apache.org/jira/browse/HDFS-5300 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 3.0.0, 2.1.0-beta >Reporter: Vinay >Assignee: Vinay > Attachments: HDFS-5300.patch, HDFS-5300.patch, HDFS-5300.patch > > > FSNameSystem#deleteSnapshot() should not check owner in case of permissions > disabled > {code:java} checkOperation(OperationCategory.WRITE); > if (isInSafeMode()) { > throw new SafeModeException( > "Cannot delete snapshot for " + snapshotRoot, safeMode); > } > FSPermissionChecker pc = getPermissionChecker(); > checkOwner(pc, snapshotRoot); > BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo(); > List removedINodes = new ChunkedArrayList(); > dir.writeLock();{code} > should check owner only in case of permissions enabled as its done for all > other operations. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[ https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-5300: Resolution: Fixed Fix Version/s: 2.1.2-beta Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks Vinay! I've committed this to trunk, branch-2 and branch-2.1-beta. > FSNameSystem#deleteSnapshot() should not check owner in case of permissions > disabled > > > Key: HDFS-5300 > URL: https://issues.apache.org/jira/browse/HDFS-5300 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 3.0.0, 2.1.0-beta >Reporter: Vinay >Assignee: Vinay > Fix For: 2.1.2-beta > > Attachments: HDFS-5300.patch, HDFS-5300.patch, HDFS-5300.patch > > > FSNameSystem#deleteSnapshot() should not check owner in case of permissions > disabled > {code:java} checkOperation(OperationCategory.WRITE); > if (isInSafeMode()) { > throw new SafeModeException( > "Cannot delete snapshot for " + snapshotRoot, safeMode); > } > FSPermissionChecker pc = getPermissionChecker(); > checkOwner(pc, snapshotRoot); > BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo(); > List removedINodes = new ChunkedArrayList(); > dir.writeLock();{code} > should check owner only in case of permissions enabled as its done for all > other operations. -- This message was sent by Atlassian JIRA (v6.1#6144)