[jira] [Updated] (HDFS-5789) Some of snapshot APIs missing checkOperation double check in fsn

2014-01-23 Thread Uma Maheswara Rao G (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uma Maheswara Rao G updated HDFS-5789:
--

Summary: Some of snapshot APIs missing checkOperation double check in fsn  
(was: Some of snapshot, Cache APIs missing checkOperation double check in fsn)

 Some of snapshot APIs missing checkOperation double check in fsn
 

 Key: HDFS-5789
 URL: https://issues.apache.org/jira/browse/HDFS-5789
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: namenode
Affects Versions: 3.0.0
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G

 HDFS-4591 introduced double checked for HA state while taking fsn lock.
 checkoperation made before actually taking lock and after the lock again.
 This pattern missed in some of the snapshot APIs and cache management related 
 APIs.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Updated] (HDFS-5789) Some of snapshot APIs missing checkOperation double check in fsn

2014-01-23 Thread Uma Maheswara Rao G (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uma Maheswara Rao G updated HDFS-5789:
--

Attachment: HDFS-5789.patch

Attached a simple patch for review.

 Some of snapshot APIs missing checkOperation double check in fsn
 

 Key: HDFS-5789
 URL: https://issues.apache.org/jira/browse/HDFS-5789
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: namenode
Affects Versions: 3.0.0
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
 Attachments: HDFS-5789.patch


 HDFS-4591 introduced double checked for HA state while taking fsn lock.
 checkoperation made before actually taking lock and after the lock again.
 This pattern missed in some of the snapshot APIs and cache management related 
 APIs.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Updated] (HDFS-5789) Some of snapshot APIs missing checkOperation double check in fsn

2014-01-23 Thread Tsz Wo (Nicholas), SZE (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-5789:
-

Hadoop Flags: Reviewed

+1 patch looks good.

 Some of snapshot APIs missing checkOperation double check in fsn
 

 Key: HDFS-5789
 URL: https://issues.apache.org/jira/browse/HDFS-5789
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: namenode
Affects Versions: 3.0.0
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
 Attachments: HDFS-5789.patch


 HDFS-4591 introduced double checked for HA state while taking fsn lock.
 checkoperation made before actually taking lock and after the lock again.
 This pattern missed in some of the snapshot APIs and cache management related 
 APIs.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Updated] (HDFS-5789) Some of snapshot APIs missing checkOperation double check in fsn

2014-01-23 Thread Uma Maheswara Rao G (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uma Maheswara Rao G updated HDFS-5789:
--

Status: Patch Available  (was: Open)

 Some of snapshot APIs missing checkOperation double check in fsn
 

 Key: HDFS-5789
 URL: https://issues.apache.org/jira/browse/HDFS-5789
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: namenode
Affects Versions: 3.0.0
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
 Attachments: HDFS-5789.patch


 HDFS-4591 introduced double checked for HA state while taking fsn lock.
 checkoperation made before actually taking lock and after the lock again.
 This pattern missed in some of the snapshot APIs and cache management related 
 APIs.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Updated] (HDFS-5789) Some of snapshot APIs missing checkOperation double check in fsn

2014-01-23 Thread Uma Maheswara Rao G (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uma Maheswara Rao G updated HDFS-5789:
--

   Resolution: Fixed
Fix Version/s: 2.3.0
   3.0.0
   Status: Resolved  (was: Patch Available)

Thanks a lot, Nicholas for the review!
I have just committed this to trunk and branch-2.

 Some of snapshot APIs missing checkOperation double check in fsn
 

 Key: HDFS-5789
 URL: https://issues.apache.org/jira/browse/HDFS-5789
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: namenode
Affects Versions: 3.0.0
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
 Fix For: 3.0.0, 2.3.0

 Attachments: HDFS-5789.patch


 HDFS-4591 introduced double checked for HA state while taking fsn lock.
 checkoperation made before actually taking lock and after the lock again.
 This pattern missed in some of the snapshot APIs and cache management related 
 APIs.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)