[jira] [Updated] (HDFS-6578) add toString method to DatanodeStorage etc for easier debugging

2014-06-23 Thread Arpit Agarwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HDFS-6578:


Issue Type: Improvement  (was: Bug)

> add toString method to DatanodeStorage etc for easier debugging
> ---
>
> Key: HDFS-6578
> URL: https://issues.apache.org/jira/browse/HDFS-6578
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Yongjun Zhang
>Assignee: Yongjun Zhang
> Attachments: HDFS-6578.001.patch, HDFS-6578.002.patch
>
>
> It seems to be nice to add a toString() method for DatanodeStorage class, so 
> we can print out its key info easier while doing debuging.
> Another thing is, in the end of BlockManager#processReport, there is the 
> following message,
> {code}
>blockLog.info("BLOCK* processReport: from storage " + 
> storage.getStorageID()
> + " node " + nodeID + ", blocks: " + newReport.getNumberOfBlocks()
> + ", processing time: " + (endTime - startTime) + " msecs");
> return !node.hasStaleStorages();
> {code}
> We could add node.hasStaleStorages() to the log, and possibly replace 
> storage.getSorateID() with the suggested storage.toString().
> Any comments? thanks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (HDFS-6578) add toString method to DatanodeStorage etc for easier debugging

2014-06-22 Thread Yongjun Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yongjun Zhang updated HDFS-6578:


Attachment: HDFS-6578.002.patch

Uploaded an alternative revision (002).


> add toString method to DatanodeStorage etc for easier debugging
> ---
>
> Key: HDFS-6578
> URL: https://issues.apache.org/jira/browse/HDFS-6578
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Yongjun Zhang
>Assignee: Yongjun Zhang
> Attachments: HDFS-6578.001.patch, HDFS-6578.002.patch
>
>
> It seems to be nice to add a toString() method for DatanodeStorage class, so 
> we can print out its key info easier while doing debuging.
> Another thing is, in the end of BlockManager#processReport, there is the 
> following message,
> {code}
>blockLog.info("BLOCK* processReport: from storage " + 
> storage.getStorageID()
> + " node " + nodeID + ", blocks: " + newReport.getNumberOfBlocks()
> + ", processing time: " + (endTime - startTime) + " msecs");
> return !node.hasStaleStorages();
> {code}
> We could add node.hasStaleStorages() to the log, and possibly replace 
> storage.getSorateID() with the suggested storage.toString().
> Any comments? thanks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (HDFS-6578) add toString method to DatanodeStorage etc for easier debugging

2014-06-21 Thread Yongjun Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yongjun Zhang updated HDFS-6578:


Attachment: HDFS-6578.001.patch

> add toString method to DatanodeStorage etc for easier debugging
> ---
>
> Key: HDFS-6578
> URL: https://issues.apache.org/jira/browse/HDFS-6578
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Yongjun Zhang
>Assignee: Yongjun Zhang
> Attachments: HDFS-6578.001.patch
>
>
> It seems to be nice to add a toString() method for DatanodeStorage class, so 
> we can print out its key info easier while doing debuging.
> Another thing is, in the end of BlockManager#processReport, there is the 
> following message,
> {code}
>blockLog.info("BLOCK* processReport: from storage " + 
> storage.getStorageID()
> + " node " + nodeID + ", blocks: " + newReport.getNumberOfBlocks()
> + ", processing time: " + (endTime - startTime) + " msecs");
> return !node.hasStaleStorages();
> {code}
> We could add node.hasStaleStorages() to the log, and possibly replace 
> storage.getSorateID() with the suggested storage.toString().
> Any comments? thanks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (HDFS-6578) add toString method to DatanodeStorage etc for easier debugging

2014-06-21 Thread Yongjun Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yongjun Zhang updated HDFS-6578:


Status: Patch Available  (was: Open)

> add toString method to DatanodeStorage etc for easier debugging
> ---
>
> Key: HDFS-6578
> URL: https://issues.apache.org/jira/browse/HDFS-6578
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Yongjun Zhang
>Assignee: Yongjun Zhang
> Attachments: HDFS-6578.001.patch
>
>
> It seems to be nice to add a toString() method for DatanodeStorage class, so 
> we can print out its key info easier while doing debuging.
> Another thing is, in the end of BlockManager#processReport, there is the 
> following message,
> {code}
>blockLog.info("BLOCK* processReport: from storage " + 
> storage.getStorageID()
> + " node " + nodeID + ", blocks: " + newReport.getNumberOfBlocks()
> + ", processing time: " + (endTime - startTime) + " msecs");
> return !node.hasStaleStorages();
> {code}
> We could add node.hasStaleStorages() to the log, and possibly replace 
> storage.getSorateID() with the suggested storage.toString().
> Any comments? thanks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)