[jira] [Updated] (HDFS-6696) Name node cannot start if the path of a file under construction contains ".snapshot"
[
https://issues.apache.org/jira/browse/HDFS-6696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Wang updated HDFS-6696:
--
Resolution: Fixed
Fix Version/s: 2.5.0
Status: Resolved (was: Patch Available)
Committed to trunk, branch-2, branch-2.5. Thanks again Kihwal for reporting,
Jing for reviewing.
I did mess up the trunk commit message a bit, forgot to put the JIRA #.
> Name node cannot start if the path of a file under construction contains
> ".snapshot"
>
>
> Key: HDFS-6696
> URL: https://issues.apache.org/jira/browse/HDFS-6696
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Andrew Wang
>Priority: Blocker
> Fix For: 2.5.0
>
> Attachments: hdfs-6696.001.patch, hdfs-6696.002.patch,
> hdfs-6696.003.patch
>
>
> Using {{-renameReserved}} to rename ".snapshot" in a pre-hdfs-snapshot
> feature fsimage during upgrade only works, if there is nothing under
> construction under the renamed directory. I am not sure whether it takes
> care of edits containing ".snapshot" properly.
> The workaround is to identify these directories and rename, then do
> {{saveNamespace}} before performing upgrade.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HDFS-6696) Name node cannot start if the path of a file under construction contains ".snapshot"
[
https://issues.apache.org/jira/browse/HDFS-6696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Wang updated HDFS-6696:
--
Attachment: hdfs-6696.003.patch
Same patch without the binary diff. All of these apply fine for me with {{patch
-p0 -E < thePatch}}, so not sure what's going on.
> Name node cannot start if the path of a file under construction contains
> ".snapshot"
>
>
> Key: HDFS-6696
> URL: https://issues.apache.org/jira/browse/HDFS-6696
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Andrew Wang
>Priority: Blocker
> Attachments: hdfs-6696.001.patch, hdfs-6696.002.patch,
> hdfs-6696.003.patch
>
>
> Using {{-renameReserved}} to rename ".snapshot" in a pre-hdfs-snapshot
> feature fsimage during upgrade only works, if there is nothing under
> construction under the renamed directory. I am not sure whether it takes
> care of edits containing ".snapshot" properly.
> The workaround is to identify these directories and rename, then do
> {{saveNamespace}} before performing upgrade.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HDFS-6696) Name node cannot start if the path of a file under construction contains ".snapshot"
[
https://issues.apache.org/jira/browse/HDFS-6696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Wang updated HDFS-6696:
--
Attachment: hdfs-6696.002.patch
Rebased, still `git diff --binary`
> Name node cannot start if the path of a file under construction contains
> ".snapshot"
>
>
> Key: HDFS-6696
> URL: https://issues.apache.org/jira/browse/HDFS-6696
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Andrew Wang
>Priority: Blocker
> Attachments: hdfs-6696.001.patch, hdfs-6696.002.patch
>
>
> Using {{-renameReserved}} to rename ".snapshot" in a pre-hdfs-snapshot
> feature fsimage during upgrade only works, if there is nothing under
> construction under the renamed directory. I am not sure whether it takes
> care of edits containing ".snapshot" properly.
> The workaround is to identify these directories and rename, then do
> {{saveNamespace}} before performing upgrade.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HDFS-6696) Name node cannot start if the path of a file under construction contains ".snapshot"
[
https://issues.apache.org/jira/browse/HDFS-6696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Wang updated HDFS-6696:
--
Status: Patch Available (was: Open)
> Name node cannot start if the path of a file under construction contains
> ".snapshot"
>
>
> Key: HDFS-6696
> URL: https://issues.apache.org/jira/browse/HDFS-6696
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Andrew Wang
>Priority: Blocker
> Attachments: hdfs-6696.001.patch
>
>
> Using {{-renameReserved}} to rename ".snapshot" in a pre-hdfs-snapshot
> feature fsimage during upgrade only works, if there is nothing under
> construction under the renamed directory. I am not sure whether it takes
> care of edits containing ".snapshot" properly.
> The workaround is to identify these directories and rename, then do
> {{saveNamespace}} before performing upgrade.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HDFS-6696) Name node cannot start if the path of a file under construction contains ".snapshot"
[
https://issues.apache.org/jira/browse/HDFS-6696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Wang updated HDFS-6696:
--
Attachment: hdfs-6696.001.patch
Thanks Mit, I assume you meant 0.23.11.
Patch attached. I found that branch-1 calls a different method to add paths,
and the rename function also needs to be called for UC files too. Added some
tests with some image+edits from 1.2.1 and 0.23.11. Patch was generated with
"git diff --binary".
> Name node cannot start if the path of a file under construction contains
> ".snapshot"
>
>
> Key: HDFS-6696
> URL: https://issues.apache.org/jira/browse/HDFS-6696
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Andrew Wang
>Priority: Blocker
> Attachments: hdfs-6696.001.patch
>
>
> Using {{-renameReserved}} to rename ".snapshot" in a pre-hdfs-snapshot
> feature fsimage during upgrade only works, if there is nothing under
> construction under the renamed directory. I am not sure whether it takes
> care of edits containing ".snapshot" properly.
> The workaround is to identify these directories and rename, then do
> {{saveNamespace}} before performing upgrade.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
