[jira] [Updated] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-05 Thread Haohui Mai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haohui Mai updated HDFS-7484:
-
Attachment: HDFS-7484.000.patch

> Simplify the workflow of calculating permission in mkdirs()
> ---
>
> Key: HDFS-7484
> URL: https://issues.apache.org/jira/browse/HDFS-7484
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-7484.000.patch
>
>
> {{FSDirMkdirsOp#mkdirsRecursively()}} currently calculates the permissions 
> based on whether {{inheritPermission}} is true. This jira proposes to 
> simplify the workflow and make it explicit for the caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-05 Thread Haohui Mai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haohui Mai updated HDFS-7484:
-
Status: Patch Available  (was: Open)

> Simplify the workflow of calculating permission in mkdirs()
> ---
>
> Key: HDFS-7484
> URL: https://issues.apache.org/jira/browse/HDFS-7484
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-7484.000.patch
>
>
> {{FSDirMkdirsOp#mkdirsRecursively()}} currently calculates the permissions 
> based on whether {{inheritPermission}} is true. This jira proposes to 
> simplify the workflow and make it explicit for the caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-11 Thread Haohui Mai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haohui Mai updated HDFS-7484:
-
Attachment: HDFS-7484.001.patch

> Simplify the workflow of calculating permission in mkdirs()
> ---
>
> Key: HDFS-7484
> URL: https://issues.apache.org/jira/browse/HDFS-7484
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-7484.000.patch, HDFS-7484.001.patch
>
>
> {{FSDirMkdirsOp#mkdirsRecursively()}} currently calculates the permissions 
> based on whether {{inheritPermission}} is true. This jira proposes to 
> simplify the workflow and make it explicit for the caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-15 Thread Haohui Mai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haohui Mai updated HDFS-7484:
-
Attachment: HDFS-7484.002.patch

> Simplify the workflow of calculating permission in mkdirs()
> ---
>
> Key: HDFS-7484
> URL: https://issues.apache.org/jira/browse/HDFS-7484
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-7484.000.patch, HDFS-7484.001.patch, 
> HDFS-7484.002.patch
>
>
> {{FSDirMkdirsOp#mkdirsRecursively()}} currently calculates the permissions 
> based on whether {{inheritPermission}} is true. This jira proposes to 
> simplify the workflow and make it explicit for the caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-15 Thread Haohui Mai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haohui Mai updated HDFS-7484:
-
Attachment: HDFS-7484.003.patch

> Simplify the workflow of calculating permission in mkdirs()
> ---
>
> Key: HDFS-7484
> URL: https://issues.apache.org/jira/browse/HDFS-7484
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-7484.000.patch, HDFS-7484.001.patch, 
> HDFS-7484.002.patch, HDFS-7484.003.patch
>
>
> {{FSDirMkdirsOp#mkdirsRecursively()}} currently calculates the permissions 
> based on whether {{inheritPermission}} is true. This jira proposes to 
> simplify the workflow and make it explicit for the caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-15 Thread Jing Zhao (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao updated HDFS-7484:

Attachment: HDFS-7484.004.patch

Continue the work of Haohui. Based on the 003 patch, add a new method 
{{INodesInPath#getExistingINodes}} to return all the existing INodes of a given 
INodesInPath instance (i.e., trimming all the null elements), and use this 
method to simplify the mkdir logic.

> Simplify the workflow of calculating permission in mkdirs()
> ---
>
> Key: HDFS-7484
> URL: https://issues.apache.org/jira/browse/HDFS-7484
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Haohui Mai
>Assignee: Jing Zhao
> Attachments: HDFS-7484.000.patch, HDFS-7484.001.patch, 
> HDFS-7484.002.patch, HDFS-7484.003.patch, HDFS-7484.004.patch
>
>
> {{FSDirMkdirsOp#mkdirsRecursively()}} currently calculates the permissions 
> based on whether {{inheritPermission}} is true. This jira proposes to 
> simplify the workflow and make it explicit for the caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-18 Thread Jing Zhao (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao updated HDFS-7484:

Attachment: HDFS-7484.005.patch

Update the patch to fix bugs. In general the current patch also contains 
changes related to {{INodesInPath}} and {{addINode}}. I will separate them out 
into another jira.

> Simplify the workflow of calculating permission in mkdirs()
> ---
>
> Key: HDFS-7484
> URL: https://issues.apache.org/jira/browse/HDFS-7484
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Haohui Mai
>Assignee: Jing Zhao
> Attachments: HDFS-7484.000.patch, HDFS-7484.001.patch, 
> HDFS-7484.002.patch, HDFS-7484.003.patch, HDFS-7484.004.patch, 
> HDFS-7484.005.patch
>
>
> {{FSDirMkdirsOp#mkdirsRecursively()}} currently calculates the permissions 
> based on whether {{inheritPermission}} is true. This jira proposes to 
> simplify the workflow and make it explicit for the caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-18 Thread Jing Zhao (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao updated HDFS-7484:

Attachment: HDFS-7484.006.patch

Refactor the code more to let {{FSDirectory#addINode}} return an INodesInPath 
instance. Also move most of the logic of rename into {{RenameOperation}}. 

> Simplify the workflow of calculating permission in mkdirs()
> ---
>
> Key: HDFS-7484
> URL: https://issues.apache.org/jira/browse/HDFS-7484
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Haohui Mai
>Assignee: Jing Zhao
> Attachments: HDFS-7484.000.patch, HDFS-7484.001.patch, 
> HDFS-7484.002.patch, HDFS-7484.003.patch, HDFS-7484.004.patch, 
> HDFS-7484.005.patch, HDFS-7484.006.patch
>
>
> {{FSDirMkdirsOp#mkdirsRecursively()}} currently calculates the permissions 
> based on whether {{inheritPermission}} is true. This jira proposes to 
> simplify the workflow and make it explicit for the caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-19 Thread Jing Zhao (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao updated HDFS-7484:

Attachment: HDFS-7484.007.patch

> Simplify the workflow of calculating permission in mkdirs()
> ---
>
> Key: HDFS-7484
> URL: https://issues.apache.org/jira/browse/HDFS-7484
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Haohui Mai
>Assignee: Jing Zhao
> Attachments: HDFS-7484.000.patch, HDFS-7484.001.patch, 
> HDFS-7484.002.patch, HDFS-7484.003.patch, HDFS-7484.004.patch, 
> HDFS-7484.005.patch, HDFS-7484.006.patch, HDFS-7484.007.patch
>
>
> {{FSDirMkdirsOp#mkdirsRecursively()}} currently calculates the permissions 
> based on whether {{inheritPermission}} is true. This jira proposes to 
> simplify the workflow and make it explicit for the caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-22 Thread Jing Zhao (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao updated HDFS-7484:

Attachment: HDFS-7484.008.patch

> Simplify the workflow of calculating permission in mkdirs()
> ---
>
> Key: HDFS-7484
> URL: https://issues.apache.org/jira/browse/HDFS-7484
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Haohui Mai
>Assignee: Jing Zhao
> Attachments: HDFS-7484.000.patch, HDFS-7484.001.patch, 
> HDFS-7484.002.patch, HDFS-7484.003.patch, HDFS-7484.004.patch, 
> HDFS-7484.005.patch, HDFS-7484.006.patch, HDFS-7484.007.patch, 
> HDFS-7484.008.patch
>
>
> {{FSDirMkdirsOp#mkdirsRecursively()}} currently calculates the permissions 
> based on whether {{inheritPermission}} is true. This jira proposes to 
> simplify the workflow and make it explicit for the caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)